Retry in-flight metadata that fails under the old gateway preference

The gateway-flip retry effect only invalidated cache entries that had
already failed. An entry whose fetch was still in flight was skipped —
so a request started while the option was off could reject after the
toggle had run, caching a failure that nothing would ever retry until
remount (Bugbot, PR Chia-Network#3029).

In-flight entries now get a rejection handler: if the pending fetch
fails, it is invalidated and refetched under the new preference, while
a result that arrives successfully is kept instead of being thrown away
and refetched. Repeated toggles can stack handlers on one promise, but
each retry goes through invalidate, so the worst case is a redundant
refetch, not an inconsistent cache.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017NXWAjaHb9SFafLeguTHd8

Author: jlobue10

packages/gui/src/components/nfts/provider/hooks/useMetadataData.ts

@@ -174,12 +174,20 @@ export default function useMetadataData(props: UseMetadataDataProps) {
     // metadata fetch stayed cached here and its NFT kept looking broken
     // after enabling the option, until a full app reload. Only failures are
     // retried: successfully fetched metadata is hash-verified content and
-    // unaffected by how it was fetched.
+    // unaffected by how it was fetched. A fetch that is still in flight
+    // started under the old preference and may fail because of it — after
+    // this effect has run, nothing else would retry that failure — so it is
+    // retried on rejection; a result that arrives successfully is kept.
     metadatasOnDemand.forEach((metadataOnDemand, nftId) => {
-      if (metadataOnDemand.error) {
+      const retry = () =>
         invalidate(nftId).catch((e) => {
           log(`Error retrying metadata for nftId: ${nftId}`, e);
         });
+
+      if (metadataOnDemand.error) {
+        retry();
+      } else if (metadataOnDemand.promise) {
+        metadataOnDemand.promise.catch(retry);
       }
     });
   }, [ipfsGateway, invalidate /* immutable */, metadatasOnDemand /* immutable */]);