Refactor change handling to use UUIDs instead of integers for IDs

- Updated Change model and related functions to use string UUIDs.
- Modified MCP handler to accommodate UUIDs for change creation, updates, and deletions.
- Adjusted test cases to reflect the new UUID structure.
- Updated audit logging to include target UUIDs.
- Changed frontend Help page examples to use UUIDs for consistency.

Author: jmartin82

backend/handlers/apikeys.go

@@ -79,7 +79,7 @@ func (h *ApiKeyHandler) Create(c echo.Context) error {
 		return c.JSON(http.StatusInternalServerError, map[string]string{"error": "Failed to create API key"})
 	}
 
-	auditLog(h.DB, c, "apikey.create", "api_key", uint64Ptr(apiKey.ID), strPtr(req.Name))
+	auditLog(h.DB, c, "apikey.create", "api_key", uint64Ptr(apiKey.ID), nil, strPtr(req.Name))
 	return c.JSON(http.StatusCreated, createApiKeyResponse{Key: rawKey, ApiKey: apiKey})
 }
 
@@ -118,7 +118,7 @@ func (h *ApiKeyHandler) Revoke(c echo.Context) error {
 		return c.JSON(http.StatusInternalServerError, map[string]string{"error": "Failed to revoke API key"})
 	}
 
-	auditLog(h.DB, c, "apikey.revoke", "api_key", uint64Ptr(id), nil)
+	auditLog(h.DB, c, "apikey.revoke", "api_key", uint64Ptr(id), nil, nil)
 	return c.JSON(http.StatusOK, map[string]string{"message": "API key revoked"})
 }
 
@@ -159,6 +159,6 @@ func (h *ApiKeyHandler) Rotate(c echo.Context) error {
 		return c.JSON(http.StatusInternalServerError, map[string]string{"error": "Failed to create new API key"})
 	}
 
-	auditLog(h.DB, c, "apikey.rotate", "api_key", uint64Ptr(apiKey.ID), strPtr(existing.Name))
+	auditLog(h.DB, c, "apikey.rotate", "api_key", uint64Ptr(apiKey.ID), nil, strPtr(existing.Name))
 	return c.JSON(http.StatusCreated, createApiKeyResponse{Key: rawKey, ApiKey: apiKey})
 }

backend/handlers/audit_helpers.go

@@ -29,11 +29,11 @@ func extractActor(c echo.Context) (string, *uint64) {
 	return "unknown", nil
 }
 
-func auditLog(db *sql.DB, c echo.Context, action, targetType string, targetID *uint64, details *string) {
+func auditLog(db *sql.DB, c echo.Context, action, targetType string, targetID *uint64, targetUUID *string, details *string) {
 	actor, actorID := extractActor(c)
 	ip := c.RealIP()
 	go func() {
-		if err := models.CreateAuditEntry(db, actor, actorID, action, targetType, targetID, details, &ip); err != nil {
+		if err := models.CreateAuditEntry(db, actor, actorID, action, targetType, targetID, targetUUID, details, &ip); err != nil {
 			log.Printf("audit: failed to log %s: %v", action, err)
 		}
 	}()

backend/handlers/auth.go

@@ -72,7 +72,7 @@ func (h *AuthHandler) Register(c echo.Context) error {
 	}
 
 	_ = models.UpdateLastLogin(h.DB, user.ID)
-	auditLog(h.DB, c, "user.register", "user", uint64Ptr(user.ID), strPtr(user.Email))
+	auditLog(h.DB, c, "user.register", "user", uint64Ptr(user.ID), nil, strPtr(user.Email))
 
 	token, err := h.generateToken(user)
 	if err != nil {
@@ -104,7 +104,7 @@ func (h *AuthHandler) Login(c echo.Context) error {
 	}
 
 	_ = models.UpdateLastLogin(h.DB, user.ID)
-	auditLog(h.DB, c, "user.login", "user", uint64Ptr(user.ID), strPtr(user.Email))
+	auditLog(h.DB, c, "user.login", "user", uint64Ptr(user.ID), nil, strPtr(user.Email))
 
 	token, err := h.generateToken(user)
 	if err != nil {
@@ -183,7 +183,7 @@ func (h *AuthHandler) ChangePassword(c echo.Context) error {
 		return c.JSON(http.StatusInternalServerError, map[string]string{"error": "Failed to update password"})
 	}
 
-	auditLog(h.DB, c, "user.password_change", "user", uint64Ptr(id), strPtr(user.Email))
+	auditLog(h.DB, c, "user.password_change", "user", uint64Ptr(id), nil, strPtr(user.Email))
 
 	return c.JSON(http.StatusOK, map[string]string{"message": "Password updated"})
 }

backend/handlers/changes.go

@@ -2,11 +2,11 @@ package handlers
 
 import (
 	"database/sql"
-	"fmt"
 	"net/http"
 	"strconv"
 	"time"
 
+	"github.com/google/uuid"
 	"github.com/labstack/echo/v4"
 
 	mw "ops-ledger/backend/middleware"
@@ -77,7 +77,7 @@ func (h *ChangeHandler) Create(c echo.Context) error {
 		return c.JSON(http.StatusInternalServerError, map[string]string{"error": "Failed to create change"})
 	}
 
-	auditLog(h.DB, c, "change.create", "change", uint64Ptr(change.ID), strPtr(req.System+": "+req.Description))
+	auditLog(h.DB, c, "change.create", "change", nil, strPtr(change.ID), strPtr(req.System+": "+req.Description))
 	if h.Hub != nil {
 		h.Hub.Publish(SSEEvent{Type: "change.created", Data: change})
 	}
@@ -89,8 +89,8 @@ func (h *ChangeHandler) Update(c echo.Context) error {
 		return err
 	}
 
-	id, err := strconv.ParseUint(c.Param("id"), 10, 64)
-	if err != nil {
+	id := c.Param("id")
+	if _, err := uuid.Parse(id); err != nil {
 		return c.JSON(http.StatusBadRequest, map[string]string{"error": "Invalid change ID"})
 	}
 
@@ -134,7 +134,7 @@ func (h *ChangeHandler) Update(c echo.Context) error {
 		return c.JSON(http.StatusInternalServerError, map[string]string{"error": "Failed to update change"})
 	}
 
-	auditLog(h.DB, c, "change.update", "change", uint64Ptr(change.ID), strPtr(req.System+": "+req.Description))
+	auditLog(h.DB, c, "change.update", "change", nil, strPtr(change.ID), strPtr(req.System+": "+req.Description))
 	if h.Hub != nil {
 		h.Hub.Publish(SSEEvent{Type: "change.updated", Data: change})
 	}
@@ -146,8 +146,8 @@ func (h *ChangeHandler) Delete(c echo.Context) error {
 		return err
 	}
 
-	id, err := strconv.ParseUint(c.Param("id"), 10, 64)
-	if err != nil {
+	id := c.Param("id")
+	if _, err := uuid.Parse(id); err != nil {
 		return c.JSON(http.StatusBadRequest, map[string]string{"error": "Invalid change ID"})
 	}
 
@@ -164,9 +164,9 @@ func (h *ChangeHandler) Delete(c echo.Context) error {
 		return c.JSON(http.StatusInternalServerError, map[string]string{"error": "Failed to delete change"})
 	}
 
-	auditLog(h.DB, c, "change.delete", "change", uint64Ptr(id), strPtr(change.System+": "+change.Description))
+	auditLog(h.DB, c, "change.delete", "change", nil, strPtr(id), strPtr(change.System+": "+change.Description))
 	if h.Hub != nil {
-		h.Hub.Publish(SSEEvent{Type: "change.deleted", Data: DeletedPayload{ID: fmt.Sprintf("%d", id)}})
+		h.Hub.Publish(SSEEvent{Type: "change.deleted", Data: DeletedPayload{ID: id}})
 	}
 	return c.JSON(http.StatusOK, map[string]string{"message": "Change deleted"})
 }