Skip to content

Commit 3d925ab

Browse files
committed
Fix default mutable argument: filters
Otherwise filters is initialized when the function is defined and *not* when it is called as one would expect.
1 parent bf3a170 commit 3d925ab

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

src/sst/core/testingframework/sst_unittest_support.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1126,7 +1126,7 @@ def testing_compare_filtered_diff(
11261126
outfile: str,
11271127
reffile: str,
11281128
sort: bool = False,
1129-
filters: Union[LineFilter, List[LineFilter]] = list(),
1129+
filters: Union[None, LineFilter, List[LineFilter]] = None,
11301130
do_statistics_comparison: bool = False,
11311131
) -> bool:
11321132
"""Filter, optionally sort and then compare 2 files for a difference.
@@ -1145,6 +1145,9 @@ def testing_compare_filtered_diff(
11451145
11461146
"""
11471147

1148+
if filters is None:
1149+
filters = []
1150+
11481151
if isinstance(filters, LineFilter):
11491152
filters = [filters]
11501153

0 commit comments

Comments
 (0)