Skip to content

Commit ae5ac69

Browse files
committed
Improve test coverage
1 parent 59ff234 commit ae5ac69

File tree

5 files changed

+95
-9
lines changed

5 files changed

+95
-9
lines changed

Cosmic.xcodeproj/project.pbxproj

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
0411F6EF1EFF256200BE872F /* RegularExpressionAsserts.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0411F6ED1EFF256200BE872F /* RegularExpressionAsserts.swift */; };
1414
0411F6F11F02F5CC00BE872F /* Debug.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0411F6F01F02F5CC00BE872F /* Debug.swift */; };
1515
0411F6F31F03097B00BE872F /* Operators.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0411F6F21F03097B00BE872F /* Operators.swift */; };
16+
04126BF320868AAF00A4059D /* UniversalSocket.swift in Sources */ = {isa = PBXBuildFile; fileRef = 04126BF220868AAF00A4059D /* UniversalSocket.swift */; };
1617
041DF8081E88547100934C76 /* Cosmic.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 041DF7FE1E88547100934C76 /* Cosmic.framework */; };
1718
043F76D1A753AD879F5C9903 /* Pods_CosmicTests.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 81958AC61E937B08DB5441EA /* Pods_CosmicTests.framework */; };
1819
0441B8CE1F116CC20088A851 /* LoggerTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0441B8CD1F116CC20088A851 /* LoggerTests.swift */; };
@@ -72,6 +73,7 @@
7273
0411F6ED1EFF256200BE872F /* RegularExpressionAsserts.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = RegularExpressionAsserts.swift; sourceTree = "<group>"; };
7374
0411F6F01F02F5CC00BE872F /* Debug.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = Debug.swift; sourceTree = "<group>"; };
7475
0411F6F21F03097B00BE872F /* Operators.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = Operators.swift; sourceTree = "<group>"; };
76+
04126BF220868AAF00A4059D /* UniversalSocket.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = UniversalSocket.swift; sourceTree = "<group>"; };
7577
041DF7FE1E88547100934C76 /* Cosmic.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = Cosmic.framework; sourceTree = BUILT_PRODUCTS_DIR; };
7678
041DF8071E88547100934C76 /* CosmicTests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = CosmicTests.xctest; sourceTree = BUILT_PRODUCTS_DIR; };
7779
0441B8CD1F116CC20088A851 /* LoggerTests.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = LoggerTests.swift; sourceTree = "<group>"; };
@@ -229,6 +231,7 @@
229231
04F559D71F2281EF0048F2E0 /* LogMetadataTests.swift */,
230232
049489231FB4F35500533B46 /* ExtensionsTests.swift */,
231233
0409989D2085362600DBD481 /* LamdaLoggerTests.swift */,
234+
04126BF220868AAF00A4059D /* UniversalSocket.swift */,
232235
);
233236
path = CosmicTests;
234237
sourceTree = "<group>";
@@ -515,6 +518,7 @@
515518
048F15271F1A6C54009ED8F1 /* LogItLoggerTests.swift in Sources */,
516519
0409989E2085362600DBD481 /* LamdaLoggerTests.swift in Sources */,
517520
049F00EC1EFED30C00BD9E41 /* LogReporterTests.swift in Sources */,
521+
04126BF320868AAF00A4059D /* UniversalSocket.swift in Sources */,
518522
04FCF0FF1F115EE500505A5F /* OperatorsTests.swift in Sources */,
519523
049F00F71EFF0CCA00BD9E41 /* PrintLoggerTests.swift in Sources */,
520524
049F00E81EFED30C00BD9E41 /* CompositeLoggerTests.swift in Sources */,

Tests/CosmicTests/FormatterTests.swift

Lines changed: 17 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,20 @@ class FormatterTests: XCTestCase {
2525

2626
func testBasicLogFormatter() {
2727

28+
let formatter = BasicLogFormatter()
29+
30+
let string = formatter.format(message: "a", metadata: LogMetadata()); let line = #line
31+
32+
XCTAssertEqual(string, "[FormatterTests.swift → testBasicLogFormatter():\(line)] a")
33+
}
34+
35+
func testBasicLogFormatterWithPrefixAndSuffix() {
36+
2837
let formatter = BasicLogFormatter(prefix: "a", suffix: "c")
2938

30-
let string = formatter.format(message: "b", metadata: LogMetadata())
39+
let string = formatter.format(message: "b", metadata: LogMetadata()); let line = #line
3140

32-
XCTAssertEqual(string, "[FormatterTests.swift → testBasicLogFormatter():30] abc")
41+
XCTAssertEqual(string, "[FormatterTests.swift → testBasicLogFormatterWithPrefixAndSuffix():\(line)] abc")
3342

3443
}
3544

@@ -94,12 +103,12 @@ class FormatterTests: XCTestCase {
94103
}
95104

96105
func testDateFormatter() {
97-
// let dateFormatter = DateLogFormatter()
98-
//
99-
// let formattedMessage = dateFormatter.format(message: "Test", metadata: LogMetadata())
100-
//
101-
// // TODO
102-
// XCTAssertMatches(input: formattedMessage, pattern: "[FormatterTests.swift → testDateFormatter():100] \(dateTimeExpr) Test")
106+
let dateFormatter = DateLogFormatter()
107+
108+
let formattedMessage = dateFormatter.format(message: "Test", metadata: LogMetadata()); let line = #line
109+
110+
// TODO
111+
XCTAssertMatches(input: formattedMessage, pattern: "\\[FormatterTests\\.swift → testDateFormatter\\(\\):\(line)\\] \(dateTimeExpr) Test")
103112
}
104113

105114
// MARK: Batch formatters

Tests/CosmicTests/LogFilterTests.swift

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,25 @@ class LogFilterTests: XCTestCase {
7171

7272
let entries = logger.cache.entriesFor(logLevel: .info)
7373
XCTAssert(entries.isEmpty)
74-
74+
75+
}
7576

77+
func testClassLogFilterIncluded() {
78+
79+
let memoryLogger = MemoryLogger()
80+
let printLogger = PrintLogger()
81+
82+
let filter = ClassBasedLogFilter()
83+
84+
LogFilters.global.addFilter(filter: filter)
85+
86+
filter.include(type: PrintLogger.self, logLevel: .info)
87+
88+
memoryLogger.info("This is a log")
89+
90+
let entries = memoryLogger.cache.entriesFor(logLevel: .info)
91+
XCTAssert(entries.isEmpty)
92+
7693
}
7794

7895
}

Tests/CosmicTests/ServiceLoggerTests.swift

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,16 @@ class ServiceLoggerTests: XCTestCase {
2121
super.tearDown()
2222
}
2323

24+
func testLogzLoggerFormatters() {
25+
26+
let logger = LogzLogger()
27+
28+
let formatter = logger.formatters.first as? JSONFormatter
29+
30+
XCTAssertNotNil(formatter)
31+
XCTAssertEqual(formatter?.converter("Test")["message"] as? String, "Test")
32+
33+
}
2434

2535
func testLogzLogger() {
2636

@@ -37,6 +47,16 @@ class ServiceLoggerTests: XCTestCase {
3747
XCTAssertEqual(logger.config!.query[LogzServiceConfig.tokenKey]!, "MY_TOKEN")
3848
}
3949

50+
func testLogzLoggerLevel() {
51+
52+
let logger = LogzLogger(withToken: "MY_TOKEN")
53+
54+
logger.logLevel = .warn
55+
56+
XCTAssertEqual(logger.config?.query[LogzServiceConfig.typeKey], LogLevel.warn.simpleName)
57+
58+
}
59+
4060
func testPapertrailLogger() {
4161

4262
let logger = PapertrailLogger()
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
//
2+
// UniversalSocket.swift
3+
// CosmicTests
4+
//
5+
// Created by Jack Newcombe on 17/04/2018.
6+
// Copyright © 2018 Jack Newcombe. All rights reserved.
7+
//
8+
9+
import XCTest
10+
@testable import Cosmic
11+
12+
class UniversalSocketTests: XCTestCase {
13+
14+
override func setUp() {
15+
super.setUp()
16+
// Put setup code here. This method is called before the invocation of each test method in the class.
17+
}
18+
19+
override func tearDown() {
20+
// Put teardown code here. This method is called after the invocation of each test method in the class.
21+
super.tearDown()
22+
}
23+
24+
func testSocketSetup() {
25+
26+
let config = SocketLoggerConfig(host: "", port: 8080, transport: .tcp)
27+
28+
let socket = try! UniversalSocket(config: config)
29+
try! socket.listen()
30+
31+
XCTAssert(socket.socket.isListening)
32+
XCTAssertEqual(socket.socket.remoteHostname, "0.0.0.0")
33+
XCTAssertEqual(socket.socket.listeningPort, 8080)
34+
}
35+
36+
}

0 commit comments

Comments
 (0)