Skip to content

[Bug] Small-screen profile picker hides favorites after selecting a non-favorite #701

@mesta1

Description

@mesta1

Brief summary of the bug

On the device UI, selecting a non-favorite profile makes earlier favorite profiles unreachable with the left/right arrows.

Describe the issue in greater detail

Please review also the attached patch file as proof that profile selection is not working correctly.

profile-picker-small-screen-fix.patch

I have 5 profiles: #1, #2, #3, #4, #5.

Profiles #1 and #2 are favorites. On startup, profile #1 appears and is selected. I can use the right arrow to scroll to profile #3 and select it.

After using profile #3, I open the profile picker again and try to go back to profile #1. The left arrow does not let me scroll back. The picker only allows navigation through #3, #4, and #5, so favorite profiles #1 and #2 disappear from the reachable list.

Expected behavior:
After selecting #3, the profile picker should still allow navigation back to #2 and #1.

Actual behavior:
After selecting #3, the picker starts at #3 and only allows scrolling through #3, #4, #5.

Are you able to reproduce the issue?

Yes

Steps to reproduce

  1. Create 5 profiles: Feature/steam mode #1, Steam Mode #2, Show Bluetooth and WiFi status #3, Show errors from controller #4, Add Bluetooth scale connection and allow weighed brewing #5.
  2. Mark only Feature/steam mode #1 and Steam Mode #2 as favorites.
  3. Start the machine.
  4. Open the small-screen/device profile picker.
  5. Confirm Feature/steam mode #1 is shown as the selected/current profile.
  6. Use the right arrow to navigate to Show Bluetooth and WiFi status #3.
  7. Select/use Show Bluetooth and WiFi status #3.
  8. Open the profile picker again.
  9. Try to use the left arrow to navigate back to Feature/steam mode #1 or Steam Mode #2.

Expected behavior

The profile picker should still allow navigation through all profiles, including the favorite profiles before the current non-favorite profile.

After selecting #3, pressing left should allow me to reach #2 and then #1.

Has this function/fetaure worked before with your GaggiMate?

Yes

Relevant logs or error messages

Firmware version

1.8.x

What machine are you experiencing this issue on?

No response

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions