fix: unify response handling across all tools and resources

- Resources now use normalizeResponse() for consistent JSON structure
- check_domain uses shared normalizer instead of manual parsing
- Help tool uses createToolError() for structured error responses
- All endpoints now return { success: true/false, ... } format

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: joachimBrindeau

src/resources.ts

@@ -1,5 +1,6 @@
 import type { McpServer } from '@modelcontextprotocol/sdk/server/mcp.js';
 import { getClient } from './client.js';
+import { normalizeResponse } from './normalize.js';
 
 export function registerAllResources(server: McpServer): void {
   // Account information resource
@@ -13,12 +14,13 @@ export function registerAllResources(server: McpServer): void {
     async () => {
       const client = getClient();
       const result = await client.execute('account_info');
+      const normalized = normalizeResponse('account_info', result);
       return {
         contents: [
           {
             uri: 'account://info',
             mimeType: 'application/json',
-            text: JSON.stringify(result, null, 2),
+            text: JSON.stringify(normalized, null, 2),
           },
         ],
       };
@@ -36,12 +38,13 @@ export function registerAllResources(server: McpServer): void {
     async () => {
       const client = getClient();
       const result = await client.execute('list_domain');
+      const normalized = normalizeResponse('list_domain', result);
       return {
         contents: [
           {
             uri: 'domains://list',
             mimeType: 'application/json',
-            text: JSON.stringify(result, null, 2),
+            text: JSON.stringify(normalized, null, 2),
           },
         ],
       };
@@ -59,12 +62,13 @@ export function registerAllResources(server: McpServer): void {
     async () => {
       const client = getClient();
       const result = await client.execute('contact_list');
+      const normalized = normalizeResponse('contact_list', result);
       return {
         contents: [
           {
             uri: 'contacts://list',
             mimeType: 'application/json',
-            text: JSON.stringify(result, null, 2),
+            text: JSON.stringify(normalized, null, 2),
           },
         ],
       };
@@ -82,12 +86,13 @@ export function registerAllResources(server: McpServer): void {
     async () => {
       const client = getClient();
       const result = await client.execute('folder_list');
+      const normalized = normalizeResponse('folder_list', result);
       return {
         contents: [
           {
             uri: 'folders://list',
             mimeType: 'application/json',
-            text: JSON.stringify(result, null, 2),
+            text: JSON.stringify(normalized, null, 2),
           },
         ],
       };

src/tools/check-domain.ts

@@ -1,6 +1,7 @@
 import type { McpServer } from '@modelcontextprotocol/sdk/server/mcp.js';
 import { z } from 'zod';
 import { getClient } from '../client.js';
+import { normalizeResponse } from '../normalize.js';
 
 const inputSchema = {
   domain: z.string().describe('Domain to check (e.g., example.com)'),
@@ -30,26 +31,23 @@ export function registerCheckDomainTool(server: McpServer): void {
       }
 
       const response = await client.execute('search', params);
+      const normalized = normalizeResponse('search', response) as {
+        success: boolean;
+        results?: Array<{ domain: string; available: boolean; price?: string }>;
+      };
 
-      // Parse response - Dynadot returns SearchResponse with search results
-      const searchResults = response.SearchResponse as
-        | { SearchResults?: Array<{ Domain?: string; Available?: string; Price?: string }> }
-        | undefined;
-      const results = searchResults?.SearchResults ?? [];
-      const result = results[0];
-
-      const available = result?.Available === 'yes';
-      const price = result?.Price;
+      const result = normalized.results?.[0];
 
       return {
         content: [
           {
             type: 'text',
             text: JSON.stringify(
               {
+                success: normalized.success,
                 domain,
-                available,
-                ...(showPrice && price ? { price } : {}),
+                available: result?.available ?? false,
+                ...(showPrice && result?.price ? { price: result.price } : {}),
               },
               null,
               2,

src/tools/help.ts

@@ -1,5 +1,6 @@
 import type { McpServer } from '@modelcontextprotocol/sdk/server/mcp.js';
 import { z } from 'zod';
+import { createToolError } from '../errors.js';
 import { compositeTools } from '../schemas/index.js';
 
 const inputSchema = {
@@ -49,40 +50,27 @@ export function registerHelpTool(server: McpServer): void {
 
       if (query === 'actions') {
         if (!toolName) {
+          const error = createToolError('Missing tool parameter', {
+            type: 'MISSING_PARAM',
+            param: 'tool',
+            tool: 'dynadot_help',
+          });
           return {
-            content: [
-              {
-                type: 'text',
-                text: JSON.stringify(
-                  {
-                    success: false,
-                    error: 'Please specify a tool name with the "tool" parameter',
-                  },
-                  null,
-                  2,
-                ),
-              },
-            ],
+            content: [{ type: 'text', text: error.toJSON() }],
+            isError: true,
           };
         }
 
         const tool = compositeTools.find((t) => t.name === toolName);
         if (!tool) {
+          const error = createToolError(`Tool "${toolName}" not found`, {
+            type: 'VALIDATION_ERROR',
+            tool: 'dynadot_help',
+          });
+          error.suggestions = [`Available tools: ${compositeTools.map((t) => t.name).join(', ')}`];
           return {
-            content: [
-              {
-                type: 'text',
-                text: JSON.stringify(
-                  {
-                    success: false,
-                    error: `Tool "${toolName}" not found`,
-                    availableTools: compositeTools.map((t) => t.name),
-                  },
-                  null,
-                  2,
-                ),
-              },
-            ],
+            content: [{ type: 'text', text: error.toJSON() }],
+            isError: true,
           };
         }
 
@@ -136,20 +124,14 @@ export function registerHelpTool(server: McpServer): void {
         };
       }
 
+      const error = createToolError('Invalid query', {
+        type: 'VALIDATION_ERROR',
+        tool: 'dynadot_help',
+      });
+      error.suggestions = ['Use query: "tools", "actions", or "examples"'];
       return {
-        content: [
-          {
-            type: 'text',
-            text: JSON.stringify(
-              {
-                success: false,
-                error: 'Invalid query. Use: tools, actions, or examples',
-              },
-              null,
-              2,
-            ),
-          },
-        ],
+        content: [{ type: 'text', text: error.toJSON() }],
+        isError: true,
       };
     },
   );