Skip to content

find_package_handle_standard_args(rt ...) uses wrong case #494

@calumr

Description

@calumr

Right now I get the following warning when using pigpio via cmake:

CMake Warning (dev) at /usr/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:273 (message):
  The package name passed to `find_package_handle_standard_args` (rt) does
  not match the name of the calling package (RT).  This can lead to problems
  in calling code that expects `find_package` result variables (e.g.,
  `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
  /home/calum/bin/_deps/pigpio-src/cmake/FindRT.cmake:28 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  /home/calum/bin/_deps/pigpio-src/CMakeLists.txt:8 (find_package)
This warning is for project developers.  Use -Wno-dev to suppress it.

The fix is to just use uppercase for the package name:

FIND_PACKAGE_HANDLE_STANDARD_ARGS(RT ...)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions