fix: address review findings in PR coleam00#962

- Remove duplicate 'returns null when no resumable run exists' test that was
  accidentally left in alongside the newly-added one
- Fix twoDaysAgo timestamp arithmetic (was 48 minutes, not 2 days)
- Add test for last_activity_at IS NULL branch in findResumableRun
- Change warn → error + add errorType in findResumableRun catch block
- Add errorType to workflow.ts signal cleanup catch
- Add errorType to cli.ts failOrphanedRuns startup catch
- Add inline comment clarifying nowMinusDays(3) uses param index, not day count

Author: Wirasm

packages/cli/src/cli.ts

@@ -219,7 +219,8 @@ async function main(): Promise<number> {
     void createWorkflowStore()
       .failOrphanedRuns()
       .catch((err: unknown) => {
-        getLog().warn({ err }, 'cli.fail_orphans_failed');
+        const e = err as Error;
+        getLog().warn({ err: e, errorType: e.constructor.name }, 'cli.fail_orphans_failed');
       });
 
     // Validate working directory exists

packages/cli/src/commands/workflow.ts

@@ -532,7 +532,11 @@ export async function workflowRunCommand(
         return undefined;
       })
       .catch((err: unknown) => {
-        getLog().error({ err: err as Error }, 'workflow.termination_cleanup_failed');
+        const e = err as Error;
+        getLog().error(
+          { err: e, errorType: e.constructor.name },
+          'workflow.termination_cleanup_failed'
+        );
       })
       .finally(() => {
         process.exit(1);

packages/core/src/db/workflows.test.ts

@@ -492,16 +492,8 @@ describe('workflows database', () => {
       expect(params).toEqual(['feature-development', '/repo/path', 1]);
     });
 
-    test('returns null when no resumable run exists', async () => {
-      mockQuery.mockResolvedValueOnce(createQueryResult([]));
-
-      const result = await findResumableRun('feature-development', '/repo/path');
-
-      expect(result).toBeNull();
-    });
-
     test('returns a stale running run (no activity for >1 day)', async () => {
-      const twoDaysAgo = new Date(Date.now() - 2 * 24 * 60 * 1000).toISOString();
+      const twoDaysAgo = new Date(Date.now() - 2 * 24 * 60 * 60 * 1000).toISOString();
       const staleRun = {
         ...mockWorkflowRun,
         status: 'running' as const,
@@ -519,6 +511,22 @@ describe('workflows database', () => {
       expect(params).toEqual(['feature-development', '/repo/path', 1]);
     });
 
+    test('returns a running run with null last_activity_at (never recorded activity)', async () => {
+      const staleRun = {
+        ...mockWorkflowRun,
+        status: 'running' as const,
+        working_path: '/repo/path',
+        last_activity_at: null,
+      };
+      mockQuery.mockResolvedValueOnce(createQueryResult([staleRun]));
+
+      const result = await findResumableRun('feature-development', '/repo/path');
+
+      expect(result).toEqual(staleRun);
+      const [query] = mockQuery.mock.calls[0] as [string, unknown[]];
+      expect(query).toContain('last_activity_at IS NULL');
+    });
+
     test('returns null when no resumable run exists', async () => {
       mockQuery.mockResolvedValueOnce(createQueryResult([]));
 

packages/core/src/db/workflows.ts

@@ -234,7 +234,7 @@ export async function findResumableRun(
          AND working_path = $2
          AND (
            status IN ('failed', 'paused')
-           OR (status = 'running' AND (last_activity_at IS NULL OR last_activity_at < ${dialect.nowMinusDays(3)}))
+           OR (status = 'running' AND (last_activity_at IS NULL OR last_activity_at < ${dialect.nowMinusDays(3)})) -- nowMinusDays(3): param index 3, value bound as $3 = 1 day
          )
        ORDER BY started_at DESC
        LIMIT 1`,
@@ -244,7 +244,10 @@ export async function findResumableRun(
     return row ? normalizeWorkflowRun(row) : null;
   } catch (error) {
     const err = error as Error;
-    getLog().warn({ err, workflowName, workingPath }, 'db.workflow_run_find_resumable_failed');
+    getLog().error(
+      { err, errorType: err.constructor.name, workflowName, workingPath },
+      'db.workflow_run_find_resumable_failed'
+    );
     throw new Error(`Failed to find resumable run: ${err.message}`);
   }
 }