Skip to content

Commit 25433a3

Browse files
committed
Merge pull request #10 from JobBrander/implement-abstract-method
Looks good.
2 parents e22341b + c78f415 commit 25433a3

File tree

3 files changed

+11
-2
lines changed

3 files changed

+11
-2
lines changed

README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@ If you are working with a job listing service not supported out-of-the-box or by
7777
abstract public function createJobObject($payload);
7878
abstract public function getFormat();
7979
abstract public function getListingsPath();
80-
abstract public function getParameters();
8180
abstract public function getUrl();
8281
abstract public function getVerb();
8382
```

src/Providers/AbstractProvider.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,10 @@ abstract public function getListingsPath();
166166
*
167167
* @return array
168168
*/
169-
abstract public function getParameters();
169+
public function getParameters()
170+
{
171+
return [];
172+
}
170173

171174
/**
172175
* Get raw listings from payload

test/src/ProviderTest.php

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,13 @@ public function setUp()
1515
->shouldAllowMockingProtectedMethods();
1616
}
1717

18+
public function testGetParameters()
19+
{
20+
$parameters = $this->client->getParameters();
21+
22+
$this->assertEquals([], $parameters);
23+
}
24+
1825
public function testItPopulatesExistingAttributeswhenBuilt()
1926
{
2027
$attributes = [

0 commit comments

Comments
 (0)