Actually replace the SIMBAD URL with the https version

jobovy · jobovy · commit 97bbae3f00d4 · 2023-05-15T10:26:06.000-04:00
diff --git a/galpy/orbit/Orbits.py b/galpy/orbit/Orbits.py
@@ -7598,7 +7598,7 @@ def _from_name_oneobject(name, obs):
     # setup a SIMBAD query with the appropriate fields
     simbad = Simbad()
     # Make sure to make an HTTPS request so this code works in the browser
-    simbad.SIMBAD_URL.replace("http://", "https://")
+    simbad.SIMBAD_URL = simbad.SIMBAD_URL.replace("http://", "https://")
     simbad.add_votable_fields(
         "ra(d)", "dec(d)", "pmra", "pmdec", "rv_value", "plx", "distance"
     )

Original file line number	Diff line number	Diff line change
`@@ -7598,7 +7598,7 @@ def _from_name_oneobject(name, obs):`
`7598`	`7598`	`# setup a SIMBAD query with the appropriate fields`
`7599`	`7599`	`simbad = Simbad()`
`7600`	`7600`	`# Make sure to make an HTTPS request so this code works in the browser`
`7601`		`- simbad.SIMBAD_URL.replace("http://", "https://")`
	`7601`	`+ simbad.SIMBAD_URL = simbad.SIMBAD_URL.replace("http://", "https://")`
`7602`	`7602`	`simbad.add_votable_fields(`
`7603`	`7603`	`"ra(d)", "dec(d)", "pmra", "pmdec", "rv_value", "plx", "distance"`
`7604`	`7604`	`)`