Allow go-plus-update-tools command to be filtered

- Add callback to close gocode when gocode is updated

Author: joefitzgerald

Diff for: lib/get/get-manager.js

@@ -14,9 +14,13 @@ class GetManager {
     this.subscriptions.add(atom.commands.add(atom.views.getView(atom.workspace), 'golang:get-package', () => {
       this.getPackage()
     }))
-    this.subscriptions.add(atom.commands.add(atom.views.getView(atom.workspace), 'golang:update-tools', () => {
+    this.subscriptions.add(atom.commands.add(atom.views.getView(atom.workspace), 'golang:update-tools', (event) => {
       const progress = atom.notifications.addInfo('Updating Tools...', {dismissable: true})
-      this.updateTools().then((outcome) => {
+      let filter = false
+      if (event && event.detail && Array.isArray(event.detail)) {
+        filter = event.detail
+      }
+      this.updateTools(filter).then((outcome) => {
         progress.dismiss()
         if (!outcome) {
           return
@@ -72,14 +76,19 @@ class GetManager {
     })
   }
 
-  updateTools () {
+  updateTools (filter) {
     if (!this.packages || this.packages.size === 0) {
       return Promise.resolve()
     }
-    return this.performGet([...this.packages.keys()]).then((outcome) => {
+
+    let packs = [...this.packages.keys()]
+    if (filter && Array.isArray(filter) && filter.length > 0) {
+      packs = filter
+    }
+    return this.performGet(packs).then((outcome) => {
       if (this.onDidUpdateTools) {
         for (const cb of this.onDidUpdateTools) {
-          cb(outcome)
+          cb(outcome, packs)
         }
       }
       return outcome

Diff for: lib/package-manager.js

@@ -205,8 +205,12 @@ class PackageManager {
       return
     }
     for (const [key, value] of goTools) {
+      const packagePath = value
       if (key === 'gometalinter') {
-        this.subscriptions.add(this.goget.register(value, () => {
+        this.subscriptions.add(this.goget.register(packagePath, (outcome, packs) => {
+          if (!packs.includes(packagePath)) {
+            return
+          }
           this.goconfig.locator.findTool('gometalinter').then((cmd) => {
             if (!cmd) {
               return
@@ -241,8 +245,47 @@ class PackageManager {
             })
           })
         }))
+      } else if (key === 'gocode') {
+        this.subscriptions.add(this.goget.register(packagePath, (outcome, packs) => {
+          if (!packs.includes(packagePath)) {
+            return
+          }
+          this.goconfig.locator.findTool('gocode').then((cmd) => {
+            if (!cmd) {
+              return
+            }
+            const notification = atom.notifications.addInfo('gocode', {
+              dismissable: true,
+              icon: 'cloud-download',
+              description: 'Running `gocode close` to ensure a new gocode binary is used.'
+            })
+            return this.goconfig.executor.exec(cmd, ['close'], 'project').then((r) => {
+              notification.dismiss()
+              const detail = r.stdout + os.EOL + r.stderr
+
+              if (r.exitcode !== 0) {
+                atom.notifications.addWarning('gocode', {
+                  dismissable: true,
+                  icon: 'sync',
+                  detail: detail.trim()
+                })
+                return r
+              }
+              if (r.stderr && r.stderr.trim() !== '') {
+                console.log('go-plus: (stderr) ' + r.stderr)
+              }
+              atom.notifications.addSuccess('gocode', {
+                dismissable: true,
+                icon: 'sync',
+                detail: detail.trim(),
+                description: 'The `gocode` daemon has been closed to ensure you are using the latest `gocode` binary.'
+              })
+              return r
+            })
+          })
+        }))
       } else {
-        this.subscriptions.add(this.goget.register(value))
+        this.subscriptions.add(this.goget.register(packagePath))
       }
     }
   }