-
Notifications
You must be signed in to change notification settings - Fork 359
Description
When images are chosen from Unsplash using the "Search" type, Tabliss displays an input to filter images by Tags
I thought this meant that I could write a space/comma-separated list of tags to filter by, but it looks like it just uses one general query string:
tabliss/src/plugins/backgrounds/unsplash/api.ts
Lines 35 to 39 in 765a3f0
| case "search": | |
| params.set("orientation", "landscape"); | |
| if (featured) params.set("featured", "true"); | |
| if (search) params.set("query", search); | |
| break; |
Unsplash's own API docs confirm this. I don't really see a point in making more work to allow for multiple tags since the random image endpoint doesn't seem to support it. Instead I just think the text "Tags" should be changed to something like "Search Term" to better represent what it actually does for the filtering. Here's where the change needs to be made (line 87):
tabliss/src/plugins/backgrounds/unsplash/UnsplashSettings.tsx
Lines 84 to 89 in 765a3f0
| {data.by === "search" && ( | |
| <> | |
| <label> | |
| Tags | |
| <DebounceInput | |
| type="text" |