Change name for anonymous namespaces from <namespace> to anonymous

Author: max-leuthaeuser

joern-cli/frontends/c2cpg/src/main/scala/io/joern/c2cpg/astcreation/AstCreatorHelper.scala

@@ -68,8 +68,8 @@ trait AstCreatorHelper { this: AstCreator =>
 
   protected def scopeLocalUniqueNamespaceFullName(fullName: String): String = {
     val newFullName = fullName match {
-      case ""     => "<namespace>"
-      case s"$p." => s"$p.<namespace>"
+      case ""     => "<anonymous>"
+      case s"$p." => s"$p.<anonymous>"
       case other  => other
     }
     scopeLocalUniqueNames.get(newFullName) match {

joern-cli/frontends/c2cpg/src/main/scala/io/joern/c2cpg/astcreation/FullNameProvider.scala

@@ -26,7 +26,6 @@ object FullNameProvider {
     "<global>",
     "<iterator>",
     "<lambda>",
-    "<namespace>",
     "<param>",
     "<tmp>",
     "<type>"

joern-cli/frontends/c2cpg/src/main/scala/io/joern/c2cpg/astcreation/TypeNameProvider.scala

@@ -180,7 +180,7 @@ trait TypeNameProvider { this: AstCreator =>
         TypeFullNameInfo(uniqueName, uniqueNameFullName)
       case n: ICPPASTNamespaceDefinition =>
         val name = shortName(n) match {
-          case ""    => "<namespace>"
+          case ""    => "<anonymous>"
           case other => other
         }
         val fullName_ = fullName(n)

joern-cli/frontends/c2cpg/src/test/scala/io/joern/c2cpg/cpp/features17/Cpp17FeaturesTests.scala

@@ -386,8 +386,8 @@ class Cpp17FeaturesTests extends AstC2CpgSuite(fileSuffix = FileDefaults.CppExt)
       cpg.namespaceBlock.nameNot("<global>").name.sorted shouldBe Seq(
         // Within a translation unit each unnamed namespace definition maps to the same unique name:
         // multiple unnamed namespace definitions in the same scope denote the same unnamed namespace
-        "<namespace>",
-        "<namespace>",
+        "<anonymous>",
+        "<anonymous>",
         "A",
         "A",
         "B",
@@ -398,8 +398,8 @@ class Cpp17FeaturesTests extends AstC2CpgSuite(fileSuffix = FileDefaults.CppExt)
         "X"
       )
       cpg.namespaceBlock.nameNot("<global>").fullName.sorted shouldBe Seq(
-        "Test0.cpp:<namespace>",
-        "Test0.cpp:<namespace><extension>0",
+        "Test0.cpp:<anonymous>",
+        "Test0.cpp:<anonymous><extension>0",
         "Test0.cpp:A",
         "Test0.cpp:A.B",
         "Test0.cpp:A.B.C",

joern-cli/frontends/c2cpg/src/test/scala/io/joern/c2cpg/passes/types/NamespaceTypeTests.scala

@@ -127,14 +127,14 @@ class NamespaceTypeTests extends C2CpgSuite(fileSuffix = FileDefaults.CppExt) {
         |  j++;    // ok, increments ::A::(unique)::j
         |}""".stripMargin)
       inside(cpg.namespaceBlock.nameNot("<global>").sortBy(_.fullName).l) { case List(unnamed1, namespaceA, unnamed2) =>
-        unnamed1.name shouldBe "<namespace>"
-        unnamed1.fullName shouldBe "Test0.cpp:<namespace>"
+        unnamed1.name shouldBe "<anonymous>"
+        unnamed1.fullName shouldBe "Test0.cpp:<anonymous>"
         unnamed1.filename shouldBe "Test0.cpp"
         namespaceA.name shouldBe "A"
         namespaceA.fullName shouldBe "Test0.cpp:A"
         namespaceA.filename shouldBe "Test0.cpp"
-        unnamed2.name shouldBe "<namespace>"
-        unnamed2.fullName shouldBe "Test0.cpp:A.<namespace>"
+        unnamed2.name shouldBe "<anonymous>"
+        unnamed2.fullName shouldBe "Test0.cpp:A.<anonymous>"
         unnamed2.filename shouldBe "Test0.cpp"
       }