Upgrade Flowpath enum from scala 2 to scala 3 (#5745)

* Upgrade Flowpath enum from scala 2 to scala 3

* Update to use curly-brace style for enum

* Scalafmt

Author: SuperUserDone

dataflowengineoss/src/main/scala/io/joern/dataflowengineoss/DefaultSemantics.scala

@@ -1,6 +1,7 @@
 package io.joern.dataflowengineoss
 
-import io.joern.dataflowengineoss.semanticsloader.{FlowSemantic, PassThroughMapping, FullNameSemantics}
+import io.joern.dataflowengineoss.semanticsloader.{FlowSemantic, FullNameSemantics}
+import io.joern.dataflowengineoss.semanticsloader.FlowPath.{FlowMapping, PassThroughMapping}
 import io.shiftleft.codepropertygraph.generated.Operators
 
 import scala.annotation.unused

dataflowengineoss/src/main/scala/io/joern/dataflowengineoss/language/nodemethods/ExpressionMethods.scala

@@ -1,6 +1,7 @@
 package io.joern.dataflowengineoss.language.nodemethods
 
 import io.joern.dataflowengineoss.semanticsloader.*
+import io.joern.dataflowengineoss.semanticsloader.FlowPath.{FlowMapping, PassThroughMapping}
 import io.shiftleft.codepropertygraph.generated.nodes.{Call, Expression, Method}
 import io.shiftleft.semanticcpg.language.*
 

dataflowengineoss/src/main/scala/io/joern/dataflowengineoss/passes/reachingdef/EdgeValidator.scala

@@ -2,14 +2,8 @@ package io.joern.dataflowengineoss.passes.reachingdef
 
 import io.joern.dataflowengineoss.language.*
 import io.joern.dataflowengineoss.queryengine.Engine.{isOutputArgOfInternalMethod, semanticsForCall}
-import io.joern.dataflowengineoss.semanticsloader.{
-  FlowMapping,
-  FlowPath,
-  FlowSemantic,
-  ParameterNode,
-  PassThroughMapping,
-  Semantics
-}
+import io.joern.dataflowengineoss.semanticsloader.{FlowPath, FlowSemantic, ParameterNode, Semantics}
+import io.joern.dataflowengineoss.semanticsloader.FlowPath.{FlowMapping, PassThroughMapping}
 import io.shiftleft.codepropertygraph.generated.nodes.{Call, CfgNode, Expression, StoredNode}
 import io.shiftleft.semanticcpg.language.*
 

dataflowengineoss/src/main/scala/io/joern/dataflowengineoss/semanticsloader/FullNameSemantics.scala

@@ -1,5 +1,6 @@
 package io.joern.dataflowengineoss.semanticsloader
 
+import io.joern.dataflowengineoss.semanticsloader.FlowPath.{FlowMapping, PassThroughMapping}
 import io.shiftleft.codepropertygraph.generated.Cpg
 import io.shiftleft.codepropertygraph.generated.nodes.Method
 import io.shiftleft.semanticcpg.language.*

dataflowengineoss/src/main/scala/io/joern/dataflowengineoss/semanticsloader/FullNameSemanticsParser.scala

@@ -2,6 +2,7 @@ package io.joern.dataflowengineoss.semanticsloader
 
 import io.joern.dataflowengineoss.SemanticsParser.MappingContext
 import io.joern.dataflowengineoss.{SemanticsBaseListener, SemanticsLexer, SemanticsParser}
+import io.joern.dataflowengineoss.semanticsloader.FlowPath.{FlowMapping, PassThroughMapping}
 import org.antlr.v4.runtime.tree.ParseTreeWalker
 import org.antlr.v4.runtime.{CharStream, CharStreams, CommonTokenStream}
 

dataflowengineoss/src/main/scala/io/joern/dataflowengineoss/semanticsloader/Semantics.scala

@@ -1,5 +1,6 @@
 package io.joern.dataflowengineoss.semanticsloader
 
+import io.joern.dataflowengineoss.semanticsloader.FlowPath.{FlowMapping, PassThroughMapping}
 import io.shiftleft.codepropertygraph.generated.Cpg
 import io.shiftleft.codepropertygraph.generated.nodes.Method
 import io.shiftleft.semanticcpg.language.*
@@ -135,33 +136,38 @@ object ParameterNode {
 
 /** Represents explicit mappings or special cases.
   */
-sealed trait FlowPath
 
-/** Maps flow between arguments based on how they interact as parameters at the callee.
-  *
-  * @param src
-  *   source of the flow.
-  * @param dst
-  *   destination of the flow.
+/** Represents explicit mappings or special cases as a Scala 3 enum.
   */
-case class FlowMapping(src: FlowNode, dst: FlowNode) extends FlowPath
+enum FlowPath {
+
+  /** Maps flow between arguments based on how they interact as parameters at the callee.
+    *
+    * @param src
+    *   source of the flow.
+    * @param dst
+    *   destination of the flow.
+    */
+  case FlowMapping(src: FlowNode, dst: FlowNode)
 
-object FlowMapping {
-  def apply(from: Int, to: Int): FlowMapping = FlowMapping(ParameterNode(from), ParameterNode(to))
+  /** Represents an instance where parameters are not sanitized, may affect the return value, and do not cross-taint.
+    * e.g. foo(1, 2) = 1 -> 1, 2 -> 2, 1 -> -1, 2 -> -1
+    *
+    * The main benefit is that this works for unbounded parameters e.g. VARARGS. Note this does not taint 0 -> 0.
+    */
+  case PassThroughMapping
+}
 
-  def apply(fromIdx: Int, from: String, toIdx: Int, to: String): FlowMapping =
+object FlowPath {
+
+  def FlowMapping(from: Int, to: Int): FlowPath = FlowMapping(ParameterNode(from), ParameterNode(to))
+
+  def FlowMapping(fromIdx: Int, from: String, toIdx: Int, to: String): FlowPath =
     FlowMapping(ParameterNode(fromIdx, from), ParameterNode(toIdx, to))
 
-  def apply(fromIdx: Int, from: String, toIdx: Int): FlowMapping =
+  def FlowMapping(fromIdx: Int, from: String, toIdx: Int): FlowPath =
     FlowMapping(ParameterNode(fromIdx, from), ParameterNode(toIdx))
 
-  def apply(from: Int, toIdx: Int, to: String): FlowMapping = FlowMapping(ParameterNode(from), ParameterNode(toIdx, to))
-
+  def FlowMapping(from: Int, toIdx: Int, to: String): FlowPath =
+    FlowMapping(ParameterNode(from), ParameterNode(toIdx, to))
 }
-
-/** Represents an instance where parameters are not sanitized, may affect the return value, and do not cross-taint. e.g.
-  * foo(1, 2) = 1 -> 1, 2 -> 2, 1 -> -1, 2 -> -1
-  *
-  * The main benefit is that this works for unbounded parameters e.g. VARARGS. Note this does not taint 0 -> 0.
-  */
-object PassThroughMapping extends FlowPath

dataflowengineoss/src/test/scala/io/joern/dataflowengineoss/semanticsloader/FullNameSemanticsParserTests.scala

@@ -1,5 +1,6 @@
 package io.joern.dataflowengineoss.semanticsloader
 
+import io.joern.dataflowengineoss.semanticsloader.FlowPath.{FlowMapping, PassThroughMapping}
 import org.scalatest.matchers.should.Matchers
 import org.scalatest.wordspec.AnyWordSpec
 

joern-cli/frontends/pysrc2cpg/src/test/scala/io/joern/pysrc2cpg/dataflow/DataFlowTests.scala

@@ -2,14 +2,8 @@ package io.joern.pysrc2cpg.dataflow
 
 import io.joern.dataflowengineoss.DefaultSemantics
 import io.joern.dataflowengineoss.language.toExtendedCfgNode
-import io.joern.dataflowengineoss.semanticsloader.{
-  FlowMapping,
-  FlowSemantic,
-  NilSemantics,
-  NoCrossTaintSemantics,
-  NoSemantics,
-  PassThroughMapping
-}
+import io.joern.dataflowengineoss.semanticsloader.{FlowSemantic, NilSemantics, NoCrossTaintSemantics, NoSemantics}
+import io.joern.dataflowengineoss.semanticsloader.FlowPath.{FlowMapping, PassThroughMapping}
 import io.joern.pysrc2cpg.testfixtures.PySrc2CpgFixture
 import io.shiftleft.codepropertygraph.generated.{Cpg, Operators}
 import io.shiftleft.codepropertygraph.generated.nodes.{Literal, Member, Method}