Upgraded scala 2 enums in php2cpg to scala 3 (#5749)

* Upgraded scala 2 enums in php2cpg to scala 3

* Change to use curly brace scala syntax

* Change to use curly brace style for enum

Author: SuperUserDone

joern-cli/frontends/php2cpg/src/main/scala/io/joern/php2cpg/parser/Domain.scala

@@ -10,7 +10,7 @@ import io.joern.php2cpg.parser.Domain.PhpCast.CastTypeMap
 import io.joern.php2cpg.parser.Domain.PhpCast.isCastType
 import io.joern.php2cpg.parser.Domain.PhpUnaryOp.UnaryOpTypeMap
 import io.joern.php2cpg.parser.Domain.PhpUnaryOp.isUnaryOpType
-import io.joern.php2cpg.parser.Domain.PhpUseType.PhpUseType
+import io.joern.php2cpg.parser.Domain.PhpUseType
 import io.joern.php2cpg.parser.Domain.PhpUseType.getUseType
 import io.shiftleft.codepropertygraph.generated.ModifierTypes
 import io.shiftleft.codepropertygraph.generated.Operators
@@ -326,21 +326,18 @@ object Domain {
     attributes: PhpAttributes
   ) extends PhpStmt
 
-  case object PhpUseType {
-    sealed trait PhpUseType
-    case object Unknown  extends PhpUseType
-    case object Normal   extends PhpUseType
-    case object Function extends PhpUseType
-    case object Constant extends PhpUseType
+  enum PhpUseType {
+    case Unknown, Normal, Function, Constant
+  }
 
-    def getUseType(typeNum: Int): PhpUseType = {
+  object PhpUseType {
+    def getUseType(typeNum: Int): PhpUseType =
       typeNum match {
         case 1 => Normal
         case 2 => Function
         case 3 => Constant
         case _ => Unknown
       }
-    }
   }
 
   final case class PhpForeachStmt(

joern-cli/frontends/php2cpg/src/main/scala/io/joern/php2cpg/passes/DependencyPass.scala

@@ -11,6 +11,8 @@ import java.nio.file.{Files, Path, Paths}
 import scala.annotation.targetName
 import scala.util.{Failure, Success, Try, Using}
 
+import PsrStringOrArray.*
+
 /** Parses the `composer.json` file for all `require` dependencies.
   */
 class DependencyPass(cpg: Cpg, composerPaths: List[String]) extends ForkJoinParallelCpgPass[Path](cpg) {
@@ -45,24 +47,21 @@ class DependencyPass(cpg: Cpg, composerPaths: List[String]) extends ForkJoinPara
 
 }
 
-sealed trait PsrStringOrArray {
-  def obj: String | Array[String]
+enum PsrStringOrArray {
+  case PsrString(obj: String)
+  case PsrArray(obj: Array[String])
 }
 
-case class PsrString(obj: String) extends PsrStringOrArray
-
-case class PsrArray(obj: Array[String]) extends PsrStringOrArray
-
-object PsrStringOrArray:
+object PsrStringOrArray {
   given ReadWriter[PsrStringOrArray] = {
     val logger = LoggerFactory.getLogger(getClass)
 
     readwriter[ujson.Value]
       .bimap[PsrStringOrArray](
         x =>
-          x.obj match {
-            case o: String        => ujson.Str(o)
-            case o: Array[String] => ujson.Arr(o.map(ujson.Str.apply)*)
+          x match {
+            case PsrString(o) => ujson.Str(o)
+            case PsrArray(o)  => ujson.Arr(o.map(ujson.Str.apply)*)
           },
         {
           case json @ (j: ujson.Str) => PsrString(json.str)
@@ -73,6 +72,7 @@ object PsrStringOrArray:
         }
       )
   }
+}
 
 case class Autoload(
   @targetName("psr0") `psr-0`: Map[String, PsrStringOrArray] = Map.empty,

joern-cli/frontends/php2cpg/src/main/scala/io/joern/php2cpg/utils/DependencyDownloader.scala

@@ -3,7 +3,8 @@ package io.joern.php2cpg.utils
 import com.github.sh4869.semver_parser.{Range, SemVer}
 import io.joern.php2cpg.Config
 import io.joern.php2cpg.parser.Domain.PhpOperators
-import io.joern.php2cpg.passes.{Composer, PsrArray, PsrString}
+import io.joern.php2cpg.passes.Composer
+import io.joern.php2cpg.passes.PsrStringOrArray.{PsrArray, PsrString}
 import io.shiftleft.semanticcpg.utils.FileUtil.*
 import io.shiftleft.codepropertygraph.generated.Cpg
 import io.shiftleft.codepropertygraph.generated.nodes.Dependency