use loneElement instead of onlyChecked (#5585)

* use `loneElement` instead of `onlyChecked`

* use loneElement with hint msg

* cpg version

* update hint

* fmt

* latest cpg

* trigger ci

Author: mpollmeier

build.sbt

@@ -2,7 +2,7 @@ name                     := "joern"
 ThisBuild / organization := "io.joern"
 ThisBuild / scalaVersion := "3.6.4"
 
-val cpgVersion = "1.7.41"
+val cpgVersion = "1.7.43"
 
 lazy val joerncli          = Projects.joerncli
 lazy val querydb           = Projects.querydb

semanticcpg/src/main/scala/io/shiftleft/semanticcpg/language/nodemethods/AstNodeMethods.scala

@@ -1,6 +1,5 @@
 package io.shiftleft.semanticcpg.language.nodemethods
 
-import io.shiftleft.Implicits.IterableOnceDeco
 import io.shiftleft.codepropertygraph.generated.nodes.*
 import io.shiftleft.codepropertygraph.generated.PropertyDefaults
 import io.shiftleft.semanticcpg.NodeExtension
@@ -66,7 +65,14 @@ class AstNodeMethods(val node: AstNode) extends AnyVal with NodeExtension {
   }
 
   def astParent: AstNode =
-    node._astIn.onlyChecked.asInstanceOf[AstNode]
+    node._astIn
+      .loneElement(
+        "trying to resolve astParent - either this is a root node, or it has two parents (which is probably a malformed cpg)"
+      )
+      .asInstanceOf[AstNode]
+
+  def astParentOption: Option[AstNode] =
+    node._astIn.loneElementOption.asInstanceOf[Option[AstNode]]
 
   /** Direct children of node in the AST. Siblings are ordered by their `order` fields
     */

semanticcpg/src/main/scala/io/shiftleft/semanticcpg/language/nodemethods/CfgNodeMethods.scala

@@ -1,6 +1,5 @@
 package io.shiftleft.semanticcpg.language.nodemethods
 
-import io.shiftleft.Implicits.IterableOnceDeco
 import io.shiftleft.codepropertygraph.generated.nodes.*
 import io.shiftleft.semanticcpg.NodeExtension
 import io.shiftleft.semanticcpg.language.*
@@ -120,10 +119,10 @@ class CfgNodeMethods(val node: CfgNode) extends AnyVal with NodeExtension {
   }
 
   private def walkUpAst(node: CfgNode): Method =
-    node._astIn.onlyChecked.asInstanceOf[Method]
+    node.astParent.asInstanceOf[Method]
 
   private def walkUpContains(node: StoredNode): Method =
-    node._containsIn.onlyChecked match {
+    node._containsIn.loneElement("trying to walk `containsIn` edge") match {
       case method: Method => method
       case typeDecl: TypeDecl =>
         typeDecl.astParent match {

semanticcpg/src/main/scala/io/shiftleft/semanticcpg/language/nodemethods/ExpressionMethods.scala

@@ -1,6 +1,5 @@
 package io.shiftleft.semanticcpg.language.nodemethods
 
-import io.shiftleft.Implicits.IterableOnceDeco
 import io.shiftleft.codepropertygraph.generated.nodes.*
 import io.shiftleft.semanticcpg.NodeExtension
 import io.shiftleft.semanticcpg.language.ICallResolver
@@ -22,8 +21,7 @@ class ExpressionMethods(val node: Expression) extends AnyVal with NodeExtension
 
   @tailrec
   private final def _parentExpression(argument: AstNode): Option[Expression] = {
-    val parent = argument._astIn.onlyChecked
-    parent match {
+    argument.astParent match {
       case call: Call if MemberAccess.isGenericMemberAccessName(call.name) =>
         _parentExpression(call)
       case expression: Expression =>