Convert c2cpg test fixtures to use inmemory cpg creation

Author: SuperUserDone

joern-cli/frontends/c2cpg/src/test/scala/io/joern/c2cpg/io/ExcludeTests.scala

@@ -48,20 +48,17 @@ class ExcludeTests extends AnyWordSpec with Matchers with TableDrivenPropertyChe
   override def afterAll(): Unit = FileUtil.delete(projectUnderTest, swallowIoExceptions = true)
 
   private def testWithArguments(exclude: Seq[String], excludeRegex: String, expectedFiles: Set[String]): Unit = {
-    FileUtil.usingTemporaryFile(suffix = "-c2cpg.bin") { tmpCpg =>
-      val config = Config()
-        .withInputPath(projectUnderTest.toString)
-        .withOutputPath(tmpCpg.toString)
-        .withIgnoredFiles(exclude)
-        .withIgnoredFilesRegex(excludeRegex)
-      val c2cpg = new C2Cpg()
-      val cpg   = c2cpg.createCpg(config).get
+    val config = Config()
+      .withInputPath(projectUnderTest.toString)
+      .withIgnoredFiles(exclude)
+      .withIgnoredFilesRegex(excludeRegex)
+    val c2cpg = new C2Cpg()
+    val cpg   = c2cpg.createCpg(config).get
 
-      X2Cpg.applyDefaultOverlays(cpg)
-      cpg.file.nameNot(FileTraversal.UNKNOWN, "<includes>").name.l should contain theSameElementsAs expectedFiles.map(
-        _.replace("/", java.io.File.separator)
-      )
-    }
+    X2Cpg.applyDefaultOverlays(cpg)
+    cpg.file.nameNot(FileTraversal.UNKNOWN, "<includes>").name.l should contain theSameElementsAs expectedFiles.map(
+      _.replace("/", java.io.File.separator)
+    )
   }
 
   "Using case sensitive excludes" should {

joern-cli/frontends/c2cpg/src/test/scala/io/joern/c2cpg/testfixtures/AstC2CpgFrontend.scala

@@ -18,34 +18,32 @@ trait AstC2CpgFrontend extends LanguageFrontend {
   override type ConfigType = Config
 
   def execute(sourceCodePath: java.io.File): Cpg = {
-    FileUtil.usingTemporaryFile(suffix = "cpg.bin") { tmpCpg =>
-      val cpg          = newEmptyCpg(Option(tmpCpg.toString))
-      val pathAsString = sourceCodePath.getAbsolutePath
-      val config = getConfig()
-        .fold(Config())(_.asInstanceOf[Config])
-        .withInputPath(pathAsString)
-        .withOutputPath(pathAsString)
-        .withSchemaValidation(ValidationMode.Enabled)
-      val global = new CGlobal()
+    val cpg          = newEmptyCpg()
+    val pathAsString = sourceCodePath.getAbsolutePath
+    val config = getConfig()
+      .fold(Config())(_.asInstanceOf[Config])
+      .withInputPath(pathAsString)
+      .withOutputPath(pathAsString)
+      .withSchemaValidation(ValidationMode.Enabled)
+    val global = new CGlobal()
 
-      val preprocessedFiles = if (config.withPreprocessedFiles) {
-        SourceFiles
-          .determine(
-            config.inputPath,
-            Set(FileDefaults.PreprocessedExt),
-            ignoredDefaultRegex = Option(DefaultIgnoredFolders),
-            ignoredFilesRegex = Option(config.ignoredFilesRegex),
-            ignoredFilesPath = Option(config.ignoredFiles)
-          )
-      } else List.empty
+    val preprocessedFiles = if (config.withPreprocessedFiles) {
+      SourceFiles
+        .determine(
+          config.inputPath,
+          Set(FileDefaults.PreprocessedExt),
+          ignoredDefaultRegex = Option(DefaultIgnoredFolders),
+          ignoredFilesRegex = Option(config.ignoredFilesRegex),
+          ignoredFilesPath = Option(config.ignoredFiles)
+        )
+    } else List.empty
 
-      val sourceFileExtensions = FileDefaults.SourceFileExtensions ++
-        Option.when(config.withPreprocessedFiles)(FileDefaults.PreprocessedExt).toList
-      new AstCreationPass(cpg, preprocessedFiles, sourceFileExtensions, config, global).createAndApply()
-      new AstCreationPass(cpg, preprocessedFiles, FileDefaults.HeaderFileExtensions, config, global).createAndApply()
-      new FunctionDeclNodePass(cpg, global.unhandledMethodDeclarations(), config).createAndApply()
-      new PostFrontendValidator(cpg, false).run()
-      cpg
-    }
+    val sourceFileExtensions = FileDefaults.SourceFileExtensions ++
+      Option.when(config.withPreprocessedFiles)(FileDefaults.PreprocessedExt).toList
+    new AstCreationPass(cpg, preprocessedFiles, sourceFileExtensions, config, global).createAndApply()
+    new AstCreationPass(cpg, preprocessedFiles, FileDefaults.HeaderFileExtensions, config, global).createAndApply()
+    new FunctionDeclNodePass(cpg, global.unhandledMethodDeclarations(), config).createAndApply()
+    new PostFrontendValidator(cpg, false).run()
+    cpg
   }
 }

joern-cli/frontends/c2cpg/src/test/scala/io/joern/c2cpg/testfixtures/C2CpgFrontend.scala

@@ -11,15 +11,12 @@ trait C2CpgFrontend extends LanguageFrontend {
   override type ConfigType = Config
 
   def execute(sourceCodePath: java.io.File): Cpg = {
-    FileUtil.usingTemporaryFile(suffix = "cpg.bin") { tmpCpg =>
-      val c2cpg = new C2Cpg()
-      val config = getConfig()
-        .fold(Config())(_.asInstanceOf[Config])
-        .withInputPath(sourceCodePath.getAbsolutePath)
-        .withOutputPath(tmpCpg.toString)
-      val res = c2cpg.createCpg(config).get
-      new PostFrontendValidator(res, false).run()
-      res
-    }
+    val c2cpg = new C2Cpg()
+    val config = getConfig()
+      .fold(Config())(_.asInstanceOf[Config])
+      .withInputPath(sourceCodePath.getAbsolutePath)
+    val res = c2cpg.createCpg(config).get
+    new PostFrontendValidator(res, false).run()
+    res
   }
 }