Skip to content

Commit 42d0d89

Browse files
committed
Merge branch 'master' into 'master'
Allow for better localization See merge request AuroraOSS/AuroraStore!190
2 parents 451f396 + e6dc9fe commit 42d0d89

6 files changed

Lines changed: 33 additions & 18 deletions

File tree

app/src/main/java/com/aurora/store/view/ui/account/AccountActivity.kt

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -79,12 +79,12 @@ class AccountActivity : BaseActivity() {
7979
}
8080

8181
AuthState.Available -> {
82-
updateStatus("Verifying session")
82+
updateStatus(getString(R.string.session_verifying))
8383
updateActionLayout(false)
8484
}
8585

8686
AuthState.Unavailable -> {
87-
updateStatus("You need to login first")
87+
updateStatus(getString(R.string.session_login))
8888
updateActionLayout(true)
8989
}
9090

@@ -93,7 +93,7 @@ class AccountActivity : BaseActivity() {
9393
}
9494

9595
AuthState.SignedOut -> {
96-
updateStatus("Last session scrapped")
96+
updateStatus(getString(R.string.session_scrapped))
9797
updateActionLayout(true)
9898
}
9999

@@ -114,10 +114,10 @@ class AccountActivity : BaseActivity() {
114114
when (event) {
115115
is BusEvent.GoogleAAS -> {
116116
if (event.success) {
117-
updateStatus("Verifying Google Session")
117+
updateStatus(getString(R.string.session_verifying_google))
118118
VM.buildGoogleAuthData(event.email, event.aasToken)
119119
} else {
120-
updateStatus("Failed to login via Google")
120+
updateStatus(getString(R.string.session_login_failed_google))
121121
}
122122
}
123123
else -> {
@@ -129,10 +129,10 @@ class AccountActivity : BaseActivity() {
129129
private fun updateContents() {
130130
if (accountProvider.isSignedIn()) {
131131
B.viewFlipper.displayedChild = 1
132-
updateStatus("Woah! all good.")
132+
updateStatus(getString(R.string.session_good))
133133
} else {
134134
B.viewFlipper.displayedChild = 0
135-
updateStatus("Login and enjoy.")
135+
updateStatus(getString(R.string.session_enjoy))
136136
}
137137

138138
updateUserProfile()

app/src/main/java/com/aurora/store/view/ui/splash/SplashActivity.kt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ class SplashActivity : BaseActivity() {
7777
attachActions()
7878

7979
//Initial status
80-
updateStatus("Getting things ready..")
80+
updateStatus(getString(R.string.session_init))
8181

8282
VM.liveData.observe(this, {
8383
when (it) {
@@ -86,12 +86,12 @@ class SplashActivity : BaseActivity() {
8686
}
8787

8888
AuthState.Available -> {
89-
updateStatus("Verifying session")
89+
updateStatus(getString(R.string.session_verifying))
9090
updateActionLayout(false)
9191
}
9292

9393
AuthState.Unavailable -> {
94-
updateStatus("You need to login first")
94+
updateStatus(getString(R.string.session_login))
9595
updateActionLayout(true)
9696
}
9797

@@ -100,7 +100,7 @@ class SplashActivity : BaseActivity() {
100100
}
101101

102102
AuthState.SignedOut -> {
103-
updateStatus("Last session scrapped")
103+
updateStatus(getString(R.string.session_scrapped))
104104
updateActionLayout(true)
105105
}
106106

@@ -164,10 +164,10 @@ class SplashActivity : BaseActivity() {
164164
when (event) {
165165
is BusEvent.GoogleAAS -> {
166166
if (event.success) {
167-
updateStatus("Verifying Google Session")
167+
updateStatus(getString(R.string.session_verifying_google))
168168
VM.buildGoogleAuthData(event.email, event.aasToken)
169169
} else {
170-
updateStatus("Failed to login via Google")
170+
updateStatus(getString(R.string.session_login_failed_google))
171171
}
172172
}
173173
else -> {

app/src/main/java/com/aurora/store/view/ui/updates/UpdatesFragment.kt

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,12 @@ class UpdatesFragment : BaseFragment() {
196196
add(
197197
UpdateHeaderViewModel_()
198198
.id("header_all")
199-
.title("${updateFileMap.size} updates available")
199+
.title("${updateFileMap.size} " +
200+
if (updateFileMap.size == 1)
201+
getString(R.string.update_available)
202+
else
203+
getString(R.string.updates_available)
204+
)
200205
.action(
201206
if (VM.updateAllEnqueued)
202207
getString(R.string.action_cancel)

app/src/main/res/layout/view_app_update.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@
123123

124124
<LinearLayout
125125
android:id="@+id/layout_action"
126-
android:layout_width="100dp"
126+
android:layout_width="115dp"
127127
android:layout_height="@dimen/height_button"
128128
android:layout_alignParentEnd="true"
129129
android:layout_centerVertical="true"

app/src/main/res/values/strings.xml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,9 @@
177177
<string name="download_completed">"Downloaded"</string>
178178
<string name="download_deleted">"Deleted"</string>
179179
<string name="download_eta_calculating">"Calculating"</string>
180+
<string name="download_eta_hrs">%1$dh %2$dm %3$ds left</string>
181+
<string name="download_eta_min">%1$dm %2$ds left</string>
182+
<string name="download_eta_sec">%1$ds left</string>
180183
<string name="download_failed">"Download failed"</string>
181184
<string name="download_force_clear_all">"Force clear all"</string>
182185
<string name="download_metadata">"Getting metadata"</string>
@@ -318,6 +321,14 @@
318321
<string name="purchase_not_found">"App not found"</string>
319322
<string name="purchase_no_file">"Could not get files"</string>
320323
<string name="purchase_session_expired">"Session expired, re-login to obtain new session."</string>
324+
<string name="session_enjoy">Login and enjoy.</string>
325+
<string name="session_good">Woah! All good.</string>
326+
<string name="session_init">Getting things ready…</string>
327+
<string name="session_login">You need to login first</string>
328+
<string name="session_login_failed_google">Failed to login via Google</string>
329+
<string name="session_scrapped">Last session scrapped</string>
330+
<string name="session_verifying">Verifying session</string>
331+
<string name="session_verifying_google">Verifying Google Session</string>
321332
<string name="spoof_apply">"Make sure you re-login to apply the spoof"</string>
322333
<string name="insecure_anonymous_apply">"Make sure you re-login and restart app to apply changes."</string>
323334
<string name="tab_categories">"Categories"</string>
@@ -387,4 +398,6 @@
387398
<string name="ui_accent_11">Light blue</string>
388399
<string name="ui_accent_12">Disskord blue</string>
389400
<string name="ui_accent_13">Deep blue</string>
401+
<string name="update_available">update available</string>
402+
<string name="updates_available">updates available</string>
390403
</resources>

app/src/main/res/values/strings_do_not_translate.xml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,6 @@
2121
<string name="app_name">"Aurora Store"</string>
2222

2323
<string name="app_list_rating">"%s • %s★ • %s"</string>
24-
<string name="download_eta_hrs" translatable="false">%1$dh %2$dm %3$ds left</string>
25-
<string name="download_eta_min" translatable="false">%1$dm %2$ds left</string>
26-
<string name="download_eta_sec" translatable="false">%1$ds left</string>
2724
<string name="download_speed_bytes" translatable="false">%1$d B/s</string>
2825
<string name="download_speed_kb" translatable="false">%1$s KB/s</string>
2926
<string name="download_speed_mb" translatable="false">%1$s MB/s</string>

0 commit comments

Comments
 (0)