Pass 2 of the pre-release audit verifies each reporter fix by reverting it and confirming a guard goes red. #398, #404 and #421 all passed that check unchanged. #399 did not. What guarded it was TestReadAndInitializeVpp::test_seeds_state_from_ hardware, which asserts _vpp_status_confirmed is seeded True from the hardware read-back. That is the mechanism. It stays green if the flag is seeded correctly and then ignored, and it says nothing about writes. What ridax67 reported on #399 is a write count across restarts: "at startup allow ac grid charging and vpp_status are always set... if you test if they need to be set first, you will avoid a lot of flash writes for frequent restarters." The adjacent #329 test (TestNoRedundantWritesAcrossCycles) does assert writes, but on the same controller instance applying twice -- which never reaches the read-back path, because that instance already set the flag from its own first write. So the restart case, the one #399 is about, had no outcome coverage at all. Adds it: a fresh controller (what a restart constructs) reads back an already-Enabled inverter, then commands a normal period, and both flash registers must see zero writes -- with a positive assertion that the period command itself still goes out, so it cannot pass by the controller doing nothing. Verified discriminating: forcing _vpp_status_confirmed = False after the read-back fails it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SYRyY3MYjN4dnFEWnxbGyW

Vpp power percentage is off #398

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions