Prepare v1.3.8 release: Update to GitHub Container Registry and synchronize configurations

- Update all image references from Docker Hub to GitHub Container Registry (ghcr.io)
- Synchronize YAML manifests with Helm chart configurations
- Bump version to v1.3.8 in Chart.yaml and all image tags
- Add missing NODE_NAME environment variable to deployment.yaml
- Update resource limits to match Helm chart values (500m CPU, 512Mi memory)
- Add LOG_LEVEL environment variable to eni-manager-daemonset.yaml
- Fix golint issue in pkg/eni-manager/network/manager.go (remove unnecessary else block)
- Ensure MAX_CONCURRENT_RECONCILES is set to 5 consistently across all manifests
- All Go code quality checks passing (go vet, golint, gocyclo, ineffassign, misspell)
- All tests passing successfully

Author: John Lam

charts/aws-multi-eni-controller/Chart.yaml

@@ -2,8 +2,8 @@ apiVersion: v2
 name: aws-multi-eni-controller
 description: A Helm chart for AWS Multi-ENI Controller
 type: application
-version: "1.3.7"
-appVersion: "v1.3.6-comprehensive-tests"
+version: "1.3.8"
+appVersion: "v1.3.8"
 home: https://github.com/johnlam90/aws-multi-eni-controller
 sources:
   - https://github.com/johnlam90/aws-multi-eni-controller

charts/aws-multi-eni-controller/values.yaml

@@ -4,8 +4,8 @@
 
 # Image configuration
 image:
-  repository: johnlam90/aws-multi-eni-controller
-  tag: fix-cleanup-case-01-2261c5e
+  repository: ghcr.io/johnlam90/aws-multi-eni-controller
+  tag: v1.3.8
   pullPolicy: Always
 
 # Namespace to deploy the controller

deploy/deployment.yaml

@@ -173,7 +173,7 @@ spec:
       #   - "kubernetes"
       containers:
       - name: manager
-        image: johnlam90/aws-multi-eni-controller:fix-cleanup-case-01-2261c5e
+        image: ghcr.io/johnlam90/aws-multi-eni-controller:v1.3.8
         env:
         - name: COMPONENT
           value: "eni-controller"
@@ -209,7 +209,12 @@ spec:
           value: "3"
         # Maximum number of concurrent reconciles
         - name: MAX_CONCURRENT_RECONCILES
-          value: "1"
+          value: "5"
+        # Node name for Kubernetes context
+        - name: NODE_NAME
+          valueFrom:
+            fieldRef:
+              fieldPath: spec.nodeName
         # Let Kubernetes handle service discovery automatically
         # - name: KUBERNETES_SERVICE_HOST
         #   value: "172.20.0.1"
@@ -220,8 +225,8 @@ spec:
         - --enable-leader-election
         resources:
           limits:
-            cpu: 100m
-            memory: 128Mi
+            cpu: 500m
+            memory: 512Mi
           requests:
             cpu: 100m
             memory: 128Mi

deploy/eni-manager-daemonset.yaml

@@ -20,7 +20,7 @@ spec:
         ng: multi-eni
       initContainers:
       - name: dpdk-setup
-        image: johnlam90/aws-multi-eni-controller:fix-cleanup-case-01-2261c5e
+        image: ghcr.io/johnlam90/aws-multi-eni-controller:v1.3.8
         command: ["/bin/sh", "-c"]
         args:
         - |
@@ -180,7 +180,7 @@ spec:
           readOnly: true
       containers:
       - name: eni-manager
-        image: johnlam90/aws-multi-eni-controller:fix-cleanup-case-01-2261c5e
+        image: ghcr.io/johnlam90/aws-multi-eni-controller:v1.3.8
         env:
         - name: COMPONENT
           value: "eni-manager"
@@ -215,6 +215,8 @@ spec:
         # Enable aggressive IMDS configuration for node replacement scenarios
         - name: IMDS_AGGRESSIVE_CONFIGURATION
           value: "true"
+        - name: LOG_LEVEL
+          value: "info"
         # DPDK Configuration
         - name: ENABLE_DPDK
           value: "true"  # Enable DPDK device binding

pkg/eni-manager/network/manager.go

@@ -130,12 +130,11 @@ func (m *Manager) BringUpInterface(ifaceName string) error {
 			if updatedLink.Attrs().Flags&net.FlagUp != 0 {
 				log.Printf("Successfully brought up interface %s using netlink (attempt %d)", ifaceName, attempt)
 				return nil
-			} else {
-				log.Printf("Interface %s netlink operation succeeded but interface is still down (attempt %d)", ifaceName, attempt)
-				if attempt < maxRetries {
-					time.Sleep(retryDelay)
-					continue
-				}
+			}
+			log.Printf("Interface %s netlink operation succeeded but interface is still down (attempt %d)", ifaceName, attempt)
+			if attempt < maxRetries {
+				time.Sleep(retryDelay)
+				continue
 			}
 		}
 	}