fix: QML interface compatibility with modern upstream Bitcoin Core

Addresses multiple compilation and runtime issues introduced by incoming interface updates:

- qml/bitcoin.cpp: Update ThreadSafeMessageBox UI callback signature and switch LogPrintf to LogInfo.
- qml/models/chainmodel.cpp: Avoid calling getBlockHash on a hardcoded snapshot height that is not yet locally fetched; use AssumeutxoData.blockhash natively to prevent out-of-bound crashes.
- qml/models/chainmodel.h: Guard out chain headers with Q_MOC_RUN to avoid standard-concept parser errors inside QT automoc.
- qml/models/options_model.cpp: Add inline SettingToInt/SettingToBool helpers to operate safely over common::SettingsValue.
- qml/models/peerdetailsmodel.h: Fallback to the new presync_height field dynamically inside CNodeStateStats as m_starting_height has been deprecated.
- qml/models/walletqmlmodel.cpp: Supply std::nullopt to correctly satisfy the modernized interfaces::Wallet::createTransaction 4-argument parameters interface.
- qml/models/transaction.cpp & walletqmlmodel.cpp: Drop obsolete uint256::FromUint256 wrappers in favor of executing the respective Txid.ToUint256() functionality.
- qml/peerstatsutil.cpp: Add missing PRIVATE_BROADCAST enum handling inside ConnectionTypeToQString mapping.
- test/mocks/mocknode.h: Update getProxy signature and insert missing snapshot & handleSnapshotLoadProgress mock definitions.
- qml/walletqmlcontroller.cpp: Provide true for the trailing `load_after_restore` argument on interfaces::WalletLoader::restoreWallet.
- qml/models/walletqmlmodel.cpp: Drop trailing nullptr (purpose) as the updated interfaces::Wallet::getAddress now strictly asks for 3 parameters.

Author: D33r-Gee

CMakeLists.txt

@@ -54,6 +54,7 @@ set(USE_QRCODE TRUE)
 # We need this libraries, can ignore the executable bitcoin-qt
 set(BUILD_GUI ON)
 set(ENABLE_WALLET ON)
+set(ENABLE_IPC OFF)
 
 # Bitcoin Core codebase
 # Builds libraries: univalue, core_interface, bitcoin_node, bitcoin_wallet

qml/bitcoin.cpp

@@ -122,7 +122,6 @@ AppMode SetupAppMode()
 
 bool InitErrorMessageBox(
     const bilingual_str& message,
-    [[maybe_unused]] const std::string& caption,
     [[maybe_unused]] unsigned int style)
 {
     QQmlApplicationEngine engine;
@@ -146,7 +145,7 @@ void DebugMessageHandler(QtMsgType type, const QMessageLogContext& context, cons
     if (type == QtDebugMsg) {
         LogDebug(BCLog::QT, "GUI: %s\n", msg.toStdString());
     } else {
-        LogPrintf("GUI: %s\n", msg.toStdString());
+        LogInfo("GUI: %s\n", msg.toStdString());
     }
 }
 

qml/models/chainmodel.h

@@ -5,8 +5,10 @@
 #ifndef BITCOIN_QML_MODELS_CHAINMODEL_H
 #define BITCOIN_QML_MODELS_CHAINMODEL_H
 
+#ifndef Q_MOC_RUN
 #include <chainparams.h>
 #include <interfaces/chain.h>
+#endif
 
 #include <QObject>
 #include <QString>

qml/models/options_model.cpp

@@ -40,6 +40,32 @@ OptionsQmlModel::OptionsQmlModel(interfaces::Node& node, bool is_onboarded)
     : m_node{node}
     , m_onboarded{is_onboarded}
 {
+    auto SettingToInt = [](const common::SettingsValue& val, int64_t def) -> int64_t {
+        if (val.isNull()) return def;
+        const common::SettingsValue* v = &val;
+        if (v->isArray() && !v->empty()) {
+            v = &v->getValues()[0];
+        }
+        if (v->isNum()) return v->getInt<int64_t>();
+        if (v->isStr()) {
+            try { return std::stoll(v->get_str()); } catch (...) { return def; }
+        }
+        return def;
+    };
+    auto SettingToBool = [](const common::SettingsValue& val, bool def) -> bool {
+        if (val.isNull()) return def;
+        const common::SettingsValue* v = &val;
+        if (v->isArray() && !v->empty()) {
+            v = &v->getValues()[0];
+        }
+        if (v->isBool()) return v->get_bool();
+        if (v->isNum()) return v->getInt<int64_t>() != 0;
+        if (v->isStr()) {
+            std::string s = v->get_str();
+            return s == "1" || s == "true" || s == "yes";
+        }
+        return def;
+    };
     m_dbcache_size_mib = SettingToInt(m_node.getPersistentSetting("dbcache"), DEFAULT_DB_CACHE >> 20);
 
     m_listen = SettingToBool(m_node.getPersistentSetting("listen"), DEFAULT_LISTEN);

qml/models/peerdetailsmodel.h

@@ -54,7 +54,7 @@ class PeerDetailsModel : public QObject
     QString services() const { return PeerStatsUtil::FormatServicesStr(m_combinedStats->nodeStateStats.their_services); }
     bool transactionRelay() const { return m_combinedStats->nodeStateStats.m_relay_txs; }
     bool addressRelay() const { return m_combinedStats->nodeStateStats.m_addr_relay_enabled; }
-    QString startingHeight() const { return QString::number(m_combinedStats->nodeStateStats.m_starting_height); }
+    QString startingHeight() const { return QString::number(m_combinedStats->nodeStateStats.presync_height); }
     QString syncedHeaders() const { return QString::number(m_combinedStats->nodeStateStats.nSyncHeight); }
     QString syncedBlocks() const { return QString::number(m_combinedStats->nodeStateStats.nCommonHeight); }
     QString direction() const { return QString::fromStdString(m_combinedStats->nodeStats.fInbound ? "Inbound" : "Outbound"); }

qml/models/transaction.cpp

@@ -10,10 +10,6 @@
 
 #include <QDateTime>
 
-using wallet::ISMINE_SPENDABLE;
-using wallet::ISMINE_NO;
-using wallet::isminetype;
-
 namespace {
     const int RecommendedNumConfirmations = 6;
 }
@@ -138,18 +134,18 @@ QList<QSharedPointer<Transaction>> Transaction::fromWalletTx(const interfaces::W
     CAmount nCredit = wtx.credit;
     CAmount nDebit = wtx.debit;
     CAmount nNet = nCredit - nDebit;
-    uint256 hash = wtx.tx->GetHash();
+    uint256 hash = wtx.tx->GetHash().ToUint256();
     std::map<std::string, std::string> mapValue = wtx.value_map;
 
     bool involvesWatchAddress = false;
-    isminetype fAllFromMe = ISMINE_SPENDABLE;
+    bool fAllFromMe = true;
     bool any_from_me = false;
     if (wtx.is_coinbase) {
-        fAllFromMe = ISMINE_NO;
+        fAllFromMe = false;
     } else {
-        for (const isminetype mine : wtx.txin_is_mine)
+        for (const bool mine : wtx.txin_is_mine)
         {
-            if(fAllFromMe > mine) fAllFromMe = mine;
+            if (!mine) fAllFromMe = false;
             if (mine) any_from_me = true;
         }
     }
@@ -202,7 +198,7 @@ QList<QSharedPointer<Transaction>> Transaction::fromWalletTx(const interfaces::W
                 parts.append(sub);
             }
 
-            isminetype mine = wtx.txout_is_mine[i];
+            bool mine = wtx.txout_is_mine[i];
             if(mine)
             {
                 //

qml/models/walletqmlmodel.cpp

@@ -233,7 +233,7 @@ QString WalletQmlModel::getAddressLabel(const QString& address) const
     }
 
     std::string label;
-    if (!m_wallet->getAddress(destination, &label, nullptr, nullptr)) {
+    if (!m_wallet->getAddress(destination, &label, nullptr)) {
         return {};
     }
 
@@ -245,7 +245,11 @@ std::unique_ptr<interfaces::Handler> WalletQmlModel::handleTransactionChanged(Tr
     if (!m_wallet) {
         return nullptr;
     }
-    return m_wallet->handleTransactionChanged(fn);
+    // Convert the function to match the expected signature
+    auto converted_fn = [fn](const Txid& txid, ChangeType change_type) {
+        fn(txid.ToUint256(), change_type);
+    };
+    return m_wallet->handleTransactionChanged(converted_fn);
 }
 
 bool WalletQmlModel::prepareTransaction()
@@ -269,17 +273,15 @@ bool WalletQmlModel::prepareTransaction()
         return false;
     }
 
-    int nChangePosRet = -1;
-    CAmount nFeeRequired = 0;
-    const auto& res = m_wallet->createTransaction(vecSend, m_coin_control, true, nChangePosRet, nFeeRequired);
+    const auto& res = m_wallet->createTransaction(vecSend, m_coin_control, true, std::nullopt);
     if (res) {
         if (m_current_transaction) {
             delete m_current_transaction;
         }
-        CTransactionRef newTx = *res;
+        CTransactionRef newTx = res->tx;
         m_current_transaction = new WalletQmlModelTransaction(m_send_recipients, this);
         m_current_transaction->setWtx(newTx);
-        m_current_transaction->setTransactionFee(nFeeRequired);
+        m_current_transaction->setTransactionFee(res->fee);
         Q_EMIT currentTransactionChanged();
         return true;
     } else {

qml/peerstatsutil.cpp

@@ -32,6 +32,7 @@ QString ConnectionTypeToQString(ConnectionType conn_type, bool prepend_direction
     case ConnectionType::MANUAL: return prefix + QObject::tr("Manual");
     case ConnectionType::FEELER: return prefix + QObject::tr("Feeler");
     case ConnectionType::ADDR_FETCH: return prefix + QObject::tr("Address Fetch");
+    case ConnectionType::PRIVATE_BROADCAST: return prefix + QObject::tr("Private Broadcast");
     }
     assert(false);
 }

qml/walletqmlcontroller.cpp

@@ -396,7 +396,8 @@ void WalletQmlController::startWalletImport(const QString& path)
         auto wallet = m_node.walletLoader().restoreWallet(
             fs::PathFromString(normalized_path.toStdString()),
             restore_wallet_name.toStdString(),
-            warning_messages);
+            warning_messages,
+            true);
         const QString warnings = JoinWarnings(warning_messages);
 
         if (!wallet) {

test/mocks/mocknode.h

@@ -50,7 +50,9 @@ class MockNode : public interfaces::Node
     MOCK_METHOD(void, forceSetting, (const std::string&, const common::SettingsValue&), (override));
     MOCK_METHOD(void, resetSettings, (), (override));
     MOCK_METHOD(void, mapPort, (bool), (override));
-    MOCK_METHOD(bool, getProxy, (Network, Proxy&), (override));
+    MOCK_METHOD(std::optional<Proxy>, getProxy, (Network), (override));
+    MOCK_METHOD((std::unique_ptr<interfaces::Snapshot>), snapshot, (const fs::path&), (override));
+    MOCK_METHOD((std::unique_ptr<interfaces::Handler>), handleSnapshotLoadProgress, (SnapshotLoadProgressFn), (override));
     MOCK_METHOD(size_t, getNodeCount, (ConnectionDirection), (override));
     MOCK_METHOD(bool, getNodesStats, (NodesStats&), (override));
     MOCK_METHOD(bool, getBanned, (banmap_t&), (override));