test: cover wallet passphrase clearing

Author: johnny9

test/qml/tst_walletpassphrasepopup.qml

@@ -0,0 +1,118 @@
+// Copyright (c) 2026 The Bitcoin Core developers
+// Distributed under the MIT software license, see the accompanying
+// file COPYING or http://www.opensource.org/licenses/mit-license.php.
+
+import QtQuick 2.15
+import QtTest 1.2
+import "../../qml/components"
+
+TestCase {
+    name: "WalletPassphrasePopup"
+    when: windowShown
+    width: 500
+    height: 320
+
+    property string submittedPassphrase: ""
+    property int submittedCount: 0
+
+    Component {
+        id: popupComponent
+
+        WalletPassphrasePopup {
+            popupObjectName: "testPassphrasePopup"
+            titleText: "Enter wallet password"
+            descriptionText: "Test password prompt"
+            passphraseFieldObjectName: "testPassphraseField"
+            cancelButtonObjectName: "testPassphraseCancelButton"
+            confirmButtonObjectName: "testPassphraseConfirmButton"
+        }
+    }
+
+    function findObjectByName(root, objectName) {
+        if (!root) {
+            return null
+        }
+        if (root.objectName === objectName) {
+            return root
+        }
+
+        if (root.contentItem) {
+            const contentResult = findObjectByName(root.contentItem, objectName)
+            if (contentResult) {
+                return contentResult
+            }
+        }
+
+        const children = root.children || []
+        for (let i = 0; i < children.length; ++i) {
+            const childResult = findObjectByName(children[i], objectName)
+            if (childResult) {
+                return childResult
+            }
+        }
+
+        return null
+    }
+
+    function createPopup() {
+        submittedPassphrase = ""
+        submittedCount = 0
+
+        const popup = createTemporaryObject(popupComponent, this)
+        verify(popup !== null)
+        popup.submitted.connect(function(passphrase) {
+            submittedPassphrase = passphrase
+            submittedCount += 1
+        })
+        popup.open()
+        tryCompare(popup, "opened", true)
+        return popup
+    }
+
+    function test_submit_clears_field_after_emitting_passphrase() {
+        const popup = createPopup()
+        const field = findObjectByName(popup, "testPassphraseField")
+        const button = findObjectByName(popup, "testPassphraseConfirmButton")
+        verify(field !== null)
+        verify(button !== null)
+
+        const passphrase = "correct horse battery staple"
+        field.text = passphrase
+        verify(button.enabled)
+
+        mouseClick(button, button.width / 2, button.height / 2)
+
+        compare(submittedCount, 1)
+        compare(submittedPassphrase, passphrase)
+        compare(field.text, "")
+    }
+
+    function test_close_clears_field_without_submitting() {
+        const popup = createPopup()
+        const field = findObjectByName(popup, "testPassphraseField")
+        verify(field !== null)
+
+        field.text = "unused passphrase"
+        popup.close()
+        tryCompare(popup, "opened", false)
+
+        compare(submittedCount, 0)
+        compare(field.text, "")
+    }
+
+    function test_reopen_clears_stale_field_text() {
+        const popup = createPopup()
+        const field = findObjectByName(popup, "testPassphraseField")
+        verify(field !== null)
+
+        field.text = "stale passphrase"
+        popup.close()
+        tryCompare(popup, "opened", false)
+        field.text = "stale passphrase"
+
+        popup.open()
+        tryCompare(popup, "opened", true)
+
+        compare(field.text, "")
+    }
+}

test/test_walletqmlcontroller.cpp

@@ -160,6 +160,7 @@ private Q_SLOTS:
     void selectWalletBeforeInitializationSetsLoadError();
     void initializedControllerPropagatesCreateErrors();
     void initializedControllerForwardsMigrationPassphrase();
+    void initializedControllerForwardsUtf8CreatePassphrase();
     void initializedControllerRequestsPassphraseBeforeEncryptedMigration();
     void initializedControllerMigratesUnencryptedWalletWithoutPassphrase();
 };
@@ -361,6 +362,36 @@ void WalletQmlControllerTests::initializedControllerForwardsMigrationPassphrase(
     QVERIFY(!controller.walletMigrationInProgress());
 }
 
+void WalletQmlControllerTests::initializedControllerForwardsUtf8CreatePassphrase()
+{
+    using ::testing::StrictMock;
+
+    StrictMock<MockNode> node;
+    FakeWalletLoader loader;
+    ExpectControllerInitialization(node, loader);
+
+    WalletQmlController controller(node);
+    controller.initialize();
+
+    const QString passphrase{QString::fromUtf8("pässwörd-₿")};
+    const std::string expected_passphrase{passphrase.toUtf8().toStdString()};
+
+    bool saw_expected_passphrase{false};
+    loader.create_wallet_fn = [&](const std::string&,
+                                  const SecureString& passphrase,
+                                  uint64_t,
+                                  std::vector<bilingual_str>&) {
+        saw_expected_passphrase = (std::string{passphrase.begin(), passphrase.end()} == expected_passphrase);
+        return util::Result<std::unique_ptr<interfaces::Wallet>>{
+            util::Error{Untranslated("Wallet creation failed.")}};
+    };
+
+    QVERIFY(!controller.createSingleSigWallet("test_wallet", passphrase));
+    QVERIFY(saw_expected_passphrase);
+    QCOMPARE(loader.create_wallet_calls, 1);
+    QCOMPARE(controller.walletCreateError(), QString{"Wallet creation failed."});
+}
+
 void WalletQmlControllerTests::initializedControllerRequestsPassphraseBeforeEncryptedMigration()
 {
     using ::testing::StrictMock;

test/test_walletqmlmodel.cpp

@@ -213,6 +213,7 @@ private Q_SLOTS:
     void transactionChangedEmitsBalanceChanged();
     void prepareTransactionOnLockedWalletRequiresPassword();
     void prepareTransactionWithPrivateKeysDisabledDoesNotRequirePassword();
+    void prepareTransactionWithPassphraseForwardsUtf8Bytes();
     void prepareTransactionWithPassphraseRelocksWhenRecipientsInvalid();
     void prepareTransactionWithPassphraseRelocksWhenCustomFeeInvalid();
     void sendTransactionCommitsPreparedTransactionWithoutUnlockingAgain();
@@ -721,6 +722,22 @@ void WalletQmlModelTests::prepareTransactionWithPrivateKeysDisabledDoesNotRequir
     QCOMPARE(wallet->lock_calls, 0);
 }
 
+void WalletQmlModelTests::prepareTransactionWithPassphraseForwardsUtf8Bytes()
+{
+    FakePasswordWallet* wallet{nullptr};
+    auto model = MakeWalletModel(wallet);
+    SetPasswordRecipient(*model, 1'000);
+
+    const QString passphrase{QString::fromUtf8("pässwörd-₿")};
+    const std::string expected_passphrase{passphrase.toUtf8().toStdString()};
+
+    QVERIFY(model->prepareTransactionWithPassphrase(passphrase));
+    QCOMPARE(wallet->unlock_calls, 1);
+    QCOMPARE(wallet->unlock_passphrases.size(), size_t{1});
+    QCOMPARE(wallet->unlock_passphrases.front(), expected_passphrase);
+    QCOMPARE(wallet->lock_calls, 1);
+}
+
 void WalletQmlModelTests::prepareTransactionWithPassphraseRelocksWhenRecipientsInvalid()
 {
     FakePasswordWallet* wallet{nullptr};