Cap btcToSats to prevent overflow errors

johnny9 · johnny9 · commit 5ec53c01b34e · 2026-02-13T19:38:11.000-05:00
diff --git a/qml/bitcoinamount.cpp b/qml/bitcoinamount.cpp
@@ -4,6 +4,8 @@
 
 #include <qml/bitcoinamount.h>
 
+#include <limits>
+
 #include <QRegularExpression>
 #include <QStringList>
 
@@ -131,6 +133,10 @@ qint64 BitcoinAmount::btcToSats(const QString& btcSanitized)
         frac = parts[1].leftJustified(8, '0').toLongLong();
     }
 
+    if (whole > std::numeric_limits<qint64>::max() / COIN) {
+        return std::numeric_limits<qint64>::max();
+    }
+
     return whole * COIN + frac;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,8 @@`
`4`	`4`
`5`	`5`	`#include <qml/bitcoinamount.h>`
`6`	`6`
	`7`	`+#include <limits>`
	`8`	`+`
`7`	`9`	`#include <QRegularExpression>`
`8`	`10`	`#include <QStringList>`
`9`	`11`
`@@ -131,6 +133,10 @@ qint64 BitcoinAmount::btcToSats(const QString& btcSanitized)`
`131`	`133`	`frac = parts[1].leftJustified(8, '0').toLongLong();`
`132`	`134`	`}`
`133`	`135`
	`136`	`+ if (whole > std::numeric_limits<qint64>::max() / COIN) {`
	`137`	`+ return std::numeric_limits<qint64>::max();`
	`138`	`+ }`
	`139`	`+`
`134`	`140`	`return whole * COIN + frac;`
`135`	`141`	`}`
`136`	`142`