qml: close console autocomplete when changing tabs

Author: johnny9

qml/controls/NavigationBar2.qml

@@ -7,15 +7,40 @@ import QtQuick.Controls 2.15
 import QtQuick.Layouts 1.15
 
 Pane {
+    id: root
+
     property alias leftItem: left_section.contentItem
     property alias centerItem: center_section.contentItem
     property alias rightItem: right_section.contentItem
     property var navigationStack: null
+    // Optional tab group supplied by a containing view. This lets content
+    // pages close transient UI when the user leaves their tab.
+    property var tabGroup: null
+    property var currentTab: null
     property bool showBackButton: navigationStack ? navigationStack.canGoBack : false
     property string backButtonObjectName: ""
     property string backButtonText: qsTr("Back")
 
     signal backClicked
+    signal tabChanged(var previousTab, var currentTab)
+
+    onTabGroupChanged: {
+        currentTab = tabGroup ? tabGroup.checkedButton : null
+    }
+
+    Connections {
+        target: root.tabGroup
+
+        function onCheckedButtonChanged() {
+            const nextTab = root.tabGroup.checkedButton
+            if (!nextTab || nextTab === root.currentTab) {
+                return
+            }
+            const previousTab = root.currentTab
+            root.currentTab = nextTab
+            root.tabChanged(previousTab, nextTab)
+        }
+    }
 
     background: null
     padding: 4

qml/pages/node/CommandConsole.qml

@@ -29,6 +29,20 @@ Page {
     property bool searchMode: false
     property string commandDraft: ""
     property string searchDraft: ""
+    // DesktopWallets supplies its navigation bar so this persistent
+    // StackLayout child can dismiss overlay-based transient UI on tab changes.
+    property var navigationBar: null
+    property var navigationTab: null
+
+    Connections {
+        target: root.navigationBar
+
+        function onTabChanged(previousTab, currentTab) {
+            if (previousTab === root.navigationTab) {
+                autocompletePopup.close()
+            }
+        }
+    }
 
     function _pushPalette() {
         rpcConsoleModel.requestColor = consoleRequestColor

qml/pages/wallet/DesktopWallets.qml

@@ -106,6 +106,7 @@ Page {
 
     header: NavigationBar2 {
         id: navBar
+        tabGroup: navigationTabs
         leftItem: WalletBadge {
             objectName: "walletBadge"
             implicitWidth: 175
@@ -346,6 +347,8 @@ Page {
         }
         CommandConsole {
             showHeader: false
+            navigationBar: navBar
+            navigationTab: consoleTabButton
             walletName: walletController.isWalletLoaded && walletController.selectedWallet
                 ? walletController.selectedWallet.name
                 : ""

test/qml/tst_desktopwallets.qml

@@ -97,6 +97,26 @@ TestCase {
         compare(tabs[3].iconSize, 30)
     }
 
+    function test_console_autocomplete_closes_when_switching_tabs() {
+        const page = createDesktopWallets()
+        const consoleTab = findChild(page, "consoleTabButton")
+        const activityTab = findChild(page, "activityTabButton")
+        const popup = findChild(page, "consoleAutocompletePopup")
+
+        verify(consoleTab !== null)
+        verify(activityTab !== null)
+        verify(popup !== null)
+
+        consoleTab.checked = true
+        tryCompare(consoleTab, "checked", true)
+        popup.open()
+        tryCompare(popup, "visible", true)
+
+        activityTab.checked = true
+        tryCompare(activityTab, "checked", true)
+        tryCompare(popup, "visible", false)
+    }
+
     function test_receive_options_view_address_history_opens_settings_address_stack() {
         const page = createDesktopWallets()
         const receiveTab = findChild(page, "receiveTabButton")