build: build app tests by default

Build app tests by default when GUI support is enabled, while retaining the explicit BUILD_APP_TESTS opt-out.

Build and run the app tests in the depends CI job, use the minimal QPA platform, and import the static Qt minimal and QML plugins needed by the test binaries.

Author: johnny9

.github/workflows/artifacts.yml

@@ -30,7 +30,7 @@ jobs:
       - name: MacOS Install Deps
         if: contains(matrix.os, 'macos')
         run: |
-          brew install ccache boost pkgconf libevent qt@6 qrencode coreutils llvm
+          brew install ccache boost pkgconf qt@6 qrencode coreutils llvm
           llvm_prefix="$(brew --prefix llvm)"
           echo "CC=${llvm_prefix}/bin/clang" >> "$GITHUB_ENV"
           echo "CXX=${llvm_prefix}/bin/clang++" >> "$GITHUB_ENV"

.github/workflows/depends-build.yml

@@ -143,14 +143,18 @@ jobs:
           cmake -S . -B "${BUILD_DIR}" -G Ninja \
             -DCMAKE_BUILD_TYPE=Release \
             -DCMAKE_TOOLCHAIN_FILE="${PWD}/bitcoin/depends/${HOST}/toolchain.cmake" \
-            -DBUILD_APP_TESTS=OFF \
+            -DBUILD_APP_TESTS=ON \
             -DBUILD_GUI=ON \
             -DENABLE_WALLET=ON \
             -DENABLE_IPC=OFF
 
-      - name: Build bitcoin-core-app
+      - name: Build
         run: |
-          cmake --build "${BUILD_DIR}" --target bitcoin-core-app --parallel "${JOBS}"
+          cmake --build "${BUILD_DIR}" --parallel "${JOBS}"
+
+      - name: Run app tests
+        run: |
+          ctest --test-dir "${BUILD_DIR}" --output-on-failure --parallel "${JOBS}"
 
       - name: Upload depends logs
         uses: actions/upload-artifact@v4

CMakeLists.txt

@@ -6,6 +6,8 @@ project(BitcoinCoreApp
   LANGUAGES CXX
 )
 
+include(CMakeDependentOption)
+
 # Language setup
 if(CMAKE_SYSTEM_NAME STREQUAL "Darwin" AND NOT CMAKE_HOST_APPLE)
   # We do not use the install_name_tool when cross-compiling for macOS.
@@ -53,6 +55,7 @@ set(USE_QRCODE TRUE)
 # We need this libraries, can ignore the executable bitcoin-qt
 set(BUILD_GUI ON)
 set(ENABLE_WALLET ON)
+cmake_dependent_option(BUILD_APP_TESTS "Build tests for the app" ON "BUILD_GUI" OFF)
 
 # Bitcoin Core codebase
 # Builds libraries: univalue, core_interface, bitcoin_node, bitcoin_wallet
@@ -193,7 +196,6 @@ target_link_libraries(bitcoin-core-app
 )
 qt6_import_qml_plugins(bitcoin-core-app)
 
-option(BUILD_APP_TESTS "Build unit tests for the app" OFF)
 if(BUILD_APP_TESTS)
   include(CTest)
   enable_testing()

test/CMakeLists.txt

@@ -72,7 +72,7 @@ target_link_libraries(bitcoinqml_unit_tests
     Qt6::Widgets
 )
 
-add_test(NAME bitcoinqml_unit_tests COMMAND bitcoinqml_unit_tests -platform offscreen)
+add_test(NAME bitcoinqml_unit_tests COMMAND bitcoinqml_unit_tests -platform minimal)
 
 qt6_add_resources(QMLTESTS_QRC_CPP ${QML_QRC} qml/bitcoin_qmltests.qrc)
 
@@ -103,4 +103,19 @@ target_include_directories(bitcoinqml_qmltests
     ${CMAKE_CURRENT_SOURCE_DIR}/..
 )
 
-add_test(NAME bitcoinqml_qmltests COMMAND bitcoinqml_qmltests -platform offscreen)
+add_test(NAME bitcoinqml_qmltests COMMAND bitcoinqml_qmltests -platform minimal)
+
+get_target_property(qt_lib_type Qt6::Core TYPE)
+if(qt_lib_type STREQUAL "STATIC_LIBRARY")
+  qt6_import_plugins(bitcoinqml_unit_tests INCLUDE Qt6::QMinimalIntegrationPlugin)
+  qt6_import_plugins(bitcoinqml_qmltests INCLUDE Qt6::QMinimalIntegrationPlugin)
+  qt6_import_qml_plugins(bitcoinqml_qmltests)
+  target_link_libraries(bitcoinqml_qmltests PRIVATE
+    Qt6::qtquickdialogsplugin
+  )
+  if(Qt6_VERSION VERSION_GREATER_EQUAL 6.5)
+    target_link_libraries(bitcoinqml_qmltests PRIVATE Qt6::qtqmlcoreplugin)
+  else()
+    target_link_libraries(bitcoinqml_qmltests PRIVATE Qt6::qmlsettingsplugin)
+  endif()
+endif()