unit tests: close paymentrequest model gaps

Expand PaymentRequest tests to cover address encoding, formatted address grouping, destination getter/reset behavior, repeated destination signal emission, and id boundary values.

Align amount display expectations with current BitcoinAmount unset semantics (empty display after default construction and clear).

Author: johnny9

test/test_paymentrequest.cpp

@@ -4,16 +4,24 @@
 
 #include <QtTest/QtTest>
 
+#include <key_io.h>
 #include <qml/models/paymentrequest.h>
 
+#include <limits>
+
 class PaymentRequestTests : public QObject
 {
     Q_OBJECT
 
 private Q_SLOTS:
     void defaultState_isEmpty();
+    void address_returnsEncodedDestination();
+    void addressFormatted_groupsAddressByFourCharacters();
     void setters_emitOnlyOnChange();
     void setDestination_emitsAddressChanged();
+    void destination_returnsLastSetValue_andClearResetsToNoDestination();
+    void setDestination_sameValue_stillEmitsAddressChanged();
+    void setId_handlesBoundaryValues();
     void clear_resetsAllFields();
 };
 
@@ -26,7 +34,49 @@ void PaymentRequestTests::defaultState_isEmpty()
     QCOMPARE(request.message(), QString());
     QCOMPARE(request.amountError(), QString());
     QCOMPARE(request.id(), QString());
-    QCOMPARE(request.amount()->toDisplay(), QString("0.00000000"));
+    QCOMPARE(request.amount()->toDisplay(), QString());
+}
+
+void PaymentRequestTests::address_returnsEncodedDestination()
+{
+    PaymentRequest request;
+    const CTxDestination first_destination = WitnessUnknown{1, std::vector<unsigned char>{0x01, 0x02, 0x03, 0x04}};
+    const CTxDestination second_destination = WitnessUnknown{1, std::vector<unsigned char>{0x05, 0x06, 0x07, 0x08}};
+
+    request.setDestination(first_destination);
+    const QString first_address = request.address();
+    QVERIFY(!first_address.isEmpty());
+    QCOMPARE(first_address, QString::fromStdString(EncodeDestination(first_destination)));
+
+    request.setDestination(second_destination);
+    const QString second_address = request.address();
+    QVERIFY(!second_address.isEmpty());
+    QCOMPARE(second_address, QString::fromStdString(EncodeDestination(second_destination)));
+    QVERIFY(first_address != second_address);
+}
+
+void PaymentRequestTests::addressFormatted_groupsAddressByFourCharacters()
+{
+    PaymentRequest request;
+    request.setDestination(WitnessUnknown{1, std::vector<unsigned char>{0x01, 0x02, 0x03, 0x04}});
+
+    const QString raw_address = request.address();
+    QVERIFY(!raw_address.isEmpty());
+
+    const QString formatted_address = request.addressFormatted();
+    QVERIFY(formatted_address.contains(QChar(' ')));
+
+    QString without_spaces = formatted_address;
+    without_spaces.remove(QChar(' '));
+    QCOMPARE(without_spaces, raw_address);
+
+    const QStringList groups = formatted_address.split(QChar(' '), Qt::SkipEmptyParts);
+    QVERIFY(!groups.isEmpty());
+    for (int i = 0; i < groups.size() - 1; ++i) {
+        QCOMPARE(groups[i].size(), 4);
+    }
+    QVERIFY(groups.back().size() > 0);
+    QVERIFY(groups.back().size() <= 4);
 }
 
 void PaymentRequestTests::setters_emitOnlyOnChange()
@@ -71,6 +121,44 @@ void PaymentRequestTests::setDestination_emitsAddressChanged()
     QCOMPARE(request.addressFormatted(), QString());
 }
 
+void PaymentRequestTests::destination_returnsLastSetValue_andClearResetsToNoDestination()
+{
+    PaymentRequest request;
+    const CTxDestination destination = WitnessUnknown{1, std::vector<unsigned char>{0x01, 0x02, 0x03, 0x04}};
+
+    request.setDestination(destination);
+    QCOMPARE(request.destination(), destination);
+
+    request.clear();
+    QCOMPARE(request.destination(), CTxDestination{CNoDestination{}});
+}
+
+void PaymentRequestTests::setDestination_sameValue_stillEmitsAddressChanged()
+{
+    PaymentRequest request;
+    QSignalSpy address_spy(&request, &PaymentRequest::addressChanged);
+    const CTxDestination destination = WitnessUnknown{1, std::vector<unsigned char>{0x0a, 0x0b, 0x0c, 0x0d}};
+
+    request.setDestination(destination);
+    request.setDestination(destination);
+
+    QCOMPARE(address_spy.count(), 2);
+}
+
+void PaymentRequestTests::setId_handlesBoundaryValues()
+{
+    PaymentRequest request;
+    QSignalSpy id_spy(&request, &PaymentRequest::idChanged);
+
+    request.setId(0u);
+    QCOMPARE(request.id(), QString("0"));
+    QCOMPARE(id_spy.count(), 1);
+
+    request.setId(std::numeric_limits<unsigned int>::max());
+    QCOMPARE(request.id(), QString::number(std::numeric_limits<unsigned int>::max()));
+    QCOMPARE(id_spy.count(), 2);
+}
+
 void PaymentRequestTests::clear_resetsAllFields()
 {
     PaymentRequest request;
@@ -94,7 +182,7 @@ void PaymentRequestTests::clear_resetsAllFields()
     QCOMPARE(request.message(), QString());
     QCOMPARE(request.amountError(), QString());
     QCOMPARE(request.id(), QString());
-    QCOMPARE(request.amount()->toDisplay(), QString("0.00000000"));
+    QCOMPARE(request.amount()->toDisplay(), QString());
     QCOMPARE(address_spy.count(), 1);
     QCOMPARE(label_spy.count(), 1);
     QCOMPARE(message_spy.count(), 1);