show some Cppcheck messages on file-level

Author: firewave

README.md

@@ -108,6 +108,7 @@ Deployment.
 ## Releases
 
 ### 1.7.0 - XXXX-XX-XX
+- Show some Cppcheck messages (`toomanyconfigs`, `missingInclude`, `noValidConfiguration`) on file-level. See [Known Issues](#known-issues) on how to fix these. (Contribution by @firewave)
 
 ### 1.6.2 - 2022-01-25
 

resources/META-INF/plugin.xml

@@ -56,6 +56,7 @@
     ]]></description>
 
   <change-notes><![CDATA[
+      - Show some Cppcheck messages (toomanyconfigs, missingInclude, noValidConfiguration) on file-level. See <a href="https://github.com/johnthagen/clion-cppcheck#known-issues">Known Issues</a> on how to fix these. (Contribution by @firewave)
     ]]>
   </change-notes>
 

src/com/github/johnthagen/cppcheck/CppCheckInspectionImpl.java

@@ -93,16 +93,6 @@ public static List<ProblemDescriptor> parseOutput(@NotNull final PsiFile psiFile
 
             final String id = attributes.getNamedItem("id").getNodeValue();
 
-            // Skip the "toomanyconfigs" error
-            /*
-       			<error id="toomanyconfigs" severity="information" msg="Too many #ifdef configurations - cppcheck only checks 1 of 12 configurations. Use --force to check all configurations." verbose="The checking of the file will be interrupted because there are too many #ifdef configurations. Checking of all #ifdef configurations can be forced by --force command line option or from GUI preferences. However that may increase the checking time." cwe="398">
-                    <location file="C:\Users\Name\AppData\Local\Temp\___valueflow.cpp" line="0" column="0"/>
-                </error>
-            */
-            if (id.equals("toomanyconfigs")) {
-                continue;
-            }
-
             // Skip the "missingIncludeSystem" error
             /*
        			<error id="missingIncludeSystem" severity="information" msg="Cppcheck cannot find all the include files (use --check-config for details)" verbose="Cppcheck cannot find all the include files. Cppcheck can check the code without the include files found. But the results will probably be more accurate if all the include files are found. Please check your project&apos;s include directories and add all of them as include directories for Cppcheck. To see what files Cppcheck cannot find use --check-config."/>
@@ -116,11 +106,6 @@ public static List<ProblemDescriptor> parseOutput(@NotNull final PsiFile psiFile
                 continue;
             }
 
-            // suppress this warnings for now - will be properly handled in an upcoming patch
-            if (id.equals("noValidConfiguration") || id.equals("missingInclude")) {
-                continue;
-            }
-
             // we are never interested in these
             if (id.equals("unmatchedSuppression") || id.equals("purgedConfiguration")) {
                 continue;
@@ -148,49 +133,90 @@ public static List<ProblemDescriptor> parseOutput(@NotNull final PsiFile psiFile
                 }
             }
 
+            String fileName = null;
+            int lineNumber = 0;
+            int column = 0;
+
+            /*
+                <error id="missingInclude" severity="information" msg="Cppcheck cannot find all the include files (use --check-config for details)" verbose="Cppcheck cannot find all the include files. Cppcheck can check the code without the include files found. But the results will probably be more accurate if all the include files are found. Please check your project&apos;s include directories and add all of them as include directories for Cppcheck. To see what files Cppcheck cannot find use --check-config."/>
+            */
+            // TODO: handle like any warning when Cppcheck provides the --check-config results with the normal analysis
+            if (id.equals("missingInclude")) {
+                // is a global warning without location information
+            }
             // ignore entries without location e.g. missingIncludeSystem
-            if (location == null) {
+            else if (location == null) {
                 CppcheckNotification.send("no location for " + psiFile.getVirtualFile().getCanonicalPath(),
                         id + " " + severity + " " + inconclusive + " " + errorMessage,
                         NotificationType.ERROR);
                 continue;
             }
+            else {
+                final NamedNodeMap locationAttributes = location.getAttributes();
+                fileName = new File(locationAttributes.getNamedItem("file").getNodeValue()).getName();
+                lineNumber = Integer.parseInt(locationAttributes.getNamedItem("line").getNodeValue());
+                final Node columnAttr = locationAttributes.getNamedItem("column");
+                // TODO: use in ProblemDescriptor
+                column = -1;
+                // the "column" attribute was added in Cppcheck 1.89
+                if (columnAttr != null) {
+                    column = Integer.parseInt(columnAttr.getNodeValue());
+                }
 
-            final NamedNodeMap locationAttributes = location.getAttributes();
-            final String fileName = new File(locationAttributes.getNamedItem("file").getNodeValue()).getName();
-            int lineNumber = Integer.parseInt(locationAttributes.getNamedItem("line").getNodeValue());
-            final Node columnAttr = locationAttributes.getNamedItem("column");
-            // TODO: use in ProblemDescriptor
-            int column = -1;
-            // the "column" attribute was added in Cppcheck 1.89
-            if (columnAttr != null) {
-                column = Integer.parseInt(columnAttr.getNodeValue());
+                // If a file #include's header files, Cppcheck will also run on the header files and print
+                // any errors. These errors don't apply to the current file and should not be drawn. They can
+                // be distinguished by checking the file name.
+                if (!fileName.equals(sourceFileName)) {
+                    continue;
+                }
             }
 
-            // If a file #include's header files, Cppcheck will also run on the header files and print
-            // any errors. These errors don't apply to the current file and should not be drawn. They can
-            // be distinguished by checking the file name.
-            if (!fileName.equals(sourceFileName)) {
-                continue;
-            }
+            // leaving it at null will report it for the whole file
+            TextRange range = null;
 
-            // Cppcheck error
-            if (lineNumber <= 0 || lineNumber > document.getLineCount()) {
+            /*
+                <error id="toomanyconfigs" severity="information" msg="Too many #ifdef configurations - cppcheck only checks 1 of 12 configurations. Use --force to check all configurations." verbose="The checking of the file will be interrupted because there are too many #ifdef configurations. Checking of all #ifdef configurations can be forced by --force command line option or from GUI preferences. However that may increase the checking time." cwe="398">
+                    <location file="C:\Users\Name\AppData\Local\Temp\___valueflow.cpp" line="0" column="0"/>
+                </error>
+            */
+            if (id.equals("toomanyconfigs")) {
+                // show as message for the file
+            }
+            // TODO: handle like any warning when Cppcheck provides the --check-config results with the normal analysis
+            else if (id.equals("missingInclude")) {
+                // show as message for the file
+            }
+            /*
+                <error id="noValidConfiguration" severity="information" msg="This file is not analyzed. Cppcheck failed to extract a valid configuration. Use -v for more details." verbose="This file is not analyzed. Cppcheck failed to extract a valid configuration. The tested configurations have these preprocessor errors:\012&apos;&apos; : [/mnt/s/GitHub/cppcheck-fw/gui/temp/moc_platforms.cpp:13] #error &quot;The header file &apos;platforms.h&apos; doesn&apos;t include &lt;QObject&gt;.&quot;\012Q_MOC_OUTPUT_REVISION : [/mnt/s/GitHub/cppcheck-fw/gui/temp/moc_platforms.cpp:15] #error &quot;This file was generated using the moc from 5.12.5. It&quot;">
+                    <location file="/mnt/s/GitHub/cppcheck-fw/gui/temp/moc_platforms.cpp" line="0" column="0"/>
+                </error>
+            */
+            else if (id.equals("noValidConfiguration")) {
+                // show as message for the file
+                // show the verbose message as notification since it contains important details
+                final String verboseMessage = attributes.getNamedItem("verbose").getNodeValue();
+                CppcheckNotification.send("noValidConfiguration for "+ psiFile.getVirtualFile().getCanonicalPath(),
+                        verboseMessage,
+                        NotificationType.INFORMATION);
+            }
+            else if (lineNumber <= 0 || lineNumber > document.getLineCount()) {
                 CppcheckNotification.send("line number out-of-bounds for " + psiFile.getVirtualFile().getCanonicalPath(),
                         id + " " + severity + " " + inconclusive + " " + errorMessage + " " + fileName + " " + lineNumber + " " + column,
                         NotificationType.ERROR);
                 continue;
             }
+            else {
+                // Document counts lines starting at 0, rather than 1 like in cppcheck.
+                lineNumber -= 1;
 
-            // Document counts lines starting at 0, rather than 1 like in cppcheck.
-            lineNumber -= 1;
-
-            final int lineStartOffset = DocumentUtil.getFirstNonSpaceCharOffset(document, lineNumber);
-            final int lineEndOffset = document.getLineEndOffset(lineNumber);
+                final int lineStartOffset = DocumentUtil.getFirstNonSpaceCharOffset(document, lineNumber);
+                final int lineEndOffset = document.getLineEndOffset(lineNumber);
+                range = TextRange.create(lineStartOffset, lineEndOffset);
+            }
 
             final ProblemDescriptor problemDescriptor = manager.createProblemDescriptor(
                     psiFile,
-                    TextRange.create(lineStartOffset, lineEndOffset),
+                    range,
                     "Cppcheck: (" + severity + (inconclusive ? INCONCLUSIVE_TEXT : "") + ") " + id + ": " + errorMessage,
                     severityToHighlightType(severity),
                     true);