Merge pull request #72 from firewave/column-fix

Fixed NullPointerException with Cppcheck < 1.89 caused by missing 'column' attribute in XML result

Author: firewave

README.md

@@ -60,7 +60,14 @@ Deployment.
 
 ## Releases
 
-### X.X.X - Unreleased
+### 1.6.2 - 2022-01-25
+
+- Fixed `NullPointerException` with Cppcheck < 1.89 caused by missing `column` attribute in XML result.
+
+### 1.6.1 - 2022-01-14
+
+- Fixed missing `commons-lang3` dependency.
+- Fixed `.idea` project provided by repository.
 
 ### 1.6.0 - 2021-12-26
 

resources/META-INF/plugin.xml

@@ -1,7 +1,7 @@
 <idea-plugin>
   <id>com.github.johnthagen.cppcheck</id>
   <name>cppcheck</name>
-  <version>1.6.1</version>
+  <version>1.6.2</version>
   <vendor email="[email protected]" url="http://github.com/johnthagen">johnthagen</vendor>
 
   <description><![CDATA[
@@ -60,14 +60,7 @@
     ]]></description>
 
   <change-notes><![CDATA[
-      - Parse --xml output instead of text output. (Contribution by @firewave)<br/>
-      - Fixed scanning of files with whitespaces in name. (Contribution by @firewave)
-      - Only scan files which actually exist. (Contribution by @firewave)
-      - Use unique file names for temporary files used for analysis. (Contribution by @firewave)
-      - Properly handle "debug" messages generated by --debug-warnings. (Contribution by @firewave)
-      - Added .cl, .hxx, .tpp and .txx to list of supported file extensions - now matches the ones supported by Cppcheck internally. (Contribution by @firewave)
-      - Internally suppress "unusedFunction" and "unusedStructMember" (for header files only) warnings to avoid false positives. (Contribution by @firewave)
-      - Fixed "information" messages not being shown at all. (Contribution by @firewave)
+    - Fixed `NullPointerException` with Cppcheck < 1.89 caused by missing 'column' attribute in XML result.
     ]]>
   </change-notes>
 

src/com/github/johnthagen/cppcheck/CppCheckInspectionImpl.java

@@ -159,7 +159,13 @@ public static List<ProblemDescriptor> parseOutput(@NotNull final PsiFile psiFile
             final NamedNodeMap locationAttributes = location.getAttributes();
             final String fileName = new File(locationAttributes.getNamedItem("file").getNodeValue()).getName();
             int lineNumber = Integer.parseInt(locationAttributes.getNamedItem("line").getNodeValue());
-            final int column = Integer.parseInt(locationAttributes.getNamedItem("column").getNodeValue()); // TODO
+            final Node columnAttr = locationAttributes.getNamedItem("column");
+            // TODO: use in ProblemDescriptor
+            int column = -1;
+            // the "column" attribute was added in Cppcheck 1.89
+            if (columnAttr != null) {
+                column = Integer.parseInt(columnAttr.getNodeValue());
+            }
 
             // If a file #include's header files, Cppcheck will also run on the header files and print
             // any errors. These errors don't apply to the current file and should not be drawn. They can