fix: warn and exit on invalid command-line arguments

Author: wr0124

options/base_options.py

@@ -58,7 +58,6 @@ def gather_options(self, args=None, json_args=None):
 
         # get the basic options
         opt = self._parse_args(parser, None, args, flat_json)
-
         # get specific options
         opt, parser = self._gather_specific_options(opt, parser, args, flat_json)
 
@@ -94,7 +93,10 @@ def _parse_args(self, parser, opt, args, flat_json, only_known=True):
                     )  # it's not an error anymore because server launching is done with all of the options even those from other models, raising an error will lead to a server crash
         else:
             # do not ignore unknown options here, they are actual errors in the command line
-            opt = parser.parse_args(args)
+            if only_known:
+                opt, _ = parser.parse_known_args(args)
+            else:
+                opt = parser.parse_args(args)
         return opt
 
     def _json_parse_known_args(self, parser, opt, json_args):

util/parser.py

@@ -1,3 +1,4 @@
+import sys
 import json
 import os
 import torch
@@ -21,13 +22,13 @@ def get_opt(main_opt, remaining_args):
 
         with open(main_opt.config_json, "r") as jsonf:
             train_json = flatten_json(json.load(jsonf))
-
-        # Save the config file when --save_config is passed
-        is_config_saved = False
-        if "save_config" in override_options_names:
-            is_config_saved = True
-            override_options_names.remove("save_config")
-            remaining_args.remove("--save_config")
+        #        # Save the config file when --save_config is passed
+        #        is_config_saved = False
+        #        if "save_config" in override_options_names:
+        #            is_config_saved = True
+        #            override_options_names.remove("save_config")
+        #            remaining_args.remove("--save_config")
+        #
 
         if not "--dataroot" in remaining_args:
             remaining_args += ["--dataroot", "unused"]
@@ -37,6 +38,24 @@ def get_opt(main_opt, remaining_args):
             TrainOptions().parse_to_json(remaining_args)
         )
 
+        # Save the config file when --save_config is passed
+        is_config_saved = False
+        if "save_config" in override_options_names:
+            is_config_saved = True
+            override_options_names.remove("save_config")
+
+        train_keys = set(train_json.keys())
+        override_keys = set(override_options_json.keys())
+        override_names = set(override_options_names)
+        override_not_in_train = override_names - train_keys
+        override_not_in_override_json = override_names - override_keys
+        if override_not_in_override_json:
+            unknown_list = ", ".join(sorted(override_not_in_override_json))
+            print(
+                f"\033[93mWARNING: The following command-line options are not recognized: {unknown_list}\033[0m"
+            )
+            sys.exit(1)
+
         for name in override_options_names:
             train_json[name] = override_options_json[name]
 
@@ -46,4 +65,14 @@ def get_opt(main_opt, remaining_args):
     else:
         opt = TrainOptions().parse()  # get training options
 
+        parsed_opt_keys = set(vars(opt).keys())
+        commandline_arg_names = set(get_override_options_names(remaining_args))
+        always_allowed = {"save_config"}
+        invalid_args = commandline_arg_names - parsed_opt_keys - always_allowed
+        if invalid_args:
+            print(
+                f"\033[93mWARNING: The following command-line options are not recognized by the parser: {sorted(list(invalid_args))}\033[0m"
+            )
+            sys.exit(1)  # Stop the script if there are any invalid args
+
     return opt