Skip to content

Commit b34eeb4

Browse files
authored
refactor(gha): resetting IFS not needed, clean up shell scripts
1 parent f6633f3 commit b34eeb4

3 files changed

Lines changed: 18 additions & 6 deletions

File tree

.github/workflows/check-workflows.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,11 @@ on:
2020
jobs:
2121
lint:
2222
name: Lint
23+
2324
runs-on: ubuntu-latest
25+
defaults:
26+
run:
27+
shell: bash --noprofile --norc -euxo pipefail {0}
2428

2529
steps:
2630
- name: Checkout
@@ -31,8 +35,6 @@ jobs:
3135
# renovate: datasource=github-releases depName=rhysd/actionlint
3236
ACTIONLINT_VERSION: v1.7.9
3337
run: |
34-
IFS=$' \n\t'; set -euxo pipefail
35-
3638
# download, extract and setup actionlint
3739
wget -q "https://github.com/rhysd/actionlint/releases/download/${ACTIONLINT_VERSION}/actionlint_${ACTIONLINT_VERSION#v}_linux_amd64.tar.gz" \
3840
-O actionlint.tar.gz

.github/workflows/check.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,11 @@ on:
1919
jobs:
2020
lint:
2121
name: Lint
22+
2223
runs-on: ubuntu-latest
24+
defaults:
25+
run:
26+
shell: bash --noprofile --norc -euxo pipefail {0}
2327

2428
steps:
2529
- name: Checkout
@@ -36,8 +40,6 @@ jobs:
3640
# renovate: datasource=github-releases depName=ammaraskar/msvc-problem-matcher
3741
MSCV_PROBLEM_MATCHER_VERSION: 0.3.0
3842
run: |
39-
IFS=$' \n\t'; set -euxo pipefail
40-
4143
# install luacheck
4244
luarocks install luacheck
4345

.github/workflows/release.yml

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,13 @@ jobs:
1212

1313
create-love-file-and-create-linux-packages:
1414
name: Create .love file & Create Linux packages
15-
runs-on: ubuntu-latest
1615
needs: check
1716

17+
runs-on: ubuntu-latest
18+
defaults:
19+
run:
20+
shell: bash --noprofile --norc -euxo pipefail {0}
21+
1822
steps:
1923
- name: Checkout
2024
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
@@ -54,9 +58,13 @@ jobs:
5458

5559
create-windows-packages-and-github-release:
5660
name: Create Windows packages & GitHub release
57-
runs-on: windows-latest
5861
needs: create-love-file-and-create-linux-packages
5962

63+
runs-on: ubuntu-latest
64+
defaults:
65+
run:
66+
shell: bash --noprofile --norc -euxo pipefail {0}
67+
6068
permissions:
6169
contents: write
6270

0 commit comments

Comments
 (0)