get 5.0.0-release-candidate-9.3.0

Author: jonataslaw

CHANGELOG.md

@@ -1,3 +1,9 @@
+## [5.0.0-release-candidate-9.3.0]
+
+- Support for Flutter 3.29.0
+
+- Remove remaining dart:html references
+
 ## [5.0.0-release-candidate-9.2.1]
 
 - Remove remaining dart:html references

example/.metadata

@@ -4,7 +4,7 @@
 # This file should be version controlled and should not be manually edited.
 
 version:
-  revision: "80c2e84975bbd28ecf5f8d4bd4ca5a2490bfc819"
+  revision: "35c388afb57ef061d06a39b537336c87e0e3d1b1"
   channel: "stable"
 
 project_type: app
@@ -13,11 +13,11 @@ project_type: app
 migration:
   platforms:
     - platform: root
-      create_revision: 80c2e84975bbd28ecf5f8d4bd4ca5a2490bfc819
-      base_revision: 80c2e84975bbd28ecf5f8d4bd4ca5a2490bfc819
-    - platform: android
-      create_revision: 80c2e84975bbd28ecf5f8d4bd4ca5a2490bfc819
-      base_revision: 80c2e84975bbd28ecf5f8d4bd4ca5a2490bfc819
+      create_revision: 35c388afb57ef061d06a39b537336c87e0e3d1b1
+      base_revision: 35c388afb57ef061d06a39b537336c87e0e3d1b1
+    - platform: ios
+      create_revision: 35c388afb57ef061d06a39b537336c87e0e3d1b1
+      base_revision: 35c388afb57ef061d06a39b537336c87e0e3d1b1
 
   # User provided section
 

example/lib/main.dart

@@ -132,28 +132,32 @@ class Second extends StatelessWidget {
   Widget build(BuildContext context) {
     final controller = Get.put(SecondController());
     print('second rebuild');
-    return Scaffold(
-      appBar: AppBar(
-        title: Text('page two ${Get.parameters["id"]}'),
-      ),
-      body: Center(
-        child: Column(
-          children: [
-            Expanded(
-                child: TextField(
-              controller: controller.textEdit,
-            )),
-            SizedBox(
-              height: 300,
-              width: 300,
-              child: ElevatedButton(
-                onPressed: () {
-                  Get.toNamed('/third');
-                },
-                child: const Text('next screen'),
+    return PopScope(
+      canPop: false,
+      onPopInvokedWithResult: (didPop, result) => print('pop invoked'),
+      child: Scaffold(
+        appBar: AppBar(
+          title: Text('page two ${Get.parameters["id"]}'),
+        ),
+        body: Center(
+          child: Column(
+            children: [
+              Expanded(
+                  child: TextField(
+                controller: controller.textEdit,
+              )),
+              SizedBox(
+                height: 300,
+                width: 300,
+                child: ElevatedButton(
+                  onPressed: () {
+                    Get.toNamed('/third');
+                  },
+                  child: const Text('next screen'),
+                ),
               ),
-            ),
-          ],
+            ],
+          ),
         ),
       ),
     );

example/test/widget_test.dart

@@ -0,0 +1,30 @@
+// This is a basic Flutter widget test.
+//
+// To perform an interaction with a widget in your test, use the WidgetTester
+// utility in the flutter_test package. For example, you can send tap and scroll
+// gestures. You can also use WidgetTester to find child widgets in the widget
+// tree, read text, and verify that the values of widget properties are correct.
+
+import 'package:flutter/material.dart';
+import 'package:flutter_test/flutter_test.dart';
+
+import 'package:get_demo/main.dart';
+
+void main() {
+  testWidgets('Counter increments smoke test', (WidgetTester tester) async {
+    // Build our app and trigger a frame.
+    await tester.pumpWidget(const MyApp());
+
+    // Verify that our counter starts at 0.
+    expect(find.text('0'), findsOneWidget);
+    expect(find.text('1'), findsNothing);
+
+    // Tap the '+' icon and trigger a frame.
+    await tester.tap(find.byIcon(Icons.add));
+    await tester.pump();
+
+    // Verify that our counter has incremented.
+    expect(find.text('0'), findsNothing);
+    expect(find.text('1'), findsOneWidget);
+  });
+}

lib/get_navigation/src/extension_navigation.dart

@@ -234,37 +234,40 @@ extension ExtensionDialog on GetInterface {
       }
     }
 
-    Widget baseAlertDialog = AlertDialog(
-      titlePadding: titlePadding ?? const EdgeInsets.all(8),
-      contentPadding: contentPadding ?? const EdgeInsets.all(8),
-
-      backgroundColor: backgroundColor ?? theme.dialogBackgroundColor,
-      shape: RoundedRectangleBorder(
-          borderRadius: BorderRadius.all(Radius.circular(radius))),
-      title: Text(title, textAlign: TextAlign.center, style: titleStyle),
-      content: Column(
-        crossAxisAlignment: CrossAxisAlignment.center,
-        mainAxisSize: MainAxisSize.min,
-        children: [
-          content ??
-              Text(middleText,
-                  textAlign: TextAlign.center, style: middleTextStyle),
-          const SizedBox(height: 16),
-          ButtonTheme(
-            minWidth: 78.0,
-            height: 34.0,
-            child: Wrap(
-              alignment: WrapAlignment.center,
-              spacing: 8,
-              runSpacing: 8,
-              children: actions,
-            ),
-          )
-        ],
-      ),
-      // actions: actions, // ?? <Widget>[cancelButton, confirmButton],
-      buttonPadding: EdgeInsets.zero,
-    );
+    Widget baseAlertDialog = Builder(builder: (context) {
+      return AlertDialog(
+        titlePadding: titlePadding ?? const EdgeInsets.all(8),
+        contentPadding: contentPadding ?? const EdgeInsets.all(8),
+
+        backgroundColor:
+            backgroundColor ?? DialogTheme.of(context).backgroundColor,
+        shape: RoundedRectangleBorder(
+            borderRadius: BorderRadius.all(Radius.circular(radius))),
+        title: Text(title, textAlign: TextAlign.center, style: titleStyle),
+        content: Column(
+          crossAxisAlignment: CrossAxisAlignment.center,
+          mainAxisSize: MainAxisSize.min,
+          children: [
+            content ??
+                Text(middleText,
+                    textAlign: TextAlign.center, style: middleTextStyle),
+            const SizedBox(height: 16),
+            ButtonTheme(
+              minWidth: 78.0,
+              height: 34.0,
+              child: Wrap(
+                alignment: WrapAlignment.center,
+                spacing: 8,
+                runSpacing: 8,
+                children: actions!,
+              ),
+            )
+          ],
+        ),
+        // actions: actions, // ?? <Widget>[cancelButton, confirmButton],
+        buttonPadding: EdgeInsets.zero,
+      );
+    });
 
     return dialog<T>(
       onWillPop != null

lib/get_navigation/src/router_report.dart

@@ -117,7 +117,7 @@ class RouterReportManager<T> {
         _routesKey[routeName]?.remove(element);
       }
     }
-    
+
     _routesKey.remove(routeName);
 
     keysToRemove.clear();

lib/get_navigation/src/routes/get_navigator.dart

@@ -52,7 +52,6 @@ class GetNavigator extends Navigator {
     super.initialRoute,
     super.restorationScopeId,
   }) : super(
-          //keys should be optional
           onPopPage: onPopPage ??
               (route, result) {
                 final didPop = route.didPop(result);

lib/get_navigation/src/routes/observers/route_observer.dart

@@ -205,7 +205,7 @@ class _RouteData {
   final bool isDialog;
   final String? name;
 
-  _RouteData({
+  const _RouteData({
     required this.name,
     required this.isGetPageRoute,
     required this.isBottomSheet,

lib/get_state_manager/src/simple/get_state.dart

@@ -132,14 +132,16 @@ abstract class Bind<T> extends StatelessWidget {
     );
   }
 
+  static bool fenixMode = false;
+
   static Bind lazyPut<S>(
     InstanceBuilderCallback<S> builder, {
     String? tag,
-    bool fenix = true,
+    bool? fenix,
     // VoidCallback? onInit,
     VoidCallback? onClose,
   }) {
-    Get.lazyPut<S>(builder, tag: tag, fenix: fenix);
+    Get.lazyPut<S>(builder, tag: tag, fenix: fenix ?? fenixMode);
     return _FactoryBind<S>(
       tag: tag,
       // initState: (_) {

pubspec.yaml

@@ -1,6 +1,6 @@
 name: get
 description: Open screens/snackbars/dialogs without context, manage states and inject dependencies easily with GetX.
-version: 5.0.0-release-candidate-9.2.1
+version: 5.0.0-release-candidate-9.3.0
 homepage: https://github.com/jonataslaw/getx
 
 environment: