Forgot about model tests

Author: jonathanhogg

src/flitter/render/window/models.pyx

@@ -437,7 +437,7 @@ cdef class Model:
         return VectorModel._get(vertices, faces)
 
     @staticmethod
-    def vector(vertices, faces):
+    def vector(vertices, faces=None):
         return VectorModel._get(Vector._coerce(vertices), Vector._coerce(faces))
 
     @staticmethod
@@ -1620,6 +1620,8 @@ cdef class VectorModel(Model):
     cdef VectorModel _get(Vector vertices, Vector faces):
         if vertices is None or vertices.numbers == NULL:
             return None
+        if faces is not None and faces.numbers == NULL:
+            faces = None
         cdef uint64_t id = VECTOR
         id = HASH_UPDATE(id, vertices.hash(False))
         if faces is not None:

tests/test_models.py

@@ -163,8 +163,7 @@ def test_bad_manifold(self):
 class TestVector(utils.TestCase):
     def test_bad(self):
         self.assertIsNone(Model.vector(None, None))
-        self.assertIsNone(Model.vector('hello', 1))
-        self.assertIsNone(Model.vector(1, 'hello'))
+        self.assertIsNone(Model.vector(None, 1))
 
     def test_basic(self):
         vertices = [0, 0, 0,  1, 0, 0,  0, 1, 0,  0, 0, 1,  1, 0, 1,  0, 1, 1]
@@ -179,6 +178,15 @@ def test_basic(self):
         self.assertAlmostEqual(mesh.area, 3+math.sqrt(2))
         self.assertAlmostEqual(mesh.volume, 0.5)
 
+    def test_convex(self):
+        vertices = [-1, -1, -1,  1, -1, -1,  -1, 1, -1,  1, 1, -1,  -1, -1, 1,  1, -1, 1,  -1, 1, 1,  1, 1, 1]
+        model = Model.vector(vertices)
+        self.assertIs(model, Model.vector(vertices))
+        mesh = model.get_trimesh()
+        self.assertEqual(mesh.bounds.tolist(), [[-1, -1, -1], [1, 1, 1]])
+        self.assertAlmostEqual(mesh.area, 24)
+        self.assertAlmostEqual(mesh.volume, 8)
+
     def test_invalid(self):
         with unittest.mock.patch('flitter.render.window.models.logger') as mock_logger:
             model = Model.vector([0, 0, 0, 0, 0, 1, 0, 1], [0, 1, 2])