fix: exclude skipped reviewer workers from notifications #168
tests.yml
on: pull_request
test
2m 12s
core-flow-smoke
1m 59s
Annotations
10 errors and 2 warnings
|
core-flow-smoke
Process completed with exit code 1.
|
|
[@jonit-dev/night-watch-cli] src/__tests__/scripts/core-flow-smoke.test.ts > core flow smoke tests (bash scripts) > reviewer parallel mode should aggregate results when one worker times out and one succeeds:
packages/cli/src/__tests__/scripts/core-flow-smoke.test.ts#L3242
AssertionError: expected +0 to be 124 // Object.is equality
- Expected
+ Received
- 124
+ 0
❯ src/__tests__/scripts/core-flow-smoke.test.ts:3242:27
|
|
[@jonit-dev/night-watch-cli] src/__tests__/scripts/core-flow-smoke.test.ts > core flow smoke tests (bash scripts) > reviewer should label targeted PR needs-human-review when score stays missing after max retries:
packages/cli/src/__tests__/scripts/core-flow-smoke.test.ts#L2868
AssertionError: expected +0 to be 1 // Object.is equality
- Expected
+ Received
- 1
+ 0
❯ src/__tests__/scripts/core-flow-smoke.test.ts:2868:27
|
|
[@jonit-dev/night-watch-cli] src/__tests__/scripts/core-flow-smoke.test.ts > core flow smoke tests (bash scripts) > reviewer targeted mode should give attempt 1 the full remaining runtime budget:
packages/cli/src/__tests__/scripts/core-flow-smoke.test.ts#L2105
AssertionError: expected '\n━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━…' to contain 'RETRY: Starting attempt 1/3 (timeout:…'
- Expected
+ Received
- RETRY: Starting attempt 1/3 (timeout: 3s) pr=1
+
+ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+ [2026-05-10 16:47:46] [PID:9824] [+0m1s] RUN-START: reviewer invoked project=/tmp/nw-smoke-reviewer-budget-Ssaws0 provider=claude worker=0 target_pr=1 parallel=0
+ [2026-05-10 16:47:46] [PID:9824] [+0m1s] CONFIG: max_runtime=3s min_review_score=80 branch_patterns=night-watch/
+ [2026-05-10 16:47:46] [PID:9824] [+0m1s] SKIP: No open PRs matching branch patterns (night-watch/)
+
❯ src/__tests__/scripts/core-flow-smoke.test.ts:2105:25
|
|
[@jonit-dev/night-watch-cli] src/__tests__/scripts/core-flow-smoke.test.ts > core flow smoke tests (bash scripts) > reviewer worker mode should allow concurrent runs for different target PRs:
packages/cli/src/__tests__/scripts/core-flow-smoke.test.ts#L1651
AssertionError: expected 'NIGHT_WATCH_RESULT:skip_no_open_prs\n' to contain 'NIGHT_WATCH_RESULT:success_reviewed'
- Expected
+ Received
- NIGHT_WATCH_RESULT:success_reviewed
+ NIGHT_WATCH_RESULT:skip_no_open_prs
+
❯ src/__tests__/scripts/core-flow-smoke.test.ts:1651:29
|
|
test
Process completed with exit code 1.
|
|
src/__tests__/scripts/core-flow-smoke.test.ts > core flow smoke tests (bash scripts) > reviewer should label targeted PR needs-human-review when score stays missing after max retries:
packages/cli/src/__tests__/scripts/core-flow-smoke.test.ts#L2868
AssertionError: expected +0 to be 1 // Object.is equality
- Expected
+ Received
- 1
+ 0
❯ src/__tests__/scripts/core-flow-smoke.test.ts:2868:27
|
|
src/__tests__/scripts/core-flow-smoke.test.ts > core flow smoke tests (bash scripts) > reviewer targeted mode should give attempt 1 the full remaining runtime budget:
packages/cli/src/__tests__/scripts/core-flow-smoke.test.ts#L2105
AssertionError: expected '\n━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━…' to contain 'RETRY: Starting attempt 1/3 (timeout:…'
- Expected
+ Received
- RETRY: Starting attempt 1/3 (timeout: 3s) pr=1
+
+ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+ [2026-05-10 16:48:00] [PID:12186] [+0m0s] RUN-START: reviewer invoked project=/tmp/nw-smoke-reviewer-budget-wJs9QI provider=claude worker=0 target_pr=1 parallel=0
+ [2026-05-10 16:48:00] [PID:12186] [+0m0s] CONFIG: max_runtime=3s min_review_score=80 branch_patterns=night-watch/
+ [2026-05-10 16:48:00] [PID:12186] [+0m0s] SKIP: No open PRs matching branch patterns (night-watch/)
+
❯ src/__tests__/scripts/core-flow-smoke.test.ts:2105:25
|
|
src/__tests__/scripts/core-flow-smoke.test.ts > core flow smoke tests (bash scripts) > reviewer worker mode should allow concurrent runs for different target PRs:
packages/cli/src/__tests__/scripts/core-flow-smoke.test.ts#L1651
AssertionError: expected 'NIGHT_WATCH_RESULT:skip_no_open_prs\n' to contain 'NIGHT_WATCH_RESULT:success_reviewed'
- Expected
+ Received
- NIGHT_WATCH_RESULT:success_reviewed
+ NIGHT_WATCH_RESULT:skip_no_open_prs
+
❯ src/__tests__/scripts/core-flow-smoke.test.ts:1651:29
|
|
test
@jonit-dev/night-watch-cli#test: command (/home/runner/work/night-watch-cli/night-watch-cli/packages/cli) /tmp/yarn--1778431616928-0.7984860725796117/yarn run test exited (1)
|
|
core-flow-smoke
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/setup-node@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
test
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/setup-node@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|