[5.4] Proper com_templates error when PHP zip extension is missing (#46716)

Author: brianteeman

administrator/components/com_templates/src/Model/TemplateModel.php

@@ -1781,6 +1781,12 @@ public function getArchive()
             $app  = Factory::getApplication();
             $path = $this->getBasePath() . base64_decode($app->getInput()->get('file'));
 
+            // Check if the ZipArchive class exists
+            if (!class_exists('ZipArchive')) {
+                $app->enqueueMessage(Text::_('COM_TEMPLATES_ERROR_ZIPARCHIVE_NOT_ENABLED'), 'error');
+                return false;
+            }
+
             if (file_exists(Path::clean($path))) {
                 $files = [];
                 $zip   = new \ZipArchive();

administrator/components/com_templates/tmpl/template/default.php

@@ -173,16 +173,18 @@
                     <legend><?php echo Text::_('COM_TEMPLATES_FILE_CONTENT_PREVIEW'); ?></legend>
                     <form action="<?php echo Route::_('index.php?option=com_templates&view=template&id=' . $input->getInt('id') . '&file=' . $this->file . '&isMedia=' . $input->get('isMedia', 0)); ?>" method="post" name="adminForm" id="adminForm">
                         <ul class="nav flex-column well">
-                            <?php foreach ($this->archive as $file) : ?>
-                                <li>
-                                    <?php if (substr($file, -1) === DIRECTORY_SEPARATOR) : ?>
-                                        <span class="icon-folder icon-fw" aria-hidden="true"></span>&nbsp;<?php echo $file; ?>
-                                    <?php endif; ?>
-                                    <?php if (substr($file, -1) != DIRECTORY_SEPARATOR) : ?>
-                                        <span class="icon-file icon-fw" aria-hidden="true"></span>&nbsp;<?php echo $file; ?>
-                                    <?php endif; ?>
-                                </li>
-                            <?php endforeach; ?>
+                            <?php if (!empty($this->archive) && is_array($this->archive)) : ?>
+                                <?php foreach ($this->archive as $file) : ?>
+                                    <li>
+                                        <?php if (substr($file, -1) === DIRECTORY_SEPARATOR) : ?>
+                                            <span class="icon-folder icon-fw" aria-hidden="true"></span>&nbsp;<?php echo $file; ?>
+                                        <?php endif; ?>
+                                        <?php if (substr($file, -1) != DIRECTORY_SEPARATOR) : ?>
+                                            <span class="icon-file icon-fw" aria-hidden="true"></span>&nbsp;<?php echo $file; ?>
+                                        <?php endif; ?>
+                                    </li>
+                                <?php endforeach; ?>
+                            <?php endif; ?>
                         </ul>
                         <input type="hidden" name="task" value="">
                         <?php echo HTMLHelper::_('form.token'); ?>

administrator/language/en-GB/com_templates.ini

@@ -91,6 +91,7 @@ COM_TEMPLATES_ERROR_WARNFILENAME="Invalid file name. Please correct the name of
 COM_TEMPLATES_ERROR_WARNFILETOOLARGE="This file is too large to upload."
 COM_TEMPLATES_ERROR_WARNFILETYPE="File format not supported."
 COM_TEMPLATES_ERROR_WARNIEXSS="Can't be uploaded. Has XSS."
+COM_TEMPLATES_ERROR_ZIPARCHIVE_NOT_ENABLED="The PHP ZipArchive extension is not enabled."
 COM_TEMPLATES_ERR_XML="Template XML data not available"
 COM_TEMPLATES_FIELD_CLIENT_LABEL="Location"
 COM_TEMPLATES_FIELD_HOME_LABEL="Default"