[5.4] Issue on multiple uploads in media manager on fresh install

[dautrich]

What happened?

1. Install a fresh Joomla 5.4
2. Navigate to Media Manager
3. Click on Upload
4. Select multiple images and click Open
5. See what happens!

Here is the video:

Upload_Issue.mp4

In the example, there were seven images selected. Of those two were uploaded. For the five others, error messages show up:

Subsequent uploads work perfectly. In the video, I deleted the two files from the first upload and uploaded the identical set of seven files again. This time successfully.

Version

5.4

Expected result

Multiple selected files are successfully uploaded.

Actual result

Initial upload only partially succeeds, error messages for the rest.

System Information

Laragon 8 on Windows 11
Joomla 5.4.8
PHP 8.4
MySQL 8.0

Additional Comments

No response

[brianteeman]

i cant replicate that and the error message coming from finder doesnt really make sense to me on an image upload. Are you 100% certain its a brand new install with no configuration changes or extensions installed

[dautrich]

@brianteeman It's a fresh installation of 5.4.8 without any extensions or configuration changes.
I'll cross-check with a different browser to rule out issues with my Firefox. I'll report on the outcome here.

[dautrich]

@brianteeman Identical error messages with Microsoft Edge. The issue only happens with a completely fresh install. Maybe some bad initialization?

[brianteeman]

I can confirm the problem on a completely new install

I am guessing but i bet it is because on a clean install the table #__finder_types is empty

But as soon as you do something like create an article then it gets populated with 5 records

Its just that the first thing you did was to upload an image and that record creation borked

I have no idea why that table doesnt ship with data or why/where it gets populated

You can verify this i hope by emptying that table and trying to upload the images
I suspect it will then give you the error
Then try to upload images and it fails
then empty the table again and repeat

[dautrich]

I did a fresh install (again). The table #__finder_types was empty.
I created an article. The table #__finder_types was populated with five records.
Went to media manager, did my multiple upload, and no errors.
Emptied table #__finder_types.
Tried to upload again: No errors.

[brianteeman]

oddly there are three different duplicated places that create the finder_types when empty

joomla-cms/administrator/components/com_finder/src/Indexer/Adapter.php

Lines 153 to 156 in ba60d96

	// Add the content type if it doesn't exist and is set.
	if (empty($this->type_id) && !empty($this->type_title)) {
	$this->type_id = Helper::addContentType($this->type_title, $this->mime);
	}

joomla-cms/administrator/components/com_finder/src/Indexer/DebugAdapter.php

Lines 152 to 155 in ba60d96

	// Add the content type if it doesn't exist and is set.
	if (empty($this->type_id) && !empty($this->type_title)) {
	$this->type_id = Helper::addContentType($this->type_title, $this->mime);
	}

joomla-cms/administrator/components/com_finder/src/Indexer/Helper.php

Lines 250 to 255 in ba60d96

	$query->clear()
	->insert($db->quoteName('#__finder_types'))
	->columns([$db->quoteName('title'), $db->quoteName('mime')])
	->values($db->quote($title) . ', ' . $db->quote($mime ?? ''));
	$db->setQuery($query);
	$db->execute();