Skip to content

Commit f0f65cc

Browse files
author
Joost Kremers
committed
Do not kill notes buffer for one-file-per-note.
Until now, with the setting `one-file-per-note` for `ebib-notes-storage`, every time the entry buffer is updated, the notes buffer is killed. This was mainly to prevent dozens of notes buffers from staying alive in an Emacs session. However, it leads to a problem with the setting `all` for `ebib-notes-show-note-method`, as seen in Github issue #283. We may decide to turn this into a user-configurable option if users are annoyed by the many note buffers staying open.
1 parent e6a88d6 commit f0f65cc

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

ebib.el

+3-6
Original file line numberDiff line numberDiff line change
@@ -699,12 +699,9 @@ not have an associated index buffer, create one and fill it."
699699
MATCH-STR is a regexp that will be highlighted when it occurs in
700700
the field contents."
701701
(when ebib--note-window
702-
(if (window-live-p ebib--note-window)
703-
(let ((buf (window-buffer ebib--note-window)))
704-
(delete-window ebib--note-window)
705-
(if (eq ebib-notes-storage 'one-file-per-note)
706-
(kill-buffer buf))
707-
(setq ebib--needs-update nil))) ; See below.
702+
(when (window-live-p ebib--note-window)
703+
(delete-window ebib--note-window)
704+
(setq ebib--needs-update nil)) ; See below.
708705
(setq ebib--note-window nil))
709706
(with-current-ebib-buffer 'entry
710707
(let ((inhibit-read-only t)

0 commit comments

Comments
 (0)