Add automatic Ice Bar toggle based on screen width threshold

Author: ronilaukkarinen

Ice/Settings/SettingsManagers/GeneralSettingsManager.swift

@@ -3,6 +3,7 @@
 //  Ice
 //
 
+import AppKit
 import Combine
 import Foundation
 
@@ -27,6 +28,14 @@ final class GeneralSettingsManager: ObservableObject {
     /// in a separate bar below the menu bar.
     @Published var useIceBar = false
 
+    /// A Boolean value that indicates whether Ice Bar should be
+    /// automatically enabled on built-in displays.
+    @Published var autoEnableIceBarOnBuiltInDisplay = false
+
+    /// The screen width threshold (in pixels) below which Ice Bar is enabled.
+    /// Ice Bar will be enabled when screen width < threshold.
+    @Published var iceBarDisplayWidthThreshold: Double = 3000
+
     /// The location where the Ice Bar appears.
     @Published var iceBarLocation: IceBarLocation = .dynamic
 
@@ -78,12 +87,16 @@ final class GeneralSettingsManager: ObservableObject {
     func performSetup() {
         loadInitialState()
         configureCancellables()
+        observeScreenChanges()
+        updateIceBarForCurrentDisplay()
     }
 
     private func loadInitialState() {
         Defaults.ifPresent(key: .showIceIcon, assign: &showIceIcon)
         Defaults.ifPresent(key: .customIceIconIsTemplate, assign: &customIceIconIsTemplate)
         Defaults.ifPresent(key: .useIceBar, assign: &useIceBar)
+        Defaults.ifPresent(key: .autoEnableIceBarOnBuiltInDisplay, assign: &autoEnableIceBarOnBuiltInDisplay)
+        Defaults.ifPresent(key: .iceBarDisplayWidthThreshold, assign: &iceBarDisplayWidthThreshold)
         Defaults.ifPresent(key: .showOnClick, assign: &showOnClick)
         Defaults.ifPresent(key: .showOnHover, assign: &showOnHover)
         Defaults.ifPresent(key: .showOnScroll, assign: &showOnScroll)
@@ -156,6 +169,24 @@ final class GeneralSettingsManager: ObservableObject {
             }
             .store(in: &c)
 
+        $autoEnableIceBarOnBuiltInDisplay
+            .receive(on: DispatchQueue.main)
+            .sink { [weak self] autoEnable in
+                Defaults.set(autoEnable, forKey: .autoEnableIceBarOnBuiltInDisplay)
+                if autoEnable {
+                    self?.updateIceBarForCurrentDisplay()
+                }
+            }
+            .store(in: &c)
+
+        $iceBarDisplayWidthThreshold
+            .receive(on: DispatchQueue.main)
+            .sink { [weak self] threshold in
+                Defaults.set(threshold, forKey: .iceBarDisplayWidthThreshold)
+                self?.updateIceBarForCurrentDisplay()
+            }
+            .store(in: &c)
+
         $iceBarLocation
             .receive(on: DispatchQueue.main)
             .sink { location in
@@ -215,6 +246,32 @@ final class GeneralSettingsManager: ObservableObject {
 
         cancellables = c
     }
+
+    /// Updates the Ice Bar setting based on the current display configuration.
+    private func updateIceBarForCurrentDisplay() {
+        guard autoEnableIceBarOnBuiltInDisplay else {
+            return
+        }
+
+        // Get the main screen (where the menu bar is)
+        guard let mainScreen = NSScreen.main else {
+            return
+        }
+
+        // Enable Ice Bar if screen width is less than threshold
+        let screenWidth = mainScreen.frame.width
+        useIceBar = screenWidth < iceBarDisplayWidthThreshold
+    }
+
+    /// Sets up an observer for screen configuration changes.
+    func observeScreenChanges() {
+        NotificationCenter.default.publisher(for: NSApplication.didChangeScreenParametersNotification)
+            .receive(on: DispatchQueue.main)
+            .sink { [weak self] _ in
+                self?.updateIceBarForCurrentDisplay()
+            }
+            .store(in: &cancellables)
+    }
 }
 
 // MARK: GeneralSettingsManager: BindingExposable

Ice/Settings/SettingsPanes/GeneralSettingsPane.swift

@@ -176,6 +176,10 @@ struct GeneralSettingsPane: View {
     @ViewBuilder
     private var iceBarOptions: some View {
         useIceBar
+        autoEnableIceBarToggle
+        if manager.autoEnableIceBarOnBuiltInDisplay {
+            widthThresholdInput
+        }
         if manager.useIceBar {
             iceBarLocationPicker
         }
@@ -185,6 +189,31 @@ struct GeneralSettingsPane: View {
     private var useIceBar: some View {
         Toggle("Use Ice Bar", isOn: manager.bindings.useIceBar)
             .annotation("Show hidden menu bar items in a separate bar below the menu bar")
+            .disabled(manager.autoEnableIceBarOnBuiltInDisplay)
+    }
+
+    @ViewBuilder
+    private var autoEnableIceBarToggle: some View {
+        Toggle(isOn: manager.bindings.autoEnableIceBarOnBuiltInDisplay) {
+            HStack {
+                Text("Auto-enable on narrow displays")
+                BetaBadge()
+            }
+        }
+        .annotation("Automatically enable Ice Bar when screen width is below the threshold")
+    }
+
+    @ViewBuilder
+    private var widthThresholdInput: some View {
+        HStack {
+            Text("Width threshold:")
+            TextField("", value: manager.bindings.iceBarDisplayWidthThreshold, format: .number.grouping(.never))
+                .textFieldStyle(.roundedBorder)
+                .frame(width: 80)
+            Text("pixels")
+                .foregroundStyle(.secondary)
+        }
+        .annotation("Ice Bar will be enabled when screen width is less than this value")
     }
 
     @ViewBuilder

Ice/Utilities/Defaults.swift

@@ -175,6 +175,8 @@ extension Defaults {
 
         case iceBarLocation = "IceBarLocation"
         case iceBarPinnedLocation = "IceBarPinnedLocation"
+        case autoEnableIceBarOnBuiltInDisplay = "AutoEnableIceBarOnBuiltInDisplay"
+        case iceBarDisplayWidthThreshold = "IceBarDisplayWidthThreshold"
 
         // MARK: Migration
 

Ice/Utilities/Extensions.swift

@@ -453,6 +453,11 @@ extension NSScreen {
         )
     }
 
+    /// A Boolean value that indicates whether the screen is a built-in display (laptop screen).
+    var isBuiltIn: Bool {
+        CGDisplayIsBuiltin(displayID) != 0
+    }
+
     /// Returns the height of the menu bar on this screen.
     func getMenuBarHeight() -> CGFloat? {
         let menuBarWindow = WindowInfo.getMenuBarWindow(for: displayID)