Incorrect modmask (when using XSendEvent on v4.20251130.1)

[vaplv]

Since validation 15fc2fc, the modmask member variable of the charcodemap structure is not correctly defined when filling the charcodes array, at least for the Control key, which remains at 0, whereas it was correctly defined as 4 in the previous validation. Sending a key sequence such as “ctrl+t” therefore no longer works.

[jordansissel]

I tested the previous release and current release and found this affects keys sent with XSendEvent, but XTEST still works correctly.

Testing with 'xdotool key ctrl+l' and using --window ... to cause xdotool to use XSendEvent or not, xev shows:

% xev -1 -event keyboard | fex ',/synthetic|state|keycode|)$/'

# xdotool key ctrl+l
 synthetic NO, state 0x0, keycode 37 (keysym 0xffe3, Control_L)
 synthetic NO, state 0x4, keycode 46 (keysym 0x6c, l)
 synthetic NO, state 0x4, keycode 37 (keysym 0xffe3, Control_L)
 synthetic NO, state 0x0, keycode 46 (keysym 0x6c, l)

# xdotool key --window 0x1000001 ctrl+l
 synthetic YES, state 0x0, keycode 37 (keysym 0xffe3, Control_L)
 synthetic YES, state 0x0, keycode 46 (keysym 0x6c, l)
 synthetic YES, state 0x0, keycode 37 (keysym 0xffe3, Control_L)
 synthetic YES, state 0x0, keycode 46 (keysym 0x6c, l)

Above, where xev reports "synthetic YES" is when xdotool uses XSendEvent.

While the Control_L key (on my system) is held, state should be 0x4, as you note, but it is not.

This issue also identifies a gap in the test suite where this particular case is not tested.

[jordansissel]

checking the code, this is because an internal function was removed - _xdo_query_keycode_to_modifier in 15fc2fc.

This could be restored, or, switching to use xkb_state_... functions to track what modifier mask is active for a given set of key codes.

Thanks for finding and reporting this bug :)

[jordansissel]

As described above, I restored the deleted function as the shortest way to resolve this.

I did some manual testing to make sure #491 remains fixed, and the test suite passes.

synthetic YES,1),1), state 0x4, keycode 37 (keysym 0xffe3, Control_L)
 synthetic YES,1),1), state 0x4, keycode 46 (keysym 0x6c, l)
 synthetic YES,1),1), state 0x4, keycode 37 (keysym 0xffe3, Control_L)
 synthetic YES,1),1), state 0x0, keycode 46 (keysym 0x6c, l)

^^ the 'state' flag is set.

There may be still a few bugs, like Control_L should set the mask after it's sent, but I don't know if the above behavior will cause problems.

[jordansissel]

#505 should resolve this

[jordansissel]

#505 merged! Hopefully this resolves this issue.