Binance exchange support for Bitcoin-DCA (#53)

* add interface implementations for binance

* add tests for 3 services

* created unit test for BinanceClient

* fixing some code smells

* fixing some code smells

* also test for hash

* resolved some code smells in the unit test

* fixed a code smell and rearranged assertions

* fixed a code smell and rearranged assertions

* creates documentation for the binance api connection

Author: jorijn

.env.dist

@@ -12,13 +12,14 @@ WITHDRAW_ADDRESS=
 # WITHDRAW_XPUB=
 
 # Choose the cryptocurrency exchange this Bitcoin DCA tool will operate on. The default value is "bl3p".
-# Available options: bl3p, bitvavo, kraken
+# Available options: bl3p, bitvavo, kraken, binance
 EXCHANGE=bl3p
 
 # This setting is for the base currency you're buying in. Options are:
 # BL3P:     EUR
 # Bitvavo:  EUR
 # Kraken:   USD EUR CAD JPY GBP CHF AUD
+# Binance:  USDT BUSD EUR USDC USDT GBP AUD TRY BRL DAI TUSD RUB UAH PAX BIDR NGN IDRT VAI
 BASE_CURRENCY=EUR
 
 ##################################################################################
@@ -82,3 +83,13 @@ BL3P_PRIVATE_KEY=
 # See https://support.kraken.com/hc/en-us/articles/360036157952
 #
 # KRAKEN_TRADING_AGREEMENT=agree
+
+##################################################################################
+# Binance exchange settings
+##################################################################################
+
+# This is the identifying part of the API key that you created on the Binance exchange.
+# BINANCE_API_KEY=
+
+# This is the private part of your API connection to Binance. It’s a secret granting access to your Binance account.
+# BINANCE_API_SECRET=

README.md

@@ -2,7 +2,7 @@
   <img src="/resources/images/logo.png?raw=true" alt="Bitcoin DCA Logo">
 </p>
 
-# Automated Bitcoin DCA tool for multiple Exchanges
+# Automated self-hosted Bitcoin DCA tool for multiple Exchanges
 
 ![Docker Pulls](https://img.shields.io/docker/pulls/jorijn/bitcoin-dca)
 [![Quality Gate Status](https://sonarcloud.io/api/project_badges/measure?project=Jorijn_bitcoin-dca&metric=alert_status)](https://sonarcloud.io/dashboard?id=Jorijn_bitcoin-dca)
@@ -19,14 +19,15 @@
 ## Supported Exchanges
 | Exchange | URL | Currencies | XPUB withdraw supported |
 |------|------|------|------|
-| BL3P | https://bl3p.eu/ | EUR | No * |
+| BL3P | https://bl3p.eu/ | EUR | Yes |
 | Bitvavo | https://bitvavo.com/ | EUR | No * |
 | Kraken | https://kraken.com/ | USD EUR CAD JPY GBP CHF AUD | No |
+| Binance | https://binance.com/ | USDT BUSD EUR USDC USDT GBP AUD TRY BRL DAI TUSD RUB UAH PAX BIDR NGN IDRT VAI | Yes |
 
-\* Due to regulatory changes in The Netherlands, BL3P and Bitvavo currently require you to provide proof of address ownership, thus temporarily disabling Bitcoin-DCA's XPUB feature.
+\* Due to regulatory changes in The Netherlands, Bitvavo currently requires you to provide proof of address ownership, thus temporarily disabling Bitcoin-DCA's XPUB feature.
 
 ## About this software
-The DCA tool is built with flexibility in mind, allowing you to specify your own schedule of buying and withdrawing. A few examples that are possible:
+The DCA tool is built with flexibility in mind, allowing you to specify your schedule of buying and withdrawing. A few examples that are possible:
 
 * Buy each week, never withdraw.
 * Buy monthly and withdraw at the same time to reduce exchange risk.
@@ -46,4 +47,4 @@ You can visit the Bitcoin DCA Support channel on Telegram: https://t.me/bitcoind
 ## Contributing
 Contributions are highly welcome! Feel free to submit issues and pull requests on https://github.com/jorijn/bitcoin-dca.
 
-Like my work? Buy me a 🍺 by sending some sats on https://jorijn.com/donate/
+Like my work? Please buy me a 🍺 by sending some sats on https://jorijn.com/donate/

composer.json

@@ -1,6 +1,6 @@
 {
     "name": "jorijn/bitcoin-dca",
-    "description": "Tool for automatically buying and withdrawing Bitcoin on Bl3P",
+    "description": "Tool for automatically buying and withdrawing Bitcoin",
     "type": "project",
     "license": "MIT",
     "authors": [
@@ -38,7 +38,6 @@
         "test": "vendor/bin/phpunit --testdox"
     },
     "require-dev": {
-        "roave/security-advisories": "dev-master",
         "friendsofphp/php-cs-fixer": "^2.16",
         "phpunit/phpunit": "^9.1"
     }