Skip to content

Commit 78c3af2

Browse files
committed
adjust notarize
1 parent 5e7e5f2 commit 78c3af2

File tree

2 files changed

+16
-17
lines changed

2 files changed

+16
-17
lines changed

Diff for: .github/workflows/build.yml

+16-14
Original file line numberDiff line numberDiff line change
@@ -26,29 +26,31 @@ jobs:
2626
- name: Import Apple Developer Certificate (macOS only)
2727
if: matrix.os == 'macos-latest'
2828
env:
29-
DEVELOPER_ID_CERT: ${{ secrets.DEVELOPER_ID_CERT }}
30-
DEVELOPER_ID_CERT_PASSWORD: ${{ secrets.DEVELOPER_ID_CERT_PASSWORD }}
31-
CSC_NAME: ${{ secrets.CSC_NAME }}
29+
DEVELOPER_ID_CERT: ${{ secrets.DEVELOPER_ID_CERT }}
30+
DEVELOPER_ID_CERT_PASSWORD: ${{ secrets.DEVELOPER_ID_CERT_PASSWORD }}
31+
CSC_NAME: ${{ secrets.CSC_NAME }}
3232
run: |
33-
echo "$DEVELOPER_ID_CERT" | base64 --decode > developer_id_certificate.p12
34-
security create-keychain -p "" build.keychain
35-
security default-keychain -s build.keychain
36-
security unlock-keychain -p "" build.keychain
37-
security import developer_id_certificate.p12 -k build.keychain -P "$DEVELOPER_ID_CERT_PASSWORD" -T /usr/bin/codesign
38-
security set-key-partition-list -S apple-tool:,apple:,codesign: -s -k "" build.keychain
33+
echo "$DEVELOPER_ID_CERT" | base64 --decode > developer_id_certificate.p12
34+
security create-keychain -p "" build.keychain
35+
security default-keychain -s build.keychain
36+
security unlock-keychain -p "" build.keychain
37+
security import developer_id_certificate.p12 -k build.keychain -P "$DEVELOPER_ID_CERT_PASSWORD" -T /usr/bin/codesign
38+
security set-key-partition-list -S apple-tool:,apple:,codesign: -s -k "" build.keychain
3939
4040
- name: List Certificates in Keychain (macOS only)
4141
if: matrix.os == 'macos-latest'
4242
run: |
43-
security find-identity -v -p codesigning
43+
security find-identity -v -p codesigning
4444
4545
- name: Build and Release
4646
uses: samuelmeuli/[email protected]
4747
with:
4848
github_token: ${{ secrets.GITHUB_TOKEN }}
4949
release: true
5050
env:
51-
DEBUG: electron-notarize
52-
APPLE_ID: ${{ secrets.APPLE_ID }}
53-
APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_ID_PASSWORD }}
54-
CSC_NAME: ${{ secrets.CSC_NAME }}
51+
DEBUG: electron-notarize*
52+
APPLE_ID: ${{ secrets.APPLE_ID }}
53+
APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_ID_PASSWORD }}
54+
APPLE_ID_PASSWORD: ${{ secrets.APPLE_ID_PASSWORD }}
55+
APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
56+
CSC_NAME: ${{ secrets.CSC_NAME }}

Diff for: package.json

-3
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,6 @@
3737
"NSApplicationSupportsSecureRestorableState": true,
3838
"electronTeamId": "R2PY2DC3A4"
3939
},
40-
"notarize": {
41-
"teamId": "R2PY2DC3A4"
42-
},
4340
"hardenedRuntime": true,
4441
"gatekeeperAssess": true,
4542
"entitlements": "entitlements.mac.plist",

0 commit comments

Comments
 (0)