Merge pull request erlang#11390 from lucioleKi/isabell/compiler/fix/erlangGH-11366/OTP-20267

compiler: Fix binding error in comprehensions with `compr_assign`

Author: lucioleKi

lib/compiler/src/v3_core.erl

@@ -2386,8 +2386,9 @@ get_qual_anno(Abstract) -> element(2, Abstract).
 %% generator(Line, Generator, Guard, State) -> {Generator',State}.
 %%  Transform a given generator into its #igen{} representation.
 
-generator(Line, {match,L,P,E}, Gs, StrictPats, St0) ->
-    generator(Line, {generate_strict,L,P,{cons,L,E,{nil,L}}}, Gs, StrictPats, St0);
+generator(Line, {match,L,P0,E0}, Gs, StrictPats, St0) ->
+    {P1, E1} = rewrite_compr_assign(P0, E0),
+    generator(Line, {generate_strict,L,P1,{cons,L,E1,{nil,L}}}, Gs, StrictPats, St0);
 generator(Line, {Generate,Lg,P0,E}, Gs, StrictPats, St0)
   when Generate =:= generate;
        Generate =:= generate_strict ->
@@ -2664,6 +2665,11 @@ list_gen_pattern(P0, Line, St) ->
 	nomatch -> {nomatch,add_warning(Line, {nomatch,pattern}, St)}
     end.
 
+rewrite_compr_assign(P1, {match,L2,P2,E}) ->
+    rewrite_compr_assign({match,L2,P1,P2}, E);
+rewrite_compr_assign(P, E) ->
+    {P, E}.
+
 %% is_guard_test(Expression) -> true | false.
 %%  Test if a general expression is a guard test.
 %%

lib/compiler/test/lc_SUITE.erl

@@ -333,6 +333,7 @@ assignment_generator(_Config) ->
     ?assertEqual(singleton_generator_6(Seq),
                  assignment_generator_6(Seq)),
 
+    [ok] = [ok || X = V = true, V, X],
     ok.
 
 assignment_generator_1(L) ->