fix: make testing non-negotiable, remove per-intent testing config

Testing is always required — not a per-intent preference. Asking users
whether they want tests is like asking if they want a seatbelt.

- Remove Phase 5.5 (testing requirements questions) from elaborate
- Remove testing: frontmatter from intent.md template
- Reviewer unconditionally requires tests for all new code
- Remove conditional testing requirements table from subagent context
- Remove coverage gate config from settings template
- Delete PLAN.md and enforce-testing-gates.sh (wrong layer — mechanical
  coverage enforcement belongs in han backpressure hooks, not AI-DLC)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: jwaldrip

plugin/hats/reviewer.md

@@ -31,14 +31,13 @@ The Reviewer verifies that the Builder's implementation satisfies the Unit's Com
 
 ## Steps
 
-1. Check testing requirements
-   - Read testing requirements from `.ai-dlc/{intent-slug}/intent.md` frontmatter
-   - If testing requirements are configured, verify each:
-     - **Unit tests**: If `unit_tests: true`, verify unit tests exist for new/modified code
-     - **Integration tests**: If `integration_tests: true`, verify integration tests exist
-     - **Coverage**: If `coverage_threshold` is set, run coverage and verify it meets the threshold
-     - **E2E tests**: If `e2e_tests: true`, verify E2E tests pass
-   - **Validation**: All required testing criteria are met
+1. Verify test coverage
+   - You MUST verify that unit tests exist for all new and modified code
+   - You MUST run the full test suite and confirm all tests pass
+   - You MUST check that tests are meaningful (not just asserting `true`)
+   - You MUST identify untested code paths and flag them
+   - You SHOULD verify integration tests exist for component boundaries
+   - **Validation**: All new code has corresponding tests, all tests pass
 
 2. Verify criteria satisfaction
    - You MUST check each Completion Criterion individually
@@ -69,11 +68,11 @@ The Reviewer verifies that the Builder's implementation satisfies the Unit's Com
    - **Validation**: Feedback is actionable
 
 6. Make decision
-   - If all criteria pass, testing requirements met, and quality acceptable: APPROVE
-   - If criteria fail, testing requirements unmet, or blocking issues: REQUEST CHANGES
+   - If all criteria pass, tests pass, and quality acceptable: APPROVE
+   - If criteria fail, tests missing, or blocking issues: REQUEST CHANGES
    - You MUST document decision clearly
    - You MUST NOT approve if criteria are not met
-   - You MUST NOT approve if configured testing requirements are not satisfied
+   - You MUST NOT approve if new code lacks tests
    - **Validation**: Clear approve/reject with rationale
 
 #### Provider Sync — Review Outcome
@@ -86,51 +85,15 @@ The Reviewer verifies that the Builder's implementation satisfies the Unit's Com
 
 ## Success Criteria
 
-- [ ] Testing requirements checked (if configured in intent.md)
+- [ ] All new code has corresponding tests
+- [ ] All tests pass
 - [ ] All Completion Criteria verified (pass/fail for each)
 - [ ] Code quality issues documented
 - [ ] Edge cases and error handling reviewed
 - [ ] Security considerations checked
 - [ ] Clear decision: APPROVE or REQUEST CHANGES
 - [ ] Actionable feedback provided if changes requested
 
-## Testing Verification Details
-
-When verifying testing requirements from `intent.md`:
-
-### Reading the Configuration
-
-```bash
-INTENT_SLUG=$(han keep load --branch main intent-slug --quiet 2>/dev/null || echo "")
-INTENT_DIR=".ai-dlc/${INTENT_SLUG}"
-TESTING_CONFIG=$(han parse yaml testing --json < "$INTENT_DIR/intent.md" 2>/dev/null || echo "{}")
-```
-
-### Unit Tests (when `unit_tests: true`)
-
-1. Identify new/modified source files from the unit's changes
-2. Check for corresponding test files (e.g., `*.test.ts`, `*.spec.ts`, `*_test.go`)
-3. Run the test suite and verify tests pass
-4. **FAIL if**: New code has no corresponding unit tests
-
-### Integration Tests (when `integration_tests: true`)
-
-1. Check for integration test files in the project
-2. Run integration test suite
-3. **FAIL if**: No integration tests exist for affected components
-
-### Coverage (when `coverage_threshold` is set)
-
-1. Run test coverage tool (e.g., `npm run test:coverage`, `go test -cover`)
-2. Compare coverage percentage against threshold
-3. **FAIL if**: Coverage is below the configured threshold
-
-### E2E Tests (when `e2e_tests: true`)
-
-1. Run E2E test suite (e.g., Playwright, Cypress)
-2. Verify all E2E tests pass
-3. **FAIL if**: E2E tests fail or are missing for affected user flows
-
 ## Error Handling
 
 ### Error: Cannot Verify Criterion Programmatically

plugin/hooks/subagent-context.sh

@@ -116,35 +116,6 @@ if [ -f "${INTENT_DIR}/completion-criteria.md" ]; then
   echo ""
 fi
 
-# Display testing requirements if configured (stored in intent.md frontmatter)
-if [ -f "$INTENT_FILE" ]; then
-  TESTING_JSON=$(han parse yaml testing --json < "$INTENT_FILE" 2>/dev/null || echo "")
-  if [ -n "$TESTING_JSON" ] && [ "$TESTING_JSON" != "null" ] && [ "$TESTING_JSON" != "{}" ]; then
-    echo "### Testing Requirements"
-    echo ""
-
-    # Parse individual fields
-    UNIT_TESTS=$(echo "$TESTING_JSON" | han parse json unit_tests -r --default "" 2>/dev/null || echo "")
-    INTEGRATION_TESTS=$(echo "$TESTING_JSON" | han parse json integration_tests -r --default "" 2>/dev/null || echo "")
-    COVERAGE=$(echo "$TESTING_JSON" | han parse json coverage_threshold -r --default "" 2>/dev/null || echo "")
-    E2E_TESTS=$(echo "$TESTING_JSON" | han parse json e2e_tests -r --default "" 2>/dev/null || echo "")
-
-    echo "| Requirement | Status |"
-    echo "|-------------|--------|"
-    [ "$UNIT_TESTS" = "true" ] && echo "| Unit Tests | Required |"
-    [ "$UNIT_TESTS" = "false" ] && echo "| Unit Tests | Optional |"
-    [ "$INTEGRATION_TESTS" = "true" ] && echo "| Integration Tests | Required |"
-    [ "$INTEGRATION_TESTS" = "false" ] && echo "| Integration Tests | Optional |"
-    if [ -n "$COVERAGE" ] && [ "$COVERAGE" != "null" ]; then
-      echo "| Coverage Threshold | ${COVERAGE}% |"
-    else
-      echo "| Coverage Threshold | None |"
-    fi
-    [ "$E2E_TESTS" = "true" ] && echo "| E2E Tests | Required |"
-    [ "$E2E_TESTS" = "false" ] && echo "| E2E Tests | Optional |"
-    echo ""
-  fi
-fi
 
 # Source DAG library if available
 DAG_LIB="${CLAUDE_PLUGIN_ROOT}/lib/dag.sh"

plugin/skills/elaborate/SKILL.md

@@ -502,59 +502,6 @@ Present the full unit breakdown to the user and confirm before proceeding.
 
 ---
 
-## Phase 5.5: Define Testing Requirements
-
-Ask the user about testing expectations for this intent:
-
-```json
-{
-  "questions": [
-    {
-      "question": "What testing requirements should we enforce for this intent?",
-      "header": "Unit Tests",
-      "options": [
-        {"label": "Required", "description": "New code must have unit tests"},
-        {"label": "Not required", "description": "Unit tests are optional"}
-      ],
-      "multiSelect": false
-    },
-    {
-      "question": "Integration tests?",
-      "header": "Integration Tests",
-      "options": [
-        {"label": "Required", "description": "Integration tests must verify component interactions"},
-        {"label": "Not required", "description": "Integration tests are optional"}
-      ],
-      "multiSelect": false
-    },
-    {
-      "question": "Coverage threshold?",
-      "header": "Coverage",
-      "options": [
-        {"label": "80%", "description": "Minimum 80% code coverage"},
-        {"label": "70%", "description": "Minimum 70% code coverage"},
-        {"label": "60%", "description": "Minimum 60% code coverage"},
-        {"label": "None", "description": "No coverage requirement"}
-      ],
-      "multiSelect": false
-    },
-    {
-      "question": "End-to-end tests?",
-      "header": "E2E Tests",
-      "options": [
-        {"label": "Required", "description": "E2E tests must pass"},
-        {"label": "Not required", "description": "E2E tests are optional"}
-      ],
-      "multiSelect": false
-    }
-  ]
-}
-```
-
-Store the testing configuration for the reviewer hat to enforce.
-
----
-
 ## Phase 5.75: Spec Validation Gate
 
 **This is the quality gate that prevents shallow specs from reaching construction.**
@@ -581,9 +528,6 @@ For each unit:
   - Builds: {specific components/modules/endpoints}
   - Criteria: {count} success criteria
 
-### Testing Requirements
-{Summary of testing config}
-
 ### Workflow & Mode
 {workflow name} — {mode}
 ```
@@ -697,11 +641,6 @@ git:
   change_strategy: {unit|intent|trunk|bolt}
   auto_merge: {true|false}
   auto_squash: false
-testing:
-  unit_tests: true          # true = required, false = optional
-  integration_tests: false  # true = required, false = optional
-  coverage_threshold: 80    # percentage (0-100), or null for no requirement
-  e2e_tests: false          # true = required, false = optional
 created: {ISO date}
 status: active
 epic: ""  # Ticketing provider epic key (auto-populated if ticketing provider configured)
@@ -743,15 +682,6 @@ problem space.}
 {Relevant background, constraints, decisions made during elaboration}
 ```
 
-**Testing frontmatter schema:**
-
-| Field | Type | Description |
-|-------|------|-------------|
-| `testing.unit_tests` | boolean | Whether unit tests are required for new code |
-| `testing.integration_tests` | boolean | Whether integration tests are required |
-| `testing.coverage_threshold` | number or null | Minimum coverage percentage, or null if no requirement |
-| `testing.e2e_tests` | boolean | Whether E2E tests must pass |
-
 ### 3. Write `unit-NN-{slug}.md` for each unit:
 ```markdown
 ---
@@ -876,7 +806,7 @@ Intent Worktree: /tmp/ai-dlc-{intent-slug}/
 Branch: ai-dlc/{intent-slug}/main
 
 Created: .ai-dlc/{intent-slug}/
-- intent.md (intent, config, and testing requirements)
+- intent.md (intent and config)
 - unit-01-{name}.md
 - unit-02-{name}.md
 ...

website/public/templates/settings-template.yml

@@ -39,10 +39,6 @@ quality_gates:
   test: "npm test"                    # or "bun test", "pytest", etc.
   typecheck: "tsc --noEmit"           # TypeScript check
   lint: "biome check"                 # or "eslint .", "ruff check", etc.
-  # coverage: "npm run coverage"      # Optional: coverage check
-
-# Minimum test coverage percentage (if coverage gate enabled)
-# min_coverage: 80
 
 # =============================================================================
 # Unit Configuration