Skip to content

Commit c760c34

Browse files
authored
Merge pull request TheBushidoCollective#20 from TheBushidoCollective/hampton/design-criteria-guidance
feat(elaborate): add design-focused success criteria guidance
2 parents 1535c65 + d760163 commit c760c34

File tree

1 file changed

+32
-0
lines changed

1 file changed

+32
-0
lines changed

plugin/skills/elaborate/SKILL.md

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -546,6 +546,38 @@ Bad:
546546
- [ ] API works well
547547
```
548548

549+
### Design-Focused Criteria
550+
551+
The examples above are **developer-focused** — they verify behavior through automated tests. **Design units** need a different kind of criteria: ones verified by **visual approval** (a human reviews and approves) rather than automated test suites.
552+
553+
Design criteria should be **verifiable by inspection** — the reviewer can check them by reading the spec or reviewing the artifact. They cover responsive coverage, interactive states, accessibility, and design system alignment.
554+
555+
Good (design):
556+
```
557+
- [ ] Screen layouts defined for all breakpoints (mobile 375px / tablet 768px / desktop 1280px)
558+
- [ ] All interactive states specified (default, hover, focus, active, disabled, error)
559+
- [ ] Color usage references only design system tokens — no raw hex values
560+
- [ ] Touch targets meet 44px minimum on mobile breakpoints
561+
- [ ] Empty states, loading states, and error states designed
562+
- [ ] Contrast ratios meet WCAG AA (4.5:1 body text, 3:1 large text)
563+
- [ ] Focus order documented for keyboard navigation
564+
- [ ] Component hierarchy documented (which design system components to use/extend)
565+
- [ ] Interaction specs complete for all user actions (tap, swipe, scroll, transition)
566+
```
567+
568+
Bad (design):
569+
```
570+
- [ ] Design looks good
571+
- [ ] It's responsive
572+
- [ ] Accessible
573+
```
574+
575+
**When writing design criteria, keep these principles in mind:**
576+
- Design criteria are verified by **visual approval**, not automated tests — a reviewer inspects the deliverable against the criteria.
577+
- Include **explicit responsive breakpoint requirements**. "Responsive" alone is meaningless — name the breakpoints and viewport widths.
578+
- **Always include accessibility criteria** for design units: contrast ratios, focus order, touch target sizing, screen reader annotations.
579+
- Design criteria and dev criteria can coexist on the same intent — design units get design criteria, implementation units get dev criteria.
580+
549581
### Non-Functional Requirements
550582

551583
Before confirming criteria, explicitly ask the user about non-functional dimensions using `AskUserQuestion`. Select the dimensions relevant to this intent:

0 commit comments

Comments
 (0)