breaking: update contract_address column type and insert_bulk API
#301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
September 1, 2025 12:16
…ible in favor of `insert_bulk`
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This reverts commit fd79030.
joshstevens19
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Made Postgres methods bulk_insert_via_copy and bulk_insert_via_query internal to the crate now, with insert_bulk being the public API for bulk inserts
Updated all playground indexer files to use insert_bulk instead of directly calling internal methods:
erc_20_filter.rs
playground_types_filter.rs
rocket_pool_eth.rs
uniswap_v3_pool_filter.rs
Updated no_code.rs to use insert_bulk instead of manual size-based logic
Code generators: Updated template generation in events_bindings.rs and trace_bindings.rs to generate code using insert_bulk
Cleaned up some error messages based on the changes above
Added sanity check so that insert_bulk Uses COPY method if rows > 100 OR total_params > 65535 (which is the Postgres limit for maximum params)
Updated contract_address generated column to be char(42)
Updated indexed_filters slice to contain 3 items
Updated generated examples to reflect latest code
Removed playground_types from rust_playground project as they were unused in rindexer.yaml