chore: fix warnings

Author: joshstevens19

.github/workflows/ci.yml

@@ -161,7 +161,12 @@ jobs:
         run: |
           set -eo pipefail
           target="${{ matrix.target }}"
-          
+          flags=()
+
+          if [[ "$target" != *msvc* && "$target" != "aarch64-unknown-linux-gnu" ]]; then
+            flags+=(--features jemalloc)
+          fi
+
           [[ "$target" == *windows* ]] && exe=".exe"
 
           if [[ "$target" == *windows* ]]; then
@@ -171,9 +176,9 @@ jobs:
           fi
 
           if [[ "${{ env.BUILD_TYPE }}" == "release" ]]; then
-            RUST_BACKTRACE=1 CMAKE_TOOLCHAIN_FILE="$CMAKE_TOOLCHAIN_FILE" cargo build --release --target "$target" -vv
+            RUST_BACKTRACE=1 CMAKE_TOOLCHAIN_FILE="$CMAKE_TOOLCHAIN_FILE" cargo build --release --target "$target" "${flags[@]}" -vv
           else
-            RUST_BACKTRACE=1 CMAKE_TOOLCHAIN_FILE="$CMAKE_TOOLCHAIN_FILE" cargo build --target "$target" -vv
+            RUST_BACKTRACE=1 CMAKE_TOOLCHAIN_FILE="$CMAKE_TOOLCHAIN_FILE" cargo build --target "$target" "${flags[@]}" -vv
           fi
 
       - name: Smoke Test
@@ -603,8 +608,6 @@ jobs:
           
           if [[ "$target" != *msvc* && "$target" != "aarch64-unknown-linux-gnu" ]]; then
             flags+=(--features jemalloc)
-          else
-            flags+=(--features reth)
           fi
 
           if [[ "$target" == *windows* ]]; then

Cargo.toml

@@ -15,3 +15,14 @@ anyhow = "1.0.98"
 alloy = { version = "1.0.36", features = ["full", "signer-mnemonic", "signer-keystore", "eips", "eip712"] }
 alloy-rlp = "0.3.12"
 alloy-eips = "1.0.36"
+
+[profile.release]
+lto = "fat"
+codegen-units = 1
+incremental = false
+
+[profile.maxperf]
+inherits = "release"
+lto = "fat"
+codegen-units = 1
+incremental = false

crates/cli/Cargo.toml

@@ -32,11 +32,5 @@ tikv-jemalloc-ctl = { version = "0.6.0", optional = true }
 tikv-jemallocator = { version = "0.6.0", optional = true }
 rand = "0.8.5"
 
-
-[profile.release]
-lto = "fat"
-codegen-units = 1
-incremental = false
-
 [features]
 jemalloc = ["dep:tikv-jemallocator", "dep:tikv-jemalloc-ctl"]

crates/cli/Makefile

@@ -44,7 +44,6 @@ config_pause:
 	cargo run -- config --path $(CURDIR)/../../playground/example pause --relayer-id 7ed18611-1739-4a5f-99e3-e70356029984
 config_unpause:
 	cargo run -- config --path $(CURDIR)/../../playground/example unpause --relayer-id 7ed18611-1739-4a5f-99e3-e70356029984
-# TODO: How to set back to EIP-1559
 config_gas_latest:
 	cargo run -- config --path $(CURDIR)/../../playground/example gas --relayer-id 7ed18611-1739-4a5f-99e3-e70356029984 latest
 config_gas_legacy:

crates/core/Cargo.toml

@@ -49,9 +49,3 @@ hmac = "0.12"
 sha2 = "0.10"
 p256 = { version = "0.13", features = ["ecdsa"] }
 tower = "0.5.2"
-
-[profile.maxperf]
-inherits = "release"
-lto = "fat"
-codegen-units = 1
-incremental = false

crates/core/src/authentication/basic_auth.rs

@@ -80,6 +80,7 @@ impl BasicAuthCredentials {
 
 /// Authenticated marker - just indicates that basic auth passed
 #[derive(Debug)]
+#[allow(dead_code)]
 pub struct Authenticated;
 
 /// Basic auth extractor that validates server-wide credentials

crates/core/src/logger.rs

@@ -93,10 +93,12 @@ pub fn setup_info_logger() {
     setup_logger(LevelFilter::INFO);
 }
 
+#[allow(dead_code)]
 pub fn mark_shutdown_started() {
     SHUTDOWN_IN_PROGRESS.store(true, Ordering::Relaxed);
 }
 
+#[allow(dead_code)]
 pub struct LoggerGuard;
 
 impl Drop for LoggerGuard {

crates/core/src/middleware/authenticated.rs

@@ -17,6 +17,7 @@ use tracing::error;
 /// }
 /// ```
 #[derive(Clone)]
+#[allow(dead_code)]
 pub struct Authenticated;
 
 #[async_trait]

crates/core/src/rate_limiting/detection.rs

@@ -1,9 +1,7 @@
 use crate::common_types::EvmAddress;
 use axum::http::HeaderMap;
 
-use super::types::{
-    RateLimitDetectContext, RateLimitDetectMethod, RateLimitError, TransactionType,
-};
+use super::types::{RateLimitDetectContext, RateLimitError};
 
 pub const RATE_LIMIT_HEADER_NAME: &str = "x-rrelayer-rate-limit-key";
 
@@ -24,57 +22,13 @@ impl RateLimitDetector {
         if let Some(header_value) =
             headers.get(RATE_LIMIT_HEADER_NAME).and_then(|v| v.to_str().ok())
         {
-            return Ok(RateLimitDetectContext {
-                key: header_value.to_string(),
-                detection_method: RateLimitDetectMethod::Header,
-                transaction_type: TransactionType::Direct,
-            });
+            return Ok(RateLimitDetectContext { key: header_value.to_string() });
         }
 
         if self.fallback_to_relayer {
-            return Ok(RateLimitDetectContext {
-                key: relayer_address.hex(),
-                detection_method: RateLimitDetectMethod::Fallback,
-                transaction_type: TransactionType::Direct,
-            });
+            return Ok(RateLimitDetectContext { key: relayer_address.hex() });
         }
 
         Err(RateLimitError::NoRateLimitKey)
     }
 }
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-    use axum::http::HeaderMap;
-    use std::str::FromStr;
-
-    #[test]
-    fn test_header_detection() {
-        let detector = RateLimitDetector::new(false);
-
-        let mut headers = HeaderMap::new();
-        headers.insert("x-rrelayer-rate-limit-key", "user-123".parse().unwrap());
-
-        let relayer_address =
-            EvmAddress::from_str("0x742d35Cc6aF6C5C8c3C4B4C8e1A36F1c57F1b8Ff").unwrap();
-        let result = detector.detect(&headers, &relayer_address).unwrap();
-
-        assert_eq!(result.key, "user-123");
-        assert!(matches!(result.detection_method, RateLimitDetectMethod::Header));
-    }
-
-    #[test]
-    fn test_fallback_detection() {
-        let detector = RateLimitDetector::new(true);
-
-        let headers = HeaderMap::new();
-        let relayer_address =
-            EvmAddress::from_str("0x1234567890123456789012345678901234567890").unwrap();
-
-        let result = detector.detect(&headers, &relayer_address).unwrap();
-
-        assert_eq!(result.key, format!("{:?}", relayer_address));
-        assert!(matches!(result.detection_method, RateLimitDetectMethod::Fallback));
-    }
-}

crates/core/src/rate_limiting/rate_limiter.rs

@@ -1,6 +1,6 @@
 use super::{
     detection::RateLimitDetector,
-    types::{RateLimitDetectContext, RateLimitError, RateLimitOperation, RateLimitResult},
+    types::{RateLimitError, RateLimitOperation, RateLimitResult},
 };
 use crate::app_state::AppState;
 use crate::relayer::get_relayer;
@@ -165,7 +165,6 @@ impl RateLimiter {
             rate_limiter: self,
             user_key: user_key.clone(),
             operation,
-            context,
             relayer_address: *relayer_address,
             reserved: true,
         })
@@ -499,7 +498,6 @@ pub struct RateLimitReservation<'a> {
     rate_limiter: &'a RateLimiter,
     user_key: String,
     operation: RateLimitOperation,
-    context: RateLimitDetectContext,
     relayer_address: EvmAddress,
     reserved: bool,
 }