-
Notifications
You must be signed in to change notification settings - Fork 15
fix: alloy integration #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@Peponks9 is attempting to deploy a commit to the joshaavecom's projects Team on Vercel. A member of the Team first needs to authorize it. |
Peponks9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, wondering if would make sense to change https://github.com/joshstevens19/rrelayer/blob/master/crates/sdk/src/alloy_integration.rs#L294 from u64 to since U256 to match alloy's?
Yes match it all that snippet from generated so feel free to replace anything which doesn’t match |
Peponks9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes to U256 type done
|
@Peponks9 are you happy with this now - we also have :::warning This may change over the next few days when its tested out properly. ::: left up we should clear and we happy with how alloy suggests to integrate etc and all examples in it you have tested in playground and work? |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
convert_transaction_requestto properly handleTxKind::Call(extract address) andTxKind::Create(return error), replacing previous. method.Docs
Alloydependency to version 1.0.36 and added signer-keystore feature in the installation example.Closes #21