Move log directory creation logic to djls-conf function

- Changed LOG_DIR static back to log_dir() function returning Result
- Moved directory creation logic from djls-server to djls-conf
- Updated init_tracing to return Result and use log_dir()?
- Added proper error handling with anyhow::Context
- Added comprehensive documentation with Errors and Panics sections
- Added test to verify directory creation

Co-authored-by: joshuadavidthomas <19896267+joshuadavidthomas@users.noreply.github.com>

Author: Copilot

crates/djls-conf/src/lib.rs

@@ -2,8 +2,8 @@ pub mod tagspecs;
 
 use std::fs;
 use std::path::Path;
-use std::sync::LazyLock;
 
+use anyhow::Context;
 use camino::{Utf8Path, Utf8PathBuf};
 use config::Config;
 use config::ConfigError as ExternalConfigError;
@@ -137,15 +137,27 @@ impl Settings {
     }
 }
 
-/// The log directory for the application.
+/// Get the log directory for the application and ensure it exists.
 ///
 /// Returns the XDG cache directory (e.g., ~/.cache/djls on Linux) if available,
-/// otherwise falls back to /tmp.
-pub static LOG_DIR: LazyLock<Utf8PathBuf> = LazyLock::new(|| {
-    ProjectDirs::from("", "", "djls")
-        .map(|proj_dirs| Utf8PathBuf::from_path_buf(proj_dirs.cache_dir().to_path_buf()).unwrap())
-        .unwrap_or_else(|| Utf8PathBuf::from("/tmp"))
-});
+/// otherwise falls back to /tmp. Creates the directory if it doesn't exist.
+///
+/// # Errors
+///
+/// Returns an error if the directory cannot be created.
+///
+/// # Panics
+///
+/// Panics if the XDG cache directory path contains invalid UTF-8.
+pub fn log_dir() -> anyhow::Result<Utf8PathBuf> {
+    let dir = ProjectDirs::from("", "", "djls")
+        .map_or_else(|| Utf8PathBuf::from("/tmp"), |proj_dirs| Utf8PathBuf::from_path_buf(proj_dirs.cache_dir().to_path_buf()).unwrap());
+    
+    fs::create_dir_all(&dir)
+        .with_context(|| format!("Failed to create log directory: {dir}"))?;
+    
+    Ok(dir)
+}
 
 #[cfg(test)]
 mod tests {
@@ -669,11 +681,18 @@ args = [
 
         #[test]
         fn test_log_dir_returns_path() {
-            let dir = &*LOG_DIR;
+            let dir = log_dir().unwrap();
             // Either it's the XDG cache dir or /tmp
             assert!(dir.as_str().contains("djls") || dir == "/tmp");
         }
 
+        #[test]
+        fn test_log_dir_creates_directory() {
+            // Test that the function creates the directory
+            let dir = log_dir().unwrap();
+            assert!(dir.exists());
+        }
+
         #[test]
         fn test_log_dir_xdg_pattern() {
             // Verify that if ProjectDirs is available, it returns a proper path

crates/djls-server/src/lib.rs

@@ -15,6 +15,11 @@ use tower_lsp_server::Server;
 pub use crate::server::DjangoLanguageServer;
 pub use crate::session::Session;
 
+/// Run the Django language server.
+///
+/// # Panics
+///
+/// Panics if the logging system cannot be initialized (e.g., unable to create log directory).
 pub fn run() -> Result<()> {
     if std::io::stdin().is_terminal() {
         eprintln!(
@@ -55,7 +60,8 @@ pub fn run() -> Result<()> {
                         client.log_message(message_type, message).await;
                     });
                 }
-            });
+            })
+            .expect("Failed to initialize logging");
 
             DjangoLanguageServer::new(client, log_guard)
         })

crates/djls-server/src/logging.rs

@@ -111,17 +111,15 @@ where
 /// - `EnvFilter`: respects `RUST_LOG` env var, defaults to "info"
 ///
 /// Returns a `WorkerGuard` that must be kept alive for the file logging to work.
-pub fn init_tracing<F>(send_message: F) -> WorkerGuard
+///
+/// # Errors
+///
+/// Returns an error if the log directory cannot be created.
+pub fn init_tracing<F>(send_message: F) -> anyhow::Result<WorkerGuard>
 where
     F: Fn(lsp_types::MessageType, String) + Send + Sync + 'static,
 {
-    // Get log directory from djls-conf
-    let log_dir = &*djls_conf::LOG_DIR;
-    
-    // Ensure the log directory exists
-    if let Err(e) = std::fs::create_dir_all(log_dir) {
-        eprintln!("Warning: Failed to create log directory {log_dir}: {e}");
-    }
+    let log_dir = djls_conf::log_dir()?;
 
     let file_appender = tracing_appender::rolling::daily(log_dir.as_std_path(), "djls.log");
     let (non_blocking, guard) = tracing_appender::non_blocking(file_appender);
@@ -142,5 +140,5 @@ where
 
     Registry::default().with(file_layer).with(lsp_layer).init();
 
-    guard
+    Ok(guard)
 }