Create djls-testing crate (#670)

Author: joshuadavidthomas

.github/workflows/bench.yml

@@ -33,13 +33,13 @@ jobs:
       - name: Cache corpus
         uses: actions/cache@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5.0.5
         with:
-          path: crates/djls-corpus/.corpus
-          key: ${{ runner.os }}-corpus-${{ hashFiles('crates/djls-corpus/manifest.lock') }}
+          path: crates/djls-testing/.corpus
+          key: ${{ runner.os }}-corpus-${{ hashFiles('crates/djls-testing/manifest.lock') }}
           restore-keys: |
             ${{ runner.os }}-corpus-
 
       - name: Sync corpus
-        run: cargo run -q -p djls-corpus -- sync
+        run: cargo run -q -p djls-testing --bin corpus -- sync
 
       - run: cargo install cargo-codspeed --locked
 

.github/workflows/test.yml

@@ -107,8 +107,8 @@ jobs:
       - name: Cache corpus
         uses: actions/cache@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5.0.5
         with:
-          path: crates/djls-corpus/.corpus
-          key: ${{ runner.os }}-corpus-${{ hashFiles('crates/djls-corpus/manifest.lock') }}
+          path: crates/djls-testing/.corpus
+          key: ${{ runner.os }}-corpus-${{ hashFiles('crates/djls-testing/manifest.lock') }}
           restore-keys: |
             ${{ runner.os }}-corpus-
 

ARCHITECTURE.md

@@ -120,9 +120,9 @@ Settings and diagnostics configuration. Merges configuration from multiple sourc
 
 Benchmarks using [divan](https://github.com/nvzqz/divan). Owns a `BenchDatabase` that implements `SemanticDb` with realistic tag specs, plus benchmarks for parsing, validation, extraction, and full-pipeline `djls check` runs. `just dev profile <bench> [filter]` generates flamegraphs.
 
-### `crates/djls-corpus`
+### `crates/djls-testing`
 
-Corpus management for integration tests. Syncs real-world Django project source — templates and templatetag modules from 40+ packages and 17 real projects — for testing extraction and validation against code that actually exists in the wild. See the [Testing](#testing) section for how corpus tests work.
+Shared test infrastructure. Owns the corpus sync tool, shared Salsa test database, fixture builders, and markdown test runner. The corpus syncs real-world Django project source — templates and templatetag modules from 40+ packages and 17 real projects — for testing extraction and validation against code that actually exists in the wild. See the [Testing](#testing) section for how corpus tests work.
 
 ## The Database Trait Stack
 
@@ -279,7 +279,7 @@ Corpus tests serve two purposes:
 1. **Extraction snapshot tests** — parse every `templatetags/*.py` file with the Ruff parser and snapshot the extracted rules. This catches regressions in Python AST analysis and documents what we can extract from real-world code.
 2. **Validation integration tests** — validate real templates against extracted rules. This is our "zero false positives" check: if we report a diagnostic on a template from a real project, it's probably a bug in our analysis, not in the project.
 
-The corpus is deliberately not checked into the repository (it's ~hundreds of MB of third-party source). `just corpus sync` downloads it from the lockfile (`crates/djls-corpus/manifest.lock`), which pins exact versions and SHA-256 checksums.
+The corpus is deliberately not checked into the repository (it's ~hundreds of MB of third-party source). `just corpus sync` downloads it from the lockfile (`crates/djls-testing/manifest.lock`), which pins exact versions and SHA-256 checksums.
 
 ### Incremental Computation Tests
 

Cargo.lock

@@ -9,7 +9,6 @@ edition = "2024"
 djls = { path = "crates/djls" }
 djls-bench = { path = "crates/djls-bench" }
 djls-conf = { path = "crates/djls-conf" }
-djls-corpus = { path = "crates/djls-corpus" }
 djls-db = { path = "crates/djls-db" }
 djls-format = { path = "crates/djls-format" }
 djls-ide = { path = "crates/djls-ide" }
@@ -18,6 +17,7 @@ djls-semantic = { path = "crates/djls-semantic" }
 djls-server = { path = "crates/djls-server" }
 djls-source = { path = "crates/djls-source" }
 djls-templates = { path = "crates/djls-templates" }
+djls-testing = { path = "crates/djls-testing" }
 
 # core deps, pin exact versions
 salsa = "0.26.1"

Cargo.toml

@@ -27,7 +27,7 @@ clean:
     cargo clean
 
 corpus *ARGS:
-    cargo run -q -p djls-corpus -- {{ ARGS }}
+    cargo run -q -p djls-testing --bin corpus -- {{ ARGS }}
 
 clippy *ARGS:
     cargo clippy --all-targets --all-features --benches --fix {{ ARGS }} -- -D warnings

Justfile

@@ -5,13 +5,13 @@ edition.workspace = true
 
 [dependencies]
 djls-conf = { workspace = true }
-djls-corpus = { workspace = true }
 djls-db = { workspace = true }
 djls-ide = { workspace = true }
 djls-project = { workspace = true }
 djls-semantic = { workspace = true }
 djls-source = { workspace = true }
 djls-templates = { workspace = true }
+djls-testing = { workspace = true }
 
 camino = { workspace = true }
 divan = { workspace = true }

crates/djls-bench/Cargo.toml

@@ -71,13 +71,13 @@ struct CorpusTemplates {
 }
 
 fn load_corpus_inner(
-    get_paths: impl FnOnce(&djls_corpus::Corpus) -> Option<Vec<Utf8PathBuf>>,
+    get_paths: impl FnOnce(&djls_testing::Corpus) -> Option<Vec<Utf8PathBuf>>,
 ) -> Option<CorpusTemplates> {
-    if !djls_corpus::Corpus::is_available() {
+    if !djls_testing::Corpus::is_available() {
         return None;
     }
 
-    let corpus = djls_corpus::Corpus::require();
+    let corpus = djls_testing::Corpus::require();
     let mut template_paths = get_paths(&corpus)?;
     template_paths.sort();
 

crates/djls-bench/benches/check.rs

@@ -101,21 +101,21 @@ struct CorpusModels {
 }
 
 fn load_corpus_models_inner(
-    get_paths: impl FnOnce(&djls_corpus::Corpus) -> Option<Vec<Utf8PathBuf>>,
+    get_paths: impl FnOnce(&djls_testing::Corpus) -> Option<Vec<Utf8PathBuf>>,
 ) -> Option<CorpusModels> {
-    if !djls_corpus::Corpus::is_available() {
+    if !djls_testing::Corpus::is_available() {
         return None;
     }
 
-    let corpus = djls_corpus::Corpus::require();
+    let corpus = djls_testing::Corpus::require();
     let mut paths = get_paths(&corpus)?;
     paths.sort();
 
     let files: Vec<(String, String)> = paths
         .into_iter()
         .filter_map(|path| {
             let source = std::fs::read_to_string(path.as_std_path()).ok()?;
-            let module_path = djls_corpus::module_path_from_file(&path);
+            let module_path = djls_testing::module_path_from_file(&path);
             Some((source, module_path))
         })
         .collect();

crates/djls-bench/benches/models.rs

@@ -16,7 +16,7 @@ tower-lsp-server = { workspace = true }
 tracing = { workspace = true }
 
 [dev-dependencies]
-salsa = { workspace = true }
+djls-testing = { workspace = true }
 
 [lints]
 workspace = true