Merge pull request #38 from joshuajaco/eslint-9

Add eslint v9 support

Author: joshuajaco

.eslintrc.json

@@ -26,7 +26,6 @@ jobs:
       - run: pnpm format:check
       - run: pnpm lint
       - run: pnpm test
-      - name: Coveralls
-        uses: coverallsapp/github-action@v2
+      - uses: coverallsapp/github-action@v2
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/ci.yml

@@ -0,0 +1,41 @@
+import js from "@eslint/js";
+import node from "eslint-plugin-n";
+import eslintPlugin from "eslint-plugin-eslint-plugin";
+import prettier from "eslint-config-prettier";
+import globals from "globals";
+
+export default [
+  { ignores: ["tests/e2e/fixtures"] },
+  js.configs.recommended,
+  node.configs["flat/recommended"],
+  eslintPlugin.configs["flat/all"],
+  {
+    linterOptions: { reportUnusedDisableDirectives: true },
+    rules: {
+      "arrow-body-style": "warn",
+      strict: "error",
+      "n/prefer-global/buffer": "error",
+      "n/prefer-global/console": "error",
+      "n/prefer-global/process": "error",
+      "n/prefer-global/text-decoder": "error",
+      "n/prefer-global/url": "error",
+      "n/prefer-global/url-search-params": "error",
+      "eslint-plugin/require-meta-docs-url": [
+        "error",
+        {
+          pattern:
+            "https://github.com/joshuajaco/eslint-plugin-workspaces/blob/main/docs/rules/{{name}}.md",
+        },
+      ],
+    },
+  },
+  {
+    files: ["**/*.mjs"],
+    languageOptions: { sourceType: "module" },
+  },
+  {
+    files: ["tests/**/*.js"],
+    languageOptions: { globals: globals.mocha },
+  },
+  prettier,
+];

eslint.config.mjs

@@ -1,28 +1,51 @@
 "use strict";
 
-module.exports.rules = {
-  "no-cross-imports": require("./rules/no-cross-imports"),
-  "no-relative-imports": require("./rules/no-relative-imports"),
-  "no-absolute-imports": require("./rules/no-absolute-imports"),
-  "require-dependency": require("./rules/require-dependency"),
+const plugin = {
+  rules: {
+    "no-cross-imports": require("./rules/no-cross-imports"),
+    "no-relative-imports": require("./rules/no-relative-imports"),
+    "no-absolute-imports": require("./rules/no-absolute-imports"),
+    "require-dependency": require("./rules/require-dependency"),
+  },
+  configs: {
+    recommended: {
+      plugins: ["workspaces"],
+      rules: {
+        "workspaces/no-relative-imports": "error",
+        "workspaces/no-absolute-imports": "error",
+        "workspaces/require-dependency": "error",
+      },
+    },
+    all: {
+      plugins: ["workspaces"],
+      rules: {
+        "workspaces/no-relative-imports": "error",
+        "workspaces/no-absolute-imports": "error",
+        "workspaces/require-dependency": "error",
+        "workspaces/no-cross-imports": "error",
+      },
+    },
+  },
 };
 
-module.exports.configs = {
-  recommended: {
-    plugins: ["workspaces"],
+Object.assign(plugin.configs, {
+  "flat/recommended": {
+    plugins: { workspaces: plugin },
     rules: {
       "workspaces/no-relative-imports": "error",
       "workspaces/no-absolute-imports": "error",
       "workspaces/require-dependency": "error",
     },
   },
-  all: {
-    plugins: ["workspaces"],
+  "flat/all": {
+    plugins: { workspaces: plugin },
     rules: {
       "workspaces/no-relative-imports": "error",
       "workspaces/no-absolute-imports": "error",
       "workspaces/require-dependency": "error",
       "workspaces/no-cross-imports": "error",
     },
   },
-};
+});
+
+module.exports = plugin;

lib/index.js

@@ -20,20 +20,21 @@ module.exports.meta = {
       additionalProperties: false,
       properties: {
         allow: {
+          description:
+            "single or a list of package names to exclude from this rule",
           anyOf: [
             { type: "string" },
             {
               type: "array",
               uniqueItems: true,
-              items: {
-                type: "string",
-              },
+              items: { type: "string" },
             },
           ],
         },
         scopes: {
+          description: "deprecated",
           anyOf: [
-            { type: "boolean", additionalProperties: false },
+            { type: "boolean" },
             {
               type: "object",
               additionalProperties: false,
@@ -47,6 +48,7 @@ module.exports.meta = {
       },
     },
   ],
+  defaultOptions: [{ allow: [], scopes: { enable: false } }],
   messages: { noCrossImports: 'Import from package "{{name}}" is not allowed' },
 };
 

lib/rules/no-cross-imports.js

@@ -28,23 +28,27 @@
   "scripts": {
     "format": "prettier . --write",
     "format:check": "prettier . --check",
-    "lint": "eslint . --ignore-path=.gitignore --max-warnings=0",
-    "lint:fix": "npm run lint -- --fix",
-    "test": "nyc -r=lcov -r=text mocha tests --recursive --file tests/setup.js"
+    "lint": "eslint . --max-warnings=0",
+    "lint:fix": "pnpm lint --fix",
+    "test": "nyc -r=lcov -r=text pnpm run \"/^test:.*/\"",
+    "test:e2e": "mocha tests/e2e/test.js",
+    "test:rules": "mocha tests/rules --recursive --file tests/setup.js"
   },
   "dependencies": {
     "find-workspaces": "^0.3.1"
   },
   "devDependencies": {
-    "@babel/eslint-parser": "^7.25.0",
-    "eslint": "^8.56.0",
-    "eslint-config-prettier": "^9.1.0",
-    "eslint-plugin-eslint-plugin": "^6.2.0",
-    "eslint-plugin-node": "^11.1.0",
-    "mocha": "^10.7.0",
-    "nyc": "^17.0.0",
-    "prettier": "^3.3.3",
-    "sinon": "^18.0.0"
+    "@eslint/js": "^9.27.0",
+    "eslint": "^9.27.0",
+    "eslint-config-prettier": "^10.1.5",
+    "eslint-plugin-eslint-plugin": "^6.4.0",
+    "eslint-plugin-n": "^17.18.0",
+    "eslint8": "npm:[email protected]",
+    "globals": "^16.1.0",
+    "mocha": "^11.3.0",
+    "nyc": "^17.1.0",
+    "prettier": "^3.5.3",
+    "sinon": "^20.0.0"
   },
-  "packageManager": "pnpm@9.6.0"
+  "packageManager": "pnpm@10.11.0"
 }