Fix for nested packages

Author: joshuajaco

lib/rules/no-absolute-imports.js

@@ -31,22 +31,26 @@ module.exports.create = (context) => {
   return getImport(
     workspaces,
     filename,
-    ({ node, path, value, start, end }) => {
-      workspaces.forEach(({ package: { name }, location }) => {
-        if (isSubPath(location, filename) && isWorkspacePath(name, value)) {
-          context.report({
-            node,
-            messageId: "noAbsoluteImports",
-            fix: (fixer) =>
-              fixer.replaceTextRange(
-                [start + 1, end - 1],
-                pathToImport(
-                  relative(dirname(filename), path.replace(name, location)),
+    ({ node, path, value, start, end, currentWorkspace }) => {
+      if (isWorkspacePath(currentWorkspace.package.name, value)) {
+        context.report({
+          node,
+          messageId: "noAbsoluteImports",
+          fix: (fixer) =>
+            fixer.replaceTextRange(
+              [start + 1, end - 1],
+              pathToImport(
+                relative(
+                  dirname(filename),
+                  path.replace(
+                    currentWorkspace.package.name,
+                    currentWorkspace.location,
+                  ),
                 ),
               ),
-          });
-        }
-      });
+            ),
+        });
+      }
     },
   );
 };

lib/rules/no-cross-imports.js

@@ -117,6 +117,7 @@ module.exports.create = (context) => {
         .forEach(({ package: { name }, location }) => {
           if (
             name !== currentWorkspace.package.name &&
+            !isSubPath(currentWorkspace.location, path) &&
             (isWorkspacePath(name, value) || isSubPath(location, path))
           ) {
             context.report({

lib/rules/no-relative-imports.js

@@ -27,7 +27,8 @@ module.exports.create = (context) => {
         if (
           name !== path &&
           name !== currentWorkspace.package.name &&
-          isSubPath(location, path)
+          isSubPath(location, path) &&
+          !isSubPath(currentWorkspace.location, path)
         ) {
           context.report({
             node,

lib/rules/require-dependency.js

@@ -38,6 +38,7 @@ module.exports.create = (context) => {
 
         if (
           name !== currentWorkspace.package.name &&
+          !isSubPath(currentWorkspace.location, path) &&
           (isWorkspacePath(name, value) || isSubPath(location, path)) &&
           !Object.keys(dependencies).includes(name) &&
           !Object.keys(peerDependencies).includes(name) &&

lib/utils.js

@@ -46,9 +46,10 @@ const pathToImport = (path) => {
 const getImport = (workspaces, filename, callback) => {
   if (!workspaces) return {};
 
-  const currentWorkspace = workspaces.find(({ location }) =>
-    isSubPath(location, filename),
-  );
+  const currentWorkspace = workspaces
+    .filter(({ location }) => isSubPath(location, filename))
+    .sort((a, b) => b.location.length - a.location.length)
+    .at(0);
 
   if (!currentWorkspace) return {};
 

tests/mocks.js

@@ -20,6 +20,18 @@ module.exports.findWorkspacesMock = () => [
       name: "@test/third-workspace",
     },
   },
+  {
+    location: "/test/outer",
+    package: {
+      name: "@test/outer",
+    },
+  },
+  {
+    location: "/test/outer/inner",
+    package: {
+      name: "@test/inner",
+    },
+  },
   {
     location: "/test/no-npm-scope-workspace",
     package: {

tests/rules/no-absolute-imports.js

@@ -44,6 +44,14 @@ describe("no-absolute-imports", () => {
         filename: "/test/no-npm-scope-workspace/index.js",
         code: "import './no-npm-scope-workspace';",
       },
+      {
+        filename: "/test/outer/index.js",
+        code: "import '@test/inner';",
+      },
+      {
+        filename: "/test/outer/inner/index.js",
+        code: "import '@test/outer';",
+      },
     ],
 
     invalid: [

tests/rules/no-cross-imports.js

@@ -62,6 +62,22 @@ describe("no-cross-imports", () => {
         filename: "/test/workspace/index.js",
         code: "import './no-npm-scope-workspace';",
       },
+      {
+        filename: "/test/outer/index.js",
+        code: "import '@test/outer';",
+      },
+      {
+        filename: "/test/outer/inner/index.js",
+        code: "import '@test/inner';",
+      },
+      {
+        filename: "/test/outer/index.js",
+        code: "import './utils.js';",
+      },
+      {
+        filename: "/test/outer/inner/index.js",
+        code: "import './utils.js';",
+      },
     ],
 
     invalid: [

tests/rules/no-relative-imports.js

@@ -44,6 +44,14 @@ describe("no-relative-imports", () => {
         filename: "/test/workspace/index.js",
         code: "import './no-npm-scope-workspace';",
       },
+      {
+        filename: "/test/outer/index.js",
+        code: "import './utils.js';",
+      },
+      {
+        filename: "/test/outer/inner/index.js",
+        code: "import './utils.js';",
+      },
     ],
     invalid: [
       {

tests/rules/require-dependency.js

@@ -34,6 +34,22 @@ describe("require-dependency", () => {
         filename: "/test/workspace/index.js",
         code: "import './no-npm-scope-workspace';",
       },
+      {
+        filename: "/test/outer/index.js",
+        code: "import '@test/outer';",
+      },
+      {
+        filename: "/test/outer/inner/index.js",
+        code: "import '@test/inner';",
+      },
+      {
+        filename: "/test/outer/index.js",
+        code: "import './utils.js';",
+      },
+      {
+        filename: "/test/outer/inner/index.js",
+        code: "import './utils.js';",
+      },
     ],
     invalid: [
       {